https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
Markus Trippelsdorf changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
--- Comment #7 from David Malcolm ---
(In reply to Franz Sirl from comment #2)
> Or the '--fcount;'. Does the warning go away if you add braces like that:
>
>void pop(T* elem) { SkASSERT(fCount > 0); if (elem) { *elem =
> (*this)[fCount
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
David Malcolm changed:
What|Removed |Added
Status|RESOLVED|UNCONFIRMED
Resolution|WONTFIX
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
Markus Trippelsdorf changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
--- Comment #4 from Franz Sirl ---
For me, yes. Because as a reader knowing nothing about the code and looking for
some kind of "bug" in the code, I cannot decide easily if the _intention_ was
if (elem)
{
*elem = (*this)[fCount - 1];
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
--- Comment #3 from Markus Trippelsdorf ---
(In reply to Franz Sirl from comment #2)
> Or the '--fcount;'. Does the warning go away if you add braces like that:
>
>void pop(T* elem) { SkASSERT(fCount > 0); if (elem) { *elem =
> (*this)[f
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
Franz Sirl changed:
What|Removed |Added
CC||sirl at gcc dot gnu.org
--- Comment #2 from
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
--- Comment #1 from Richard Biener ---
I'd say SkASSERT macro triggers it.