[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-27 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Marek Polacek changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-27 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #19 from Marek Polacek --- Author: mpolacek Date: Fri Feb 27 14:11:53 2015 New Revision: 221061 URL: https://gcc.gnu.org/viewcvs?rev=221061&root=gcc&view=rev Log: PR c/65040 * doc/invoke.texi: Update to reflect that -Wformat=

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-24 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #18 from Richard Biener --- And it was just mentioned that the diagnostic should print [-Wformat-signedness] not [-Wformat=] (or both)

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-24 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #17 from Jakub Jelinek --- IMHO the warning is completely useless, but perhaps some people disagree.

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-24 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #16 from Marek Polacek --- Ok, I can fix the integer constant case as well. (In reply to Richard Biener from comment #15) > I'd also say that warnings for formats that do not have a signed form are > useless, > thus for %o, %x and %X

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-24 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #15 from Richard Biener --- I'd also say that warnings for formats that do not have a signed form are useless, thus for %o, %x and %X. But I guess you beg to differ.

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-24 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Richard Biener changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-16 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #13 from Marek Polacek --- Note that this patch had a followup: PR65066.

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-14 Thread jirislaby at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #12 from Jiri Slaby --- (In reply to Marek Polacek from comment #10) > That's because on your architecture char is signed by default. Try adding > "unsigned" or using -funsigned-char and the warning should be gone. Ok, I wanted to m

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-14 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #11 from Jakub Jelinek --- -funsigned-char is an option that shouldn't be used without serious consideration. That said, I think in that case the warning is intentional, you are indeed passing a signed value to unsigned format. If yo

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-14 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #10 from Marek Polacek --- That's because on your architecture char is signed by default. Try adding "unsigned" or using -funsigned-char and the warning should be gone.

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-14 Thread jirislaby at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #9 from Jiri Slaby --- What about this? #include void x(char *ch) { printf("%x\n", ch[10]); } It still produces the warning. (I cannot reopen as I am not a reporter.)

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Marek Polacek changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #7 from Marek Polacek --- Author: mpolacek Date: Fri Feb 13 07:56:14 2015 New Revision: 220677 URL: https://gcc.gnu.org/viewcvs?rev=220677&root=gcc&view=rev Log: PR c/65040 * c-format.c (check_format_types): Don't warn about

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread fche at redhat dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Frank Ch. Eigler changed: What|Removed |Added CC||fche at redhat dot com --- Comment #6

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread mark at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Mark Wielaard changed: What|Removed |Added CC||mark at gcc dot gnu.org --- Comment #5 f

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 --- Comment #4 from Jakub Jelinek --- (In reply to Marek Polacek from comment #2) > Taking. I think check_format_types needs a small tweak to look thru > NOP_EXPRs. Well, more like do some lame VR computation and not warn if the signedness does

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Jakub Jelinek changed: What|Removed |Added CC||jakub at gcc dot gnu.org --- Comment #3

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Marek Polacek changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigned a

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Marek Polacek changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c/65040] [5 Regression] gcc-5 -Wformat broken

2015-02-12 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65040 Richard Biener changed: What|Removed |Added Target Milestone|--- |5.0