[PATCH] New check and updates in check_GNU_style script

2014-07-20 Thread Yury Gribov
Hi all, Attached patch adds new check (all blocks of 8 spaces are replaced with tabs) to contrib/check_GNU_style.sh. It also changes the script to allow reading patches from stdin and improves the "Dot, space, space, new sentence." check. -Y commit 4bc624dcd778e8317a4de620b266c05b55577aad Au

RE: Re: [MIPS r5900] libgcc floating point fixes

2014-07-20 Thread Matthew Fortune
"Jürgen Urban" writes: > > "Jürgen Urban" writes: > > > Hello Richard, > > > > > > > "Jürgen Urban" writes: > > Is this something you > > have recently developed outside of the mainline kernel or does it already > exist. > > I'm not aware of such logic in the MIPS kernel yet. > > Yes, this is de

Re: a new libgcov interface: __gcov_dump_all

2014-07-20 Thread Nathan Sidwell
On 07/20/14 21:38, Xinliang David Li wrote: The gcov_info chain is not duplicated -- there is already one chain (linking only modules of the library) per shared library in current implementation. My change does not affect underlying behavior at all -- it merely introduces a new interface to acce

Re: [PATCH, 4.9/4.10] Profile based option tuning

2014-07-20 Thread Pengfei Yuan
Sorry, tabs seems converted to spaces automatically. Please use the attachment instead. 2014-07-21 13:13 GMT+08:00 Pengfei Yuan <0xcool...@gmail.com>: > Hi, > > This patch tunes optimization options based on profile data: > * Disable PGO options if profile is not available or empty. > * Optimize f

[PATCH, 4.9/4.10] Profile based option tuning

2014-07-20 Thread Pengfei Yuan
Hi, This patch tunes optimization options based on profile data: * Disable PGO options if profile is not available or empty. * Optimize for size if profile is available but empty. Here is an experiment on Firefox PGO build: CPU Intel Core i7-4770 RAM 32 GB

Fix RTL load motion bug with -fnon-call-exceptions

2014-07-20 Thread Eric Botcazou
We have a testcase that is miscompiled at -O3 by our GCC 4.9-based compiler, although it isn't by the pristine GCC 4.9 compiler. You need a specific combination of events (aggressive inlining, -fnon-call-exceptions, memory accesses marked MEM_NOTRAP_P) which causes RTL load motion to wrongly de

Fix ICE on unaligned assignment of return value

2014-07-20 Thread Eric Botcazou
This is a regression present on mainline and 4.9 branch and visible e.g. on SPARC64: the code dealing with values returned in PARALLEL fails to handle the case of an unaligned target if the mode is an integral mode and not BLKmode. Tested on SPARC64/Solaris and x86-64/Linux, applied on mainline

Re: a new libgcov interface: __gcov_dump_all

2014-07-20 Thread Xinliang David Li
The gcov_info chain is not duplicated -- there is already one chain (linking only modules of the library) per shared library in current implementation. My change does not affect underlying behavior at all -- it merely introduces a new interface to access private dumper methods associated with shar

Go patch committed: Error for vars that are set but not used

2014-07-20 Thread Ian Lance Taylor
This patch improves the Go frontend to give an error for any variables that are set but not used. This matches the behaviour of the gc Go compiler. This Go language spec does not require this, but it is permitted as an implementation restriction, and it seems like a good idea to make the compiler

Re: a new libgcov interface: __gcov_dump_all

2014-07-20 Thread Nathan Sidwell
On 07/18/14 22:41, Xinliang David Li wrote: Hi, the following patch implements a new dumper interface to allow dumping of profile data for all instrumented shared libraries. For good reasons, existing libgcov implements the dumping on a per-shared library basis (i.e., gcov_exit is hidden, gcov_l

[PATCH, rs6000, committed] Fix unspec typo

2014-07-20 Thread Bill Schmidt
Hi, UNSPEC_VSLDOI was misspelled. It bothered me. I fixed it. Regstrapped on powerpc64le-unknown-linux-gnu, committed as obvious. Thanks, Bill 2014-07-20 Bill Schmidt * config/rs6000/altivec.md (unspec enum): Fix typo in UNSPEC_VSLDOI. (altivec_vsldoi_): Likewise

libgo patch committed: Remove unused variable

2014-07-20 Thread Ian Lance Taylor
This patch from Peter Collingbourne removes an unused variable from libgo. The variable is set but never used, and gccgo was not giving an error about such cases. I will shortly commit a gccgo patch to detect this case. This patch bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. C

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-07-20 Thread Sylvestre Ledru
Joseph, ping :) (I know you were in holidays) S On 07/07/2014 19:17, Sylvestre Ledru wrote: > Hello, > > On 17/06/2014 19:41, Joseph S. Myers wrote: >> On Tue, 17 Jun 2014, Sylvestre Ledru wrote: >> >>> OK. I will do that. >>> We should test the following: >>> * default => run just -Wreturn-type

RE: Re: [MIPS r5900] libgcc floating point fixes

2014-07-20 Thread Jürgen Urban
> "Jürgen Urban" writes: > > Hello Richard, > > > > > "Jürgen Urban" writes: > > > > The problem happens with the r5900 hard float configurations, e.g.: > > > > configure --target=mipsel-linux-gnu --with-float=hard --with-fpu=single > > > > --with-arch=r5900 > > > > I created the attached patch

[PING] Re: Abstract incremental hashing

2014-07-20 Thread Andi Kleen
Andi Kleen writes: > This patchkit abstracts incremental hashing in tree.c and lto.c > to make it easier to plug in new and more efficient hash algorithms. > Right now it uses the old hash algorithms. So it's just a cleanup. > > Passes bootstrap and testing on x86_64-linux. Ping! Could someone

Go testsuite patch committed: compiledir fix

2014-07-20 Thread Ian Lance Taylor
This patch to the Go testsuite driver adds support for having multiple files in a single package for a compiledir test. Ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-07-20 Ian Lance Taylor * go.test/go-test.exp (go-gc-tests): Support multiple files i

Go patch committed: Don't merge dot-import names

2014-07-20 Thread Ian Lance Taylor
This patch to the Go frontend fixes it so that a name included because of a dot import (import . "package") is not merged with the same name defined in an earlier file. Without this patch, the Go compiler would incorrectly accept code that used a name defined by a dot import in a later file. I've

libgo patch committed: Add missing import

2014-07-20 Thread Ian Lance Taylor
This patch from Peter Collingbourne adds a missing import to a libgo test. The Go frontend should have detected this error. The patch for that is forthcoming (http://codereview.appspot.com/116960043) and I am adding a test case to the testsuite (http://codereview.appspot.com/11843). Bootstra

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-20 Thread Tobias Grosser
On July 20, 2014 1:29:30 PM CEST, Roman Gareev wrote: >> I am not aware of any problems with isl 0.12 and would be surprised >if such >> problems exist. Are you? > >I'm not aware of them, too. > >> P.S: As Richard suggested, we may also want to forbid CLooG 0.17. > >I've attached the patch, whic

Re: [GSoC] A formatting issue.

2014-07-20 Thread Tobias Grosser
On July 20, 2014 1:39:08 PM CEST, Roman Gareev wrote: >This patch fixes a formatting issue related to the number of >characters in the line. Is it fine for trunk? Yes. That's an obvious fix. In case you feel a patch is obvious and it only touches graphite. Feel free to commit directly and to

[GSoC] A formatting issue.

2014-07-20 Thread Roman Gareev
This patch fixes a formatting issue related to the number of characters in the line. Is it fine for trunk? -- Cheers, Roman Gareev. 2014-07-20 Roman Gareev gcc/ * graphite-isl-ast-to-gimple.c: Fixes a formatting issue related to the nu

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-20 Thread Roman Gareev
> I am not aware of any problems with isl 0.12 and would be surprised if such > problems exist. Are you? I'm not aware of them, too. > P.S: As Richard suggested, we may also want to forbid CLooG 0.17. I've attached the patch, which adds the requirement for ClooG 0.18.1. Is it fine for trunk? --

[C PATCH] Better location for implicit_decl_warning (PR c/61852)

2014-07-20 Thread Marek Polacek
implicit_decl_warning wasn't getting a location, so the column info was poor. It's easy to fix this up. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2014-07-20 Marek Polacek PR c/61852 * c-decl.c (implicit_decl_warning): Add location_t parameter. Use it.

[PATCH, i386, PR61827] Fix fuse-caller-save-xmm.c test-case

2014-07-20 Thread Tom de Vries
Uros, this patch fixes the problems in test-case gcc.target/i386/fuse-caller-save-xmm.c reported in PR 61827. I've removed the checks for cfi_def_cfa_offset, which were not robust enough for the different configurations. Furthermore, I've: - added checks for all insns that handle the xmm reg

libgo patch committed: Mark varargs function no_split_stack for Clang

2014-07-20 Thread Ian Lance Taylor
This patch from Peter Collingbourne marks the varargs function runtime_sprintf as no_split_stack when using Clang. Apparently Clang does not support split-stack for varargs function. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r ca381cdd378c