David: Ping
Le 2024-06-27 à 20 h 49, Antoni Boucher a écrit :
Le 2024-06-26 à 18 h 01, David Malcolm a écrit :
On Wed, 2024-02-21 at 14:16 -0500, Antoni Boucher wrote:
On Thu, 2023-12-07 at 19:57 -0500, David Malcolm wrote:
On Thu, 2023-12-07 at 17:26 -0500, Antoni Boucher wrote:
Hi.
This
David: Ping.
Le 2024-06-12 à 08 h 21, Antoni Boucher a écrit :
David: Ping.
Le 2024-04-26 à 09 h 51, Antoni Boucher a écrit :
Now that we have a more general way to check if target-dependent types
are supported (see this commit:
https://github.com/rust-lang/gcc/commit
Le 2024-06-26 à 18 h 01, David Malcolm a écrit :
On Wed, 2024-02-21 at 14:16 -0500, Antoni Boucher wrote:
On Thu, 2023-12-07 at 19:57 -0500, David Malcolm wrote:
On Thu, 2023-12-07 at 17:26 -0500, Antoni Boucher wrote:
Hi.
This patch fixes getting the size of size_t (bug 112910).
There
Thanks for the review.
I'm a bit concerned about using unsigned long.
Would it be OK if I change the type to uint64_t?
I could rename the function to gcc_jit_context_new_array_type_u64.
Regards.
Le 2024-06-26 à 11 h 34, David Malcolm a écrit :
On Fri, 2024-02-23 at 09:55 -0500, Antoni Bo
David: Ping.
Le 2024-04-26 à 09 h 51, Antoni Boucher a écrit :
Now that we have a more general way to check if target-dependent types
are supported (see this commit:
https://github.com/rust-lang/gcc/commit/1c9a9b2f1fd914cad911467ec1d29f158643c2ce#diff
gcc_jit_target_info_supports_128bit_int from
this patch, or change it to include the more general way.
David, what are your thoughts on this?
Le 2024-04-19 à 08 h 34, Antoni Boucher a écrit :
David: Ping.
Le 2024-04-09 à 09 h 21, Antoni Boucher a écrit :
David: Ping.
Le 2024-04-01 à 08 h 20, Antoni
oint!
New patch attached.
Le lun. 22 avr. 2024 à 15:13, Antoni Boucher a écrit :
Please move the function to be on lvalue since there are no rvalue types
that are not lvalues that have a name.
Le 2024-04-22 à 09 h 04, Guillaume Gomez a écrit :
Hey Arthur :)
Is there any reason for that getter to
I believe you forgot to regenerate the ChangeLog.
Le 2024-04-22 à 09 h 16, Guillaume Gomez a écrit :
Good point!
New patch attached.
Le lun. 22 avr. 2024 à 15:13, Antoni Boucher a écrit :
Please move the function to be on lvalue since there are no rvalue types
that are not lvalues that
Please move the function to be on lvalue since there are no rvalue types
that are not lvalues that have a name.
Le 2024-04-22 à 09 h 04, Guillaume Gomez a écrit :
Hey Arthur :)
Is there any reason for that getter to return a mutable pointer to the
name? Would something like this work instead
David: Ping.
Le 2024-02-29 à 10 h 34, Antoni Boucher a écrit :
David: Ping.
On Thu, 2024-02-15 at 09:32 -0500, Antoni Boucher wrote:
David: Ping
On Thu, 2024-02-08 at 08:59 -0500, Antoni Boucher wrote:
David: Ping.
On Wed, 2024-01-10 at 18:58 -0500, Antoni Boucher wrote:
Here it is: https
David: Ping.
Le 2024-04-09 à 09 h 21, Antoni Boucher a écrit :
David: Ping.
Le 2024-04-01 à 08 h 20, Antoni Boucher a écrit :
David: Ping.
Le 2024-03-19 à 07 h 03, Arthur Cohen a écrit :
Hi,
On 3/5/24 16:09, David Malcolm wrote:
On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote:
Hi
David: Ping.
Le 2024-04-01 à 08 h 20, Antoni Boucher a écrit :
David: Ping.
Le 2024-03-19 à 07 h 03, Arthur Cohen a écrit :
Hi,
On 3/5/24 16:09, David Malcolm wrote:
On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote:
Hi.
See answers below.
On Thu, 2023-11-09 at 18:04 -0500, David
Hi.
This patch adds a new API to produce an rvalue representing the
alignment of a type.
Thanks for the review.From 12d8e57ca2313002da42672dc86b167baf812ff3 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Thu, 4 Apr 2024 18:57:07 -0400
Subject: [PATCH] libgccjit: Add ability to get the
David: Ping.
Le 2024-03-19 à 07 h 03, Arthur Cohen a écrit :
Hi,
On 3/5/24 16:09, David Malcolm wrote:
On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote:
Hi.
See answers below.
On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote:
On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher
David: Ping.
Le 2024-03-10 à 07 h 05, Iain Buclaw a écrit :
Excerpts from David Malcolm's message of März 5, 2024 4:09 pm:
On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote:
Hi.
See answers below.
On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote:
On Thu, 2023-11-09 at
b 2024, at 20:50, David Malcolm wrote:
On Thu, 2024-02-15 at 17:08 -0500, Antoni Boucher wrote:
Hi.
This patch adds a new option to allow special characters like . and $
in function names.
This is useful to allow for mangling using those characters.
Thanks for the review.
Thanks for the pat
Hi and thanks for the review!
Here's the updated patch.
Le 2024-01-24 à 09 h 54, David Malcolm a écrit :
On Fri, 2024-01-19 at 16:54 -0500, Antoni Boucher wrote:
Hi.
This patch adds a new way to create local variable that won't
generate
debug info: it is to be used for compiler
David: Ping.
On Thu, 2024-01-25 at 07:52 -0500, Antoni Boucher wrote:
> Thanks.
> Can we please agree on some wording to use so I know when the patch
> can
> be pushed. Especially since we're now in stage 4, it would help me if
> you say something like "you can push to ma
David: Ping.
On Thu, 2024-02-15 at 09:32 -0500, Antoni Boucher wrote:
> David: Ping
>
> On Thu, 2024-02-08 at 08:59 -0500, Antoni Boucher wrote:
> > David: Ping.
> >
> > On Wed, 2024-01-10 at 18:58 -0500, Antoni Boucher wrote:
> > > Here it is: https://gcc
David: Ping.
Iain: Ping.
On Tue, 2024-02-13 at 13:37 -0500, Antoni Boucher wrote:
> David: Ping.
>
> On Tue, 2024-02-06 at 07:54 -0500, Antoni Boucher wrote:
> > David: Ping.
> >
> > On Tue, 2024-01-30 at 10:50 -0500, Antoni Boucher wrote:
> > > David: I
I had forgotten to add the doc since there is now a new API.
Here it is.
On Wed, 2024-02-21 at 19:45 -0500, Antoni Boucher wrote:
> Thanks for the review.
>
> Here's the updated patch.
>
> On Thu, 2023-12-07 at 20:04 -0500, David Malcolm wrote:
> > On Thu, 2023-12
Thanks for the review.
Here's the updated patch. See answers to question below.
On Fri, 2024-01-05 at 14:39 -0500, David Malcolm wrote:
> On Fri, 2024-01-05 at 12:09 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds support for setting the comment ident (analogous to
would pass on all targets or if I should add a
target filtering directive to only execute on some target.
What do you think?
On Tue, 2024-01-09 at 11:01 -0500, David Malcolm wrote:
> On Thu, 2023-12-21 at 08:42 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds support f
Thanks for the review.
Here's the updated patch.
On Wed, 2024-01-24 at 12:18 -0500, David Malcolm wrote:
> On Thu, 2023-12-21 at 08:33 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch allows comparing aligned integer types as equal.
> > There's a TODO in the cod
Thanks for the review.
Here's the updated patch.
On Thu, 2023-12-07 at 20:04 -0500, David Malcolm wrote:
> On Thu, 2023-12-07 at 17:29 -0500, Antoni Boucher wrote:
> > Hi.
> > This patches update gcc_jit_context_new_array_type to take the size
> > as
> > an un
On Thu, 2023-12-07 at 19:57 -0500, David Malcolm wrote:
> On Thu, 2023-12-07 at 17:26 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch fixes getting the size of size_t (bug 112910).
> >
> > There's one issue with this patch: like every other feature that
&g
Thanks for the review.
Here's the updated patch.
On Fri, 2023-12-01 at 12:45 -0500, David Malcolm wrote:
> On Thu, 2023-11-16 at 17:20 -0500, Antoni Boucher wrote:
> > I forgot to attach the patch.
> >
> > On Thu, 2023-11-16 at 17:19 -0500, Antoni Boucher wrote:
>
David: Ping.
On Wed, 2024-01-24 at 10:36 -0500, Antoni Boucher wrote:
> Yes, it is for a use case inside of rustc_codegen_gcc.
> The compiler is structured in a way where we don't know if a global
> variable might be constant when it is created.
>
> On Wed, 2024-01-24 a
David: Ping.
On Thu, 2024-01-25 at 16:04 -0500, Antoni Boucher wrote:
> Thanks for the review!
>
> On Wed, 2024-01-24 at 13:10 -0500, David Malcolm wrote:
> > On Thu, 2024-01-11 at 18:42 -0500, Antoni Boucher wrote:
> > > Hi.
> > > This patch fixes the bug 11334
David: Ping.
On Fri, 2024-01-19 at 15:59 -0500, Antoni Boucher wrote:
> David: Ping.
>
> On Thu, 2023-12-21 at 11:59 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds the ability to send const pointer as argument to a
> > function.
> > Thanks for the review.
>
David: Ping.
On Fri, 2024-01-19 at 15:21 -0500, Antoni Boucher wrote:
> David: Ping.
>
> On Thu, 2023-11-30 at 17:16 -0500, Antoni Boucher wrote:
> > All of these are fixed in this new patch.
> > Thanks for the review.
> >
> > On Mon, 2023-11-20 at 18:05 -0500,
David: Ping.
On Thu, 2023-12-21 at 08:36 -0500, Antoni Boucher wrote:
> Hi.
> Here's the updated patch.
> Thanks.
>
> On Thu, 2023-12-07 at 20:15 -0500, David Malcolm wrote:
> > On Thu, 2023-12-07 at 17:34 -0500, Antoni Boucher wrote:
> > &g
Hi.
This patch adds a new option to allow special characters like . and $
in function names.
This is useful to allow for mangling using those characters.
Thanks for the review.
From 89a92e561ca83a622dcc22a6500ca2b17551edb1 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Thu, 15 Feb 2024 17:03
here?
Thanks for the review.
From 755c72478dc5ba8f6920c9ca27559f5d426a41f5 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Mon, 12 Feb 2024 19:49:43 -0400
Subject: [PATCH] libgccjit: Do not treat warnings as errors
gcc/jit/ChangeLog:
* jit-playback.cc (add_error, add_error_va): Send DK_ERR
It's OK to merge even though it touches files outside of the jit
directory and we're in stage 4?
Or do we need some kind of approval?
On Thu, 2024-02-15 at 10:35 -0500, David Malcolm wrote:
> On Thu, 2024-02-08 at 17:09 -0500, Antoni Boucher wrote:
> > Hi.
> > This p
Hi.
This patch adds some missing builtins that can be generated by
optimizations.
I'm not sure how to add a test for this one.
Do you know the C code that can be optimized to a builtin_clz?
Thanks for the review.
From 578cb40bd333abf57e5b3b08d3453bdcf7ad80b5 Mon Sep 17 00:00:00 2001
From: A
This patch is indeed not necessary anymore.
On Wed, 2024-01-10 at 09:32 -0500, David Malcolm wrote:
> On Wed, 2024-01-10 at 09:30 -0500, David Malcolm wrote:
> > On Thu, 2023-11-16 at 17:28 -0500, Antoni Boucher wrote:
> > > Hi.
> > > This patch fixes a segfault
David: Ping.
On Thu, 2024-02-08 at 17:09 -0500, Antoni Boucher wrote:
> Hi.
> This patch fixes the bug 113842.
> I cannot yet add a test with this patch since it requires using
> try/catch which is not yet merged in master.
> Thanks for the review.
David: Ping
On Thu, 2024-02-08 at 08:59 -0500, Antoni Boucher wrote:
> David: Ping.
>
> On Wed, 2024-01-10 at 18:58 -0500, Antoni Boucher wrote:
> > Here it is: https://gcc.gnu.org/pipermail/jit/2023q4/001725.html
> >
> > On Wed, 2024-01-10 at 18:44 -0500, David
David: Ping.
On Tue, 2024-02-06 at 07:54 -0500, Antoni Boucher wrote:
> David: Ping.
>
> On Tue, 2024-01-30 at 10:50 -0500, Antoni Boucher wrote:
> > David: I'm unsure what to do here. It seems we cannot find a
> > reviewer.
> > Would it help if I show you t
Hi.
This patch fixes the bug 113842.
I cannot yet add a test with this patch since it requires using
try/catch which is not yet merged in master.
Thanks for the review.
From 71f5f5fa8e68594454d5511b6d0c795bc6a8c37a Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Fri, 26 Jan 2024 11:31:47
David: Ping.
On Wed, 2024-01-10 at 18:58 -0500, Antoni Boucher wrote:
> Here it is: https://gcc.gnu.org/pipermail/jit/2023q4/001725.html
>
> On Wed, 2024-01-10 at 18:44 -0500, David Malcolm wrote:
> > On Wed, 2024-01-10 at 18:29 -0500, Antoni Boucher wrote:
> > > David:
David: Ping.
On Tue, 2024-01-30 at 10:50 -0500, Antoni Boucher wrote:
> David: I'm unsure what to do here. It seems we cannot find a
> reviewer.
> Would it help if I show you the code in gccrs that is similar?
> Would it help if I ask someone from gccrs to review this code?
>
David: I'm unsure what to do here. It seems we cannot find a reviewer.
Would it help if I show you the code in gccrs that is similar?
Would it help if I ask someone from gccrs to review this code?
On Sat, 2024-01-20 at 09:50 -0500, Antoni Boucher wrote:
> CC-ing Iain in case they ca
Thanks for the review!
On Wed, 2024-01-24 at 13:10 -0500, David Malcolm wrote:
> On Thu, 2024-01-11 at 18:42 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch fixes the bug 113343.
> > I'm wondering if there's a better solution than using mpfr.
> &g
024-01-19 at 16:55 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch allows comparing different instances of array types as
> > equal.
> > Thanks for the review.
>
> Thanks; the patch looks good to me.
>
> Dave
>
Yes, it is for a use case inside of rustc_codegen_gcc.
The compiler is structured in a way where we don't know if a global
variable might be constant when it is created.
On Wed, 2024-01-24 at 10:09 -0500, David Malcolm wrote:
> On Fri, 2024-01-19 at 16:57 -0500, Antoni Boucher wrote
CC-ing Iain in case they can do the review since it is based on how
they did it in the D frontend.
Could you please do the review?
Thanks!
On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote:
> On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch a
2001
From: Antoni Boucher
Date: Tue, 24 May 2022 17:45:01 -0400
Subject: [PATCH] libgccjit: Add gcc_jit_global_set_readonly
gcc/jit/ChangeLog:
* docs/topics/compatibility.rst (LIBGCCJIT_ABI_26): New ABI tag.
* docs/topics/expressions.rst: Document gcc_jit_global_set_readonly.
* jit-playba
Hi.
This patch allows comparing different instances of array types as
equal.
Thanks for the review.
From ef4afd9de440f10502f3cc84b2112cf83cde2610 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Tue, 2 Jan 2024 16:04:10 -0500
Subject: [PATCH] libgccjit: Allow comparing array types
gcc/jit
Hi.
This patch adds a new way to create local variable that won't generate
debug info: it is to be used for compiler-generated variables.
Thanks for the review.
From 6f69e9db77f3c7e019fae74414ba5eed15298514 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Thu, 18 Jan 2024 16:54:59
David: Ping.
On Thu, 2023-12-21 at 16:01 -0500, Antoni Boucher wrote:
> Hi.
> This patch adds the support for the convert vector internal function.
> I'll need to double-check that making the decl a register is
> necessary.
> Thanks for the review.
David: Ping.
On Thu, 2023-12-21 at 11:59 -0500, Antoni Boucher wrote:
> Hi.
> This patch adds the ability to send const pointer as argument to a
> function.
> Thanks for the review.
David: Ping.
On Thu, 2023-12-21 at 08:33 -0500, Antoni Boucher wrote:
> Hi.
> This patch allows comparing aligned integer types as equal.
> There's a TODO in the code about whether we should check that the
> alignment is equal.
> What are your thoughts on this?
>
> Thanks for the review.
David: Ping.
On Thu, 2023-11-30 at 17:16 -0500, Antoni Boucher wrote:
> All of these are fixed in this new patch.
> Thanks for the review.
>
> On Mon, 2023-11-20 at 18:05 -0500, David Malcolm wrote:
> > On Fri, 2023-11-17 at 17:36 -0500, Antoni Boucher wrote:
> > >
David: Ping.
On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote:
> On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds support for getting the CPU features in libgccjit
> > (bug
> > 112466)
> >
> > There's a TODO in
'm not sure how to write a test this fix. Any ideas?
Thanks for the review.
From 8ddfd4abbe6e46efc256030c2d010f035cd9ecf0 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Sat, 21 Oct 2023 11:20:46 -0400
Subject: [PATCH] libgccjit: Fix float playback for cross-compilation
gcc/jit
Here's an updated patch to include the change from this PATCH:
https://gcc.gnu.org/pipermail/jit/2023q4/001763.html
On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote:
> On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds support for gett
Here it is: https://gcc.gnu.org/pipermail/jit/2023q4/001725.html
On Wed, 2024-01-10 at 18:44 -0500, David Malcolm wrote:
> On Wed, 2024-01-10 at 18:29 -0500, Antoni Boucher wrote:
> > David: Ping in case you missed this patch.
>
> For some reason it's not showing up in patchw
David: Ping in case you missed this patch.
On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote:
> On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc-patches
> wrote:
> >
> > Hi.
> > This patch adds support for machine-dependent builtins in libgccjit
> > (b
It seems I cannot reproduce the issue.
Should we drop this patch, then?
Or do you think there's value in keeping it?
On Mon, 2022-06-06 at 19:01 -0400, David Malcolm wrote:
> On Thu, 2022-06-02 at 21:23 -0400, Antoni Boucher via Gcc-patches
> wrote:
> > Sorry, forgot to
David: Ping in case you missed it.
On Wed, 2023-12-13 at 14:56 -0500, Antoni Boucher wrote:
> David: Ping.
> I guess if we want to have this merged for this release, it should be
> sooner rather than later (if it's still an option).
>
> On Thu, 2023-11-09 at 18:04 -0500,
On Tue, 2024-01-09 at 11:33 -0500, David Malcolm wrote:
> On Fri, 2023-12-22 at 10:25 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds the support of the sizeof operator.
> > I was wondering if this new API entrypoint should take a location
> > as
> > a
, David Malcolm wrote:
> On Fri, 2023-12-22 at 09:39 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds missing builtins needed by optimizations.
> > Thanks for the review.
>
> The patch looks good to me.
>
> Thanks!
> Dave
>
On Wed, 2024-01-10 at 10:19 -0500, David Malcolm wrote:
> On Mon, 2023-12-11 at 19:20 -0500, Antoni Boucher wrote:
> > I'm not sure how to do this. I tried the following commands, but
> > this
> > fails even on master:
> >
> > ../../gcc/configure --enable-hos
Hi.
This patch adds support for setting the comment ident (analogous to
#ident "comment" in C).
Thanks for the review.
From 1af4e77540001cce8c30e86040c1da785e435810 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Fri, 27 Oct 2023 17:36:03 -0400
Subject: [PATCH] libgccjit: Add s
Hi.
This patch adds the support of the sizeof operator.
I was wondering if this new API entrypoint should take a location as a
parameter. What do you think?
Thanks for the review.
From e86e00efae450f04bc92ae6e4e61cf92c38d9b7d Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Tue, 19 Sep 2023 22
Hi.
This patch adds missing builtins needed by optimizations.
Thanks for the review.
From 5ef20748a140d3384294a4218e6db7420cef692d Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Tue, 3 Jan 2023 15:04:41 -0500
Subject: [PATCH] libgccjit: Add missing builtins needed by optimizations
gcc/jit
Hi.
This patch adds the support for the convert vector internal function.
I'll need to double-check that making the decl a register is necessary.
Thanks for the review.
From ca4b3606c853b3425cf4ef9e88fbd5939f0e8f7c Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Sat, 14 May 2022 17:
Hi.
This patch adds the ability to send const pointer as argument to a
function.
Thanks for the review.
From f53c4600d8103a5612e7de6cb8205cad37421074 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Tue, 24 May 2022 17:44:53 -0400
Subject: [PATCH] libgccjit: Allow sending a const pointer as
From 45719be81ab71983ab10ecb67139eaf02955e4db Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Mon, 3 Oct 2022 19:11:39 -0400
Subject: [PATCH] libgccjit: Support signed char flag
gcc/jit/ChangeLog:
* dummy-frontend.cc (jit_langhook_init): Send flag_signed_char
argument to build_common_tree_nodes.
---
gc
Hi.
Here's the updated patch.
Thanks.
On Thu, 2023-12-07 at 20:15 -0500, David Malcolm wrote:
> On Thu, 2023-12-07 at 17:34 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds checks gcc_jit_block_add_assignment_op to make sure
> > it
> > is only ever called
Hi.
This patch allows comparing aligned integer types as equal.
There's a TODO in the code about whether we should check that the
alignment is equal.
What are your thoughts on this?
Thanks for the review.
From b1db2e31729876d313061a94c13b155bcd552c02 Mon Sep 17 00:00:00 2001
From: Antoni Bo
David: Ping.
I guess if we want to have this merged for this release, it should be
sooner rather than later (if it's still an option).
On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote:
> On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds
d passes4750
# of unexpected failures27
# of expected failures 16
# of unsupported tests 43
Am I doing something wrong?
On Fri, 2023-12-01 at 12:49 -0500, David Malcolm wrote:
> On Thu, 2023-11-30 at 17:13 -0500, Antoni Boucher wrote:
> > Here's the
Can I merge this on master even though we're not in phase 1 anymore?
On Thu, 2023-12-07 at 20:07 -0500, David Malcolm wrote:
> On Thu, 2023-12-07 at 17:32 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch changes the function is_int to return false on vector
> > types.
From: Antoni Boucher
Date: Wed, 18 Oct 2023 18:33:18 -0400
Subject: [PATCH] libgccjit: Add type checks in gcc_jit_block_add_assignment_op
gcc/jit/ChangeLog:
* libgccjit.cc (RETURN_IF_FAIL_PRINTF3): New macro.
(gcc_jit_block_add_assignment_op): Add numeric checks.
gcc/testsuite/ChangeLog
Hi.
This patch changes the function is_int to return false on vector types.
Thanks for the review.
From 60ebfb998bd349ca2f05b115de5452378027e4de Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Thu, 26 Oct 2023 19:17:55 -0400
Subject: [PATCH] libgccjit: Make is_int return false on vector types
27;t, what would you suggest?
Thanks.
From 59b7e8af99d5f680e6d622631b1b75609fe1b982 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Sat, 4 Mar 2023 00:44:49 -0500
Subject: [PATCH] libgccjit: Make new_array_type take unsigned long
---
gcc/jit/jit-playback.cc | 2 +-
gcc/jit/jit-playback.h
and playback as far as I understand.
That's a long-term solution, but I wanted to share the idea now and
gather your thoughts on that.
Thanks for the review.
From 37d25e55a0c79893c7ea7f4cb9f0842b8a9b4906 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Fri, 3 Nov 2023 17:49:18 -0400
Subjec
It seems like you forgot to prefix the commit message with "libgccjit:
".
On Thu, 2023-11-30 at 10:55 +0100, Guillaume Gomez wrote:
> Ping David. :)
>
> Le jeu. 23 nov. 2023 à 22:59, Antoni Boucher a
> écrit :
> > David: I found back the comment you made. Here it is
David: ping.
On Thu, 2023-11-16 at 17:20 -0500, Antoni Boucher wrote:
> I forgot to attach the patch.
>
> On Thu, 2023-11-16 at 17:19 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds the support for the type bfloat16 (bug 112574).
> >
> > This was as
All of these are fixed in this new patch.
Thanks for the review.
On Mon, 2023-11-20 at 18:05 -0500, David Malcolm wrote:
> On Fri, 2023-11-17 at 17:36 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds a vector permutation and vector access operations
> > (bug
> >
t; > On Fri, 2023-11-10 at 11:02 -0500, Antoni Boucher wrote:
> > > Hi.
> > > This patch fixes the segfault when using -flto with libgccjit
> > > (bug
> > > 111396).
> > >
> > > You mentioned in bugzilla that this didn't fix the
See more answers below.
On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote:
> > Hi.
> > See answers below.
> >
> > On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote:
> > > > On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote:
> > > >
I will need to not forget to update the function tree_type_to_jit_type
in dummy-frontend.cc to add back the support for bfloat16 when the
patch for it is merged.
On Thu, 2023-11-23 at 17:17 -0500, Antoni Boucher wrote:
> Hi.
> I did split the patch and sent one for the bfloat16 suppo
Hi.
I did split the patch and sent one for the bfloat16 support and another
one for the vector support.
Here's the updated patch for the machine-dependent builtins.
Regards.
On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote:
> On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc
, "alias",
"__foo");
gcc_jit_function_add_attribute (ctxt, attr1);
gcc_jit_function_add_attribute (ctxt, attr2);
or somesuch? But I think the API you currently have is OK.
On Thu, 2023-11-23 at 22:52 +0100, Guillaume Gomez wrote:
> Ping David. :)
>
hould we wait until I send the patch for try/catch?
Thanks for the review.
From 6beb6452c7bac9ecbdaea750d61d6e6c6bd3ed8f Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Sun, 16 Apr 2023 13:19:20 -0400
Subject: [PATCH] libgccjit: Add ways to set the personality function
gcc/ChangeLog:
PR jit/1
Hi.
This patch adds a vector permutation and vector access operations (bug
112602).
This was split from this patch:
https://gcc.gnu.org/pipermail/jit/2023q1/001606.html
Thanks for the review.
From 25b386334f22845d7ba1b60658730373eb6ddbb3 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Fri
On 11/16/23 15:36, Antoni Boucher wrote:
> > Hi.
> > This patch fixes a RTL bug when using some target-specific builtins
> > in
> > libgccjit (bug 112576).
> >
> > The test use a function from an unmerged patch:
> > https://gcc.gnu.org/pipermail/jit/2023q
From: Antoni Boucher
Date: Thu, 9 Jun 2022 20:57:41 -0400
Subject: [PATCH] libgccjit Fix a RTL bug for libgccjit
This fixes a 'unrecognizable insn' error when generating some code using
target-specific builtins.
gcc/ChangeLog:
PR jit/112576
* emit-rtl.cc (init_emit_once): Do not
er to be able to reproduce the issue.
I'm also not sure I put the cleanup in the correct location.
Is there any finalizer function for target specific code?
Thanks to fix this issue.
From e0f4f51682266bc9f507afdb64908ed3695a2f5e Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Thu, 2 Nov
I forgot to attach the patch.
On Thu, 2023-11-16 at 17:19 -0500, Antoni Boucher wrote:
> Hi.
> This patch adds the support for the type bfloat16 (bug 112574).
>
> This was asked to be splitted from a another patch sent here:
> https://gcc.gnu.org/pipermail/jit/2023q1/001607.html
Hi.
This patch adds the support for the type bfloat16 (bug 112574).
This was asked to be splitted from a another patch sent here:
https://gcc.gnu.org/pipermail/jit/2023q1/001607.html
Thanks for the review.
David: another thing I remember you mentioned when you reviewed an
earlier version of this patch is the usage of `std::pair`.
I can't find where you said that, but I remember you mentioned that we
should use a struct instead.
Can you please elaborate again?
Thanks.
On Wed, 2023-11-15 at 17:53 +010
ould you please check if this fixes the issue on your side as well?
Since this patch changes files outside of gcc/jit, what tests should I
run to make sure it didn't break anything?
Thanks for the review.
From f26d0f37e8d83bce1f5aa53c393961a8bd518d16 Mon Sep 17 00:00:00 2001
From: Antoni Bo
Hi.
See answers below.
On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote:
> On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote:
> > Hi.
> > This patch adds support for getting the CPU features in libgccjit
> > (bug
> > 112466)
> >
> > There's
Hash to be able to have a
std::unordered_set. Is there any built-in way of doing
this?
Thanks for the review.
From 302f9f0bb22deae3deb8249a9127447c3ec4f7c7 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Mon, 26 Jun 2023 18:29:15 -0400
Subject: [PATCH] libgccjit: Add ability to get CPU fea
/9d5b6b20efa20825926196759d50706a604c64a8
so you might as well include all of this (except the linetable
condition in toplev.cc).
On Tue, 2023-09-12 at 14:38 -0400, David Malcolm wrote:
> On Tue, 2023-09-12 at 13:36 -0400, Antoni Boucher wrote:
> > In the mean time, here's a (Rust) reproducer for the issu
1 - 100 of 192 matches
Mail list logo