> I'm going to bootstrap & regtest this on x86_64-unknown-linux-gnu
> (with again zero testing coverage ...). The patch fixes the
> reported ICE with a cross to cris-elf, more testing is appreciated
> (though I guess autotesters will pick it up).
>
> Does it look sane?
Yes, I think so, but...
>
On Thu, 5 May 2011, Hans-Peter Nilsson wrote:
> On Thu, 5 May 2011, Richard Guenther wrote:
> > On Wed, 4 May 2011, Richard Guenther wrote:
> > > On Wed, 4 May 2011, Eric Botcazou wrote:
> > > Hm. I guess people will scream if something breaks (I can't imagine
> > > what though).
>
> AAAaaarghh!
On Thu, 5 May 2011, Richard Guenther wrote:
> On Wed, 4 May 2011, Richard Guenther wrote:
> > On Wed, 4 May 2011, Eric Botcazou wrote:
> > Hm. I guess people will scream if something breaks (I can't imagine
> > what though).
AAAaaarghh! Building cris-elf is now broken.
> I have applied the foll
On Wed, 4 May 2011, Richard Guenther wrote:
> On Wed, 4 May 2011, Eric Botcazou wrote:
>
> > > I think I did it that way because the old code tried to re-construct
> > > the type of the original amount. I can surely simply use op1 here
> > > if that is preferred.
> >
> > Right, but it used the
On Wed, 4 May 2011, Eric Botcazou wrote:
> > I think I did it that way because the old code tried to re-construct
> > the type of the original amount. I can surely simply use op1 here
> > if that is preferred.
>
> Right, but it used the value of OP1 so I think the new code should as well.
Ok, I
> I think I did it that way because the old code tried to re-construct
> the type of the original amount. I can surely simply use op1 here
> if that is preferred.
Right, but it used the value of OP1 so I think the new code should as well.
> Btw, do you happen to know any target that would excerc
On Wed, 4 May 2011, Eric Botcazou wrote:
> > 2011-05-03 Richard Guenther
> >
> > * expmed.c (expand_variable_shift): Rename to ...
> > (expand_shift_1): ... this. Take an expanded shift amount.
> > For rotates recurse directly not building trees for the shift amount.
> > (expan
> 2011-05-03 Richard Guenther
>
> * expmed.c (expand_variable_shift): Rename to ...
> (expand_shift_1): ... this. Take an expanded shift amount.
> For rotates recurse directly not building trees for the shift amount.
> (expand_variable_shift): Wrap around expand_shift_1.
This is the promised followup to the expand_shift reorg. The following
patch makes the worker take an RTL expanded shift amount and avoids
re-creating adjusted trees if it recurses for expanding rotates. Most
of the scary code (involving the conversions) originated from the
fix for PR27861 - but
