Re: Allow passing arrays in registers on AArch64

2014-02-18 Thread Michael Hudson-Doyle
Jakub Jelinek writes: > On Tue, Feb 11, 2014 at 02:51:08PM +, Marcus Shawcroft wrote: >> On 6 February 2014 22:51, Michael Hudson-Doyle >> wrote: >> >> > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c >> > index 16c51a8..958c667 100644 >> > --- a/gcc/config/aarch64

Re: Allow passing arrays in registers on AArch64

2014-02-11 Thread Jakub Jelinek
On Tue, Feb 11, 2014 at 02:51:08PM +, Marcus Shawcroft wrote: > On 6 February 2014 22:51, Michael Hudson-Doyle > wrote: > > > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > > index 16c51a8..958c667 100644 > > --- a/gcc/config/aarch64/aarch64.c > > +++ b/gcc/config/

Re: Allow passing arrays in registers on AArch64

2014-02-11 Thread Marcus Shawcroft
On 6 February 2014 22:51, Michael Hudson-Doyle wrote: > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 16c51a8..958c667 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -1187,14 +1187,10 @@ aarch64_pass_by_reference (cumulativ

Re: Allow passing arrays in registers on AArch64

2014-02-06 Thread Michael Hudson-Doyle
Ramana Radhakrishnan writes: > On Tue, Feb 4, 2014 at 2:12 AM, Michael Hudson-Doyle > wrote: >> Ping? I'm attaching a marginally cleaner version of the test. I've had >> a look at integrating this into aapcs64.exp but got defeated in the >> end. If go-torture-execute took a list of sources as

Re: Allow passing arrays in registers on AArch64

2014-02-06 Thread Ramana Radhakrishnan
On Tue, Feb 4, 2014 at 2:12 AM, Michael Hudson-Doyle wrote: > Ping? I'm attaching a marginally cleaner version of the test. I've had > a look at integrating this into aapcs64.exp but got defeated in the > end. If go-torture-execute took a list of sources as c-torture-execute > does, then I thin

Re: Allow passing arrays in registers on AArch64

2014-02-03 Thread Michael Hudson-Doyle
Ping? I'm attaching a marginally cleaner version of the test. I've had a look at integrating this into aapcs64.exp but got defeated in the end. If go-torture-execute took a list of sources as c-torture-execute does, then I think adding something like this to aapcs64.exp would work: # Test passi

Re: Allow passing arrays in registers on AArch64

2014-01-24 Thread Matthias Klose
Am 17.01.2014 19:50, schrieb Yufeng Zhang: > Hi Michael, > > Thanks for the fix. The patch looks OK to me in general, although I have some > minor comments below. > > On 01/17/14 08:22, Michael Hudson-Doyle wrote: >> Hi, as discussed inhttp://gcc.gnu.org/bugzilla/show_bug.cgi?id=59799 >> GCC cur

Re: Allow passing arrays in registers on AArch64

2014-01-20 Thread Tom Tromey
> "Michael" == Michael Hudson-Doyle writes: >> My preferred languages for these tests would be (in approximate order) >> c, c++, fortran, java, ada, go. That order is based on which languages >> are tested most by users. Michael> Well of course it cannot be done in C or C++. A commenter on

Re: Allow passing arrays in registers on AArch64

2014-01-20 Thread Michael Hudson-Doyle
Richard Earnshaw writes: > On 17/01/14 23:56, Michael Hudson-Doyle wrote: >> Ian Lance Taylor writes: >> >>> On Fri, Jan 17, 2014 at 11:32 AM, Michael Hudson-Doyle >>> wrote: On 18 Jan 2014 07:50, "Yufeng Zhang" wrote: > > Also can you please try to add some new test(s)? It

Re: Allow passing arrays in registers on AArch64

2014-01-20 Thread Richard Earnshaw
On 17/01/14 23:56, Michael Hudson-Doyle wrote: > Ian Lance Taylor writes: > >> On Fri, Jan 17, 2014 at 11:32 AM, Michael Hudson-Doyle >> wrote: >>> >>> On 18 Jan 2014 07:50, "Yufeng Zhang" wrote: Also can you please try to add some new test(s)? It may not be that straightforward

Re: Allow passing arrays in registers on AArch64

2014-01-17 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > On Fri, Jan 17, 2014 at 11:32 AM, Michael Hudson-Doyle > wrote: >> >> On 18 Jan 2014 07:50, "Yufeng Zhang" wrote: >>> >>> Also can you please try to add some new test(s)? It may not be that >>> straightforward to add non-C/C++ tests, but give it a try. >> >> Can you

Re: Allow passing arrays in registers on AArch64

2014-01-17 Thread Ian Lance Taylor
On Fri, Jan 17, 2014 at 11:32 AM, Michael Hudson-Doyle wrote: > > On 18 Jan 2014 07:50, "Yufeng Zhang" wrote: >> >> Also can you please try to add some new test(s)? It may not be that >> straightforward to add non-C/C++ tests, but give it a try. > > Can you give some hints? Like at least where i

Re: Allow passing arrays in registers on AArch64

2014-01-17 Thread Yufeng Zhang
Hi Michael, Thanks for the fix. The patch looks OK to me in general, although I have some minor comments below. On 01/17/14 08:22, Michael Hudson-Doyle wrote: Hi, as discussed inhttp://gcc.gnu.org/bugzilla/show_bug.cgi?id=59799 GCC currently gets a detail of the AArch64 ABI wrong: arrays are

Allow passing arrays in registers on AArch64

2014-01-17 Thread Michael Hudson-Doyle
Hi, as discussed in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59799 GCC currently gets a detail of the AArch64 ABI wrong: arrays are not always passed by reference. Fortunately the fix is rather easy... I guess this is an ABI break but my understand there has been no release of GCC which suppor