Re: inline-analysis improvement

2011-09-22 Thread Eric Botcazou
> The only failure I had was pr50433, now fixed by revision 179046. With it, > all the ADA tests pass (including gnat.dg/opt19.adb) pass without failure > on x86_64-apple-darwin10 (thanks Jan for the quick fix). That's what I meant. Note that it's Ada, not ADA, because it's a first name: http:/

Re: inline-analysis improvement

2011-09-21 Thread Iain Sandoe
On 21 Sep 2011, at 15:58, Dominique Dhumieres wrote: I am not sure to understand the sentence: There is apparently an ACATS failure on x86-64/Darwin, but I've installed the testcase as gnat.dg/opt19.adb in the tree. The only failure I had was pr50433, now fixed by revision 179046. With

Re: inline-analysis improvement

2011-09-21 Thread Dominique Dhumieres
Eric, I am not sure to understand the sentence: > There is apparently an ACATS failure on x86-64/Darwin, but I've installed the > testcase as gnat.dg/opt19.adb in the tree. The only failure I had was pr50433, now fixed by revision 179046. With it, all the ADA tests pass (including gnat.dg/opt1

Re: inline-analysis improvement

2011-09-21 Thread Eric Botcazou
> The tests tonight shows quite good results - there are quite consistent > code size reductions on C++ code w/o slowdowns so I've comitted the patch. > Sadly tramp3d does not build and the heuristics was implemented with > tramp3d in mind. Important behaviour change is that the heuristic now > mat

Re: inline-analysis improvement

2011-09-21 Thread Jan Hubicka
> > the problem here is that we consider ¶m.foo to be a memory reference, > > while it is not. The following patch should fix it, but because it changes > > the behaviour of inline heuristics, I will run bechmarks tonight before > > committing it. > > Thanks in advance. Can you add PR tree-optimi

Re: inline-analysis improvement

2011-09-20 Thread Eric Botcazou
> the problem here is that we consider ¶m.foo to be a memory reference, > while it is not. The following patch should fix it, but because it changes > the behaviour of inline heuristics, I will run bechmarks tonight before > committing it. Thanks in advance. Can you add PR tree-optimization/50433

Re: inline-analysis improvement

2011-09-20 Thread Iain Sandoe
Hi Honza, On 15 Sep 2011, at 11:27, Jan Hubicka wrote: Bootstrapped/regtested x86_64-linux, will commit it later today. Honza * ipa-inline-analysis.c (add_condition): Add conditions parameter; simplify obviously true clauses. (and_predicates, or_predicates): Add conditi

Re: inline-analysis improvement

2011-09-20 Thread Jan Hubicka
> > * ipa-inline-analysis.c (add_condition): Add conditions parameter; > > simplify obviously true clauses. > > (and_predicates, or_predicates): Add conditions parameter. > > (inline_duplication_hoook): Update. > > (mark_modified): New function. > > (unmodified_parm): New fu

Re: inline-analysis improvement

2011-09-16 Thread Eric Botcazou
> * ipa-inline-analysis.c (add_condition): Add conditions parameter; > simplify obviously true clauses. > (and_predicates, or_predicates): Add conditions parameter. > (inline_duplication_hoook): Update. > (mark_modified): New function. > (unmodified_parm): New fu

inline-analysis improvement

2011-09-15 Thread Jan Hubicka
Hi, this patch updates inline heuristics so we could analyse also non-SSA vars. I.e. in: int aaa(int a) { if (a>4) bbb(&a); } We are still able to work out that bbb is called only when a>4 despite the fact that A has address taken. The patch also makes dataflow to simplify a bit the solution,