[pushed] testsuite, Darwin: Skip g++.dg/debug/dwarf2/pr85550.C

2023-10-02 Thread Iain Sandoe
ise DW_FORM_ref_sig8. Disable ths test until we get DWARF-5 support in the external Darwin toolchain components. gcc/testsuite/ChangeLog: * g++.dg/debug/dwarf2/pr85550.C: Skip for Darwin. Signed-off-by: Iain Sandoe --- gcc/testsuite/g++.dg/debug/dwarf2/pr85550.C | 1 + 1 file changed, 1 insert

[pushed] contrib: Update Darwin entries in config-list.mk

2023-10-02 Thread Iain Sandoe
ilers. Signed-off-by: Iain Sandoe --- contrib/config-list.mk | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/contrib/config-list.mk b/contrib/config-list.mk index e570b13c71b..c090be13147 100644 --- a/contrib/config-list.mk +++ b/contrib/config-list

Re: [PATCH] Support g++ 4.8 as a host compiler.

2023-10-08 Thread Iain Sandoe
> On 8 Oct 2023, at 05:40, Jeff Law wrote: > On 10/7/23 15:30, Sam James wrote: >> Jeff Law writes: >>> On 10/4/23 16:19, Roger Sayle wrote: The recent patch to remove poly_int_pod triggers a bug in g++ 4.8.5's C++ 11 support which mistakenly believes poly_uint16 has a non-trivi

Re: [PATCH] Fix coroutine tests for libstdc++ gnu-version-namespace mode

2023-10-08 Thread Iain Sandoe
Hi François, > On 23 Sep 2023, at 21:10, François Dumont wrote: > > I'm eventually fixing those tests the same way we manage this problem in > libstdc++ testsuite. > >testsuite: Add optional libstdc++ version namespace in expected diagnostic > > When libstdc++ is build with --enable-s

Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix

2023-10-08 Thread Iain Sandoe
Hi François, > On 21 Sep 2023, at 05:41, François Dumont wrote: > > Tests were successful, ok to commit ? > > On 20/09/2023 19:51, François Dumont wrote: >> libstdc++: [_GLIBCXX_INLINE_VERSION] Add handle_contract_violation symbol >> alias >> >> libstdc++-v3/ChangeLog: >> >> * src/experi

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-08 Thread Iain Sandoe
+ Jeff > On 8 Oct 2023, at 14:07, Nathanael Nerode wrote: > > I hope a global maintainer can step up. I've been on hiatus from GCC work > for some years, and this was never my part of the build system anyway -- and > I don't use Darwin -- so I'm not qualified to review it. It looks fine but

Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix

2023-10-09 Thread Iain Sandoe
e. Thanks; works for me, (g++ tests with your patches + a local one to enable versioned-namespace on Darwin). Iain > > François > > > On 08/10/2023 16:06, Iain Sandoe wrote: >> Hi François, >> >>> On 21 Sep 2023, at 05:41, François Dumont wrote: >>>

Re: [PATCH] sso-string@gnu-versioned-namespace [PR83077]

2023-10-09 Thread Iain Sandoe
Hi François, > On 7 Oct 2023, at 20:32, François Dumont wrote: > > I've been told that previous patch generated with 'git diff -b' was not > applying properly so here is the same patch again with a simple 'git diff'. Thanks, that did fix it - There are some training whitespaces in the config

Re: [PATCH] sso-string@gnu-versioned-namespace [PR83077]

2023-10-09 Thread Iain Sandoe
> On 9 Oct 2023, at 15:42, Iain Sandoe wrote: >> On 7 Oct 2023, at 20:32, François Dumont wrote: >> >> I've been told that previous patch generated with 'git diff -b' was not >> applying properly so here is the same patch again with a simple '

Re: [PATCH] Fix coroutine tests for libstdc++ gnu-version-namespace mode

2023-10-11 Thread Iain Sandoe
Hi François, > On 11 Oct 2023, at 05:49, François Dumont wrote: > On 08/10/2023 15:59, Iain Sandoe wrote: >>> On 23 Sep 2023, at 21:10, François Dumont wrote: >>> >>> I'm eventually fixing those tests the same way we manage this problem in >>>

[pushed] Darwin: Check as for .build_version support and use it if available.

2023-10-18 Thread Iain Sandoe
* configure: Regenerate. * configure.ac: Check for assembler support of .build_version directives. Signed-off-by: Iain Sandoe --- gcc/config.in| 6 ++ gcc/config/darwin.cc | 34 -- gcc/configure| 33 ++

Re: [PATCH 2/2] btf: improve -dA comments for testsuite

2023-06-02 Thread Iain Sandoe
Hi David, > On 31 May 2023, at 07:13, Indu Bhagat via Gcc-patches > wrote: > > On 5/30/23 11:27, David Faust wrote: >> [Changes from v1: >> - Fix typos. >> - Split unrelated change into separate commit. >> - Improve asm comment for enum constants, update btf-enum-1 test. >> - Improve asm co

Re: [PATCH][committed] btf: Fix -Wformat errors

2023-06-02 Thread Iain Sandoe
> On 2 Jun 2023, at 17:18, Rainer Orth wrote: > > Hi Alex, > >> g:7aae58b04b92303ccda3ead600be98f0d4b7f462 introduced -Wformat errors >> breaking bootstrap on some targets. This patch fixes that. >> >> Committed as obvious. >> >> Thanks, >> Alex >> >> gcc/ChangeLog: >> >> * btfout.cc

Re: [pushed] Darwin, PPC: Fix struct layout with pragma pack [PR110044].

2023-06-03 Thread Iain Sandoe
Hi Richard, > On 3 Jun 2023, at 12:20, Richard Biener wrote: > >> Am 02.06.2023 um 21:12 schrieb Iain Sandoe via Gcc-patches >> : >> >> --- 8< --- >> >> This bug was essentially that darwin_rs6000_special_round_type_align() >> was ign

Fwd: [PATCH][RFC] c++: Accept elaborated-enum-base in system headers

2023-06-08 Thread Iain Sandoe
> Begin forwarded message: > > From: Jason Merrill > Subject: Re: [PATCH][RFC] c++: Accept elaborated-enum-base in system headers > Date: 8 June 2023 at 19:06:36 BST > To: Alex Coplan , gcc-patches@gcc.gnu.org > Cc: Nathan Sidwell , Iain Sandoe > > On 6/8/23 07:0

Re: [PATCH v2] c++: Accept elaborated-enum-base in system headers

2023-06-15 Thread Iain Sandoe
Hi Alex > On 14 Jun 2023, at 14:31, Alex Coplan wrote: > > Hi, > > This is a v2 patch addressing feedback for: > https://gcc.gnu.org/pipermail/gcc-patches/2023-June/621050.html > > macOS SDK headers using the CF_ENUM macro can expand to invalid C++ code > of the form: > > typedef enum T : Bas

Re: [PATCH] core: Support heap-based trampolines

2023-07-16 Thread Iain Sandoe
> On 17 Jul 2023, at 07:43, FX Coudert wrote: > > Hi, > >> Since this affects the ABI of libgcc I think we don't want that part >> to be user configurable but rather determined by >> some static list of targets that opt-in to this config. > > If I do that, do the Linux maintainers want Linux

Re: [PATCH] core: Support heap-based trampolines

2023-07-17 Thread Iain Sandoe
> On 17 Jul 2023, at 07:58, Iain Sandoe wrote > >> On 17 Jul 2023, at 07:43, FX Coudert wrote: >> >> >> There is an alternate mechanism relying on system libraries that is possible >> on darwin specifically (I don’t know for other targets) but it wi

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Iain Sandoe
Hi Martin, > On 19 Jul 2023, at 10:04, Martin Uecker wrote: >>> On 17 Jul 2023, >> > You mention setjmp/longjmp - on darwin and other platforms >> requiring non-stack based trampolines does the system runtime provide means to deal with this issue like >> an alternate alloc

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Iain Sandoe
Hi Martin, > On 19 Jul 2023, at 11:43, Martin Uecker via Gcc-patches > wrote: > > Am Mittwoch, dem 19.07.2023 um 10:29 +0100 schrieb Iain Sandoe: >>> On 19 Jul 2023, at 10:04, Martin Uecker >>> wrote: >> >>>>> On 17 Jul 2023, >>&

Re: [PATCH 4/9] vect: Adjust vectorizable_load costing on VMAT_ELEMENTWISE and VMAT_STRIDED_SLP

2023-07-22 Thread Iain Sandoe
Hi Kewen, This patch breaks bootstrap on powerpc-darwin (which has Altivec, but not VSX) while building libgfortran. > On 3 Jul 2023, at 04:19, Kewen.Lin via Gcc-patches > wrote: Please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110776 thanks Iain

Re: [PATCH] c++: coroutines - Overlap variables in frame [PR105989]

2022-07-12 Thread Iain Sandoe
Hi Michal, > On 12 Jul 2022, at 14:35, Michal Jankovič via Gcc-patches > wrote: > > Currently, coroutine frames store all variables of a coroutine separately, > even if their lifetime does not overlap (they are in distinct scopes). This > patch implements overlapping distinct variable scopes in

Re: [PATCH] c++: coroutines - Overlap variables in frame [PR105989]

2022-07-12 Thread Iain Sandoe
basically, these are to try and address the correctness issues we face, Iain > > Michal > > On Jul 12 2022, at 4:08 pm, Iain Sandoe wrote: > >> Hi Michal, >> >>> On 12 Jul 2022, at 14:35, Michal Jankovič via Gcc-patches >>> wrote: >>> &

Re: [PATCH 00/24] Sync shared build infrastructure with binutils-gdb

2023-08-08 Thread Iain Sandoe
Hi Joseph > On 8 Aug 2023, at 20:41, Joseph Myers wrote: > > On Tue, 8 Aug 2023, Arsen Arsenović via Gcc-patches wrote: > >> Yes. Libtool was forked over a decade ago. My next project is syncing >> upstream and us back up. Unsure about pkg.m4. > > Note as per previous discussions that libto

Re: [PATCH] config-list.mk Darwin: Use --with-gnu-as

2023-08-15 Thread Iain Sandoe
Hi Jan-Benedict, > On 15 Aug 2023, at 20:36, Jan-Benedict Glaw wrote: > config-list.mk Darwin: Use --with-gnu-as for mass-building tests > > As `config-list.mk` is probably mostly used on Linux system, where > Apple's tools aren't around. Let's use --with-gnu-as instead to have > an useable as

Re: [PATCH] build: Allow for Xcode 15 ld -v output

2023-08-16 Thread Iain Sandoe
Hi Rainer, > On 16 Aug 2023, at 20:13, Rainer Orth wrote: > > Since Xcode 15 beta 6, ld -v output differs from previous versions: > > * macOS 13/Xcode 14: > > @(#)PROGRAM:ld PROJECT:ld64-857.1 > > * macOS 14/Xcode 15: > > @(#)PROGRAM:ld PROJECT:dyld-1015.1 > > configure cannot handle th

Re: [PATCH] fixincludes: Update darwin_flt_eval_method for macOS 14

2023-08-16 Thread Iain Sandoe
Hi Rainer, > On 16 Aug 2023, at 20:20, Rainer Orth wrote: > > On macOS 14, a guard in changed: > > -- MacOSX13.3.sdk/usr/include/math.h 2023-04-19 01:54:44 > +++ MacOSX14.0.sdk/usr/include/math.h 2023-08-01 08:42:43 > @@ -22,0 +23 @@ > + > @@ -43 +44 @@ > -#if __FLT_EVAL_METHOD__ == 0 > +#if

Re: [PATCH v3][RFC] c-family: Implement __has_feature and __has_extension [PR60512]

2023-08-16 Thread Iain Sandoe
Hi Alex, > On 3 Aug 2023, at 10:21, Alex Coplan wrote: > > This patch implements clang's __has_feature and __has_extension in GCC. > This is a v3 which addresses feedback for the v2 patch posted here: > > https://gcc.gnu.org/pipermail/gcc-patches/2023-August/626058.html > > Main changes sinc

Re: [PATCH] improve error for when /usr/include isn't found [PR90835]

2023-08-17 Thread Iain Sandoe
Hi Eric, thanks for working on this. > On 17 Aug 2023, at 20:35, Eric Gallager wrote: > > This is a pretty simple patch that ought to help Darwin users understand > better why their build is failing when they forget to pass the > --with-sysroot= flag to configure. > > gcc/ChangeLog: > >PR

Re: [PATCH] Testsuite: mark IPA test as requiring alias support

2023-08-20 Thread Iain Sandoe
Hi FX, > On 20 Aug 2023, at 13:15, FX Coudert via Gcc-patches > wrote: > The fact that this test needs alias support was indicated in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85656 but never committed. > Without it, the test fails on darwin. > > OK to commit? IMO, changes like this qu

Re: [PATCH][RFC] c-family: Implement __has_feature and __has_extension [PR60512]

2023-06-20 Thread Iain Sandoe
Hi Alex again, thanks for working on this and for fixing the SDK blocker. > On 20 Jun 2023, at 13:30, Alex Coplan wrote: > > The patch can now survive bootstrap on Darwin (it looks like we'll need > to adjust some Objective-C++ tests in light of the new pedwarn, but that > looks to be straight

Re: [PATCH][RFC] c-family: Implement __has_feature and __has_extension [PR60512]

2023-07-06 Thread Iain Sandoe
Hi Alex, > On 6 Jul 2023, at 15:01, Alex Coplan wrote: > > On 20/06/2023 15:08, Iain Sandoe wrote: >> again, thanks for working on this and for fixing the SDK blocker. >> >>> On 20 Jun 2023, at 13:30, Alex Coplan wrote: >>> >> >>> T

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-21 Thread Iain Sandoe
Hi Jeff, > On 21 Oct 2023, at 19:05, Jeff Law wrote: > On 10/8/23 16:14, Iain Sandoe wrote: >> + Jeff >>> On 8 Oct 2023, at 14:07, Nathanael Nerode wrote: >>> >>> I hope a global maintainer can step up. I've been on hiatus from GCC work >>&

Re: [PATCH] libgcc: make heap-based trampolines conditional on libc presence

2023-10-23 Thread Iain Sandoe
hi Sergei, > On 23 Oct 2023, at 13:43, Sergei Trofimovich wrote: > > From: Sergei Trofimovich > > To build `libc` for a target one needs to build `gcc` without `libc` > support first. Commit r14-4823-g8abddb187b3348 "libgcc: support > heap-based trampolines" added unconditional `libc` dependen

[pushed] configure, libquadmath: Remove unintended AC_CHECK_LIBM [PR111928]

2023-10-23 Thread Iain Sandoe
--- 8< --- This was a rebase error, that managed to pass testing on Darwin and Linux (but fails on bare metal). PR libquadmath/111928 libquadmath/ChangeLog: * Makefile.in: Regenerate. * configure: Regenerate. * configure.ac: Remove AC_CHECK_LIBM. Signed-off-by: I

Re: [PATCH v3] gcc: Introduce -fhardened

2023-10-24 Thread Iain Sandoe
Hi Marek, > On 23 Oct 2023, at 20:25, Marek Polacek wrote: > > On Thu, Oct 19, 2023 at 02:24:11PM +0200, Richard Biener wrote: >> On Wed, Oct 11, 2023 at 10:48 PM Marek Polacek wrote: >>> >>> On Tue, Sep 19, 2023 at 10:58:19AM -0400, Marek Polacek wrote: On Mon, Sep 18, 2023 at 08:57:39AM

Re: [PATCH v3] gcc: Introduce -fhardened

2023-10-24 Thread Iain Sandoe
hi Marek, > On 24 Oct 2023, at 08:44, Iain Sandoe wrote: > On 23 Oct 2023, at 20:25, Marek Polacek wrote: >> >> On Thu, Oct 19, 2023 at 02:24:11PM +0200, Richard Biener wrote: >>> On Wed, Oct 11, 2023 at 10:48 PM Marek Polacek wrote: >>>> >>>&

[PATCH] config, aarch64: Use a more compatible sed invocation.

2023-10-24 Thread Iain Sandoe
ent, since we should only require a Posix sed (but it seems supported for BSD-derivatives). gcc/ChangeLog: * config.gcc: Use -E to to sed to indicate that we are using extended REs. Signed-off-by: Iain Sandoe --- gcc/config.gcc | 12 ++-- 1 file changed, 6 insertions(+)

Re: [PATCH v3] gcc: Introduce -fhardened

2023-10-24 Thread Iain Sandoe
> On 24 Oct 2023, at 20:03, Marek Polacek wrote: > > On Tue, Oct 24, 2023 at 10:34:22AM +0100, Iain Sandoe wrote: >> hi Marek, >> >>> On 24 Oct 2023, at 08:44, Iain Sandoe wrote: >>> On 23 Oct 2023, at 20:25, Marek Polacek wrote: >>>> >

[PATCH] Darwin: Handle the fPIE option specially.

2023-10-26 Thread Iain Sandoe
ime change. For almost all Darwin, we do not report __PIE__; the exception is 32bit X86 and from Darwin12 to 17 only (32 bit is no longer supported after Darwin17). gcc/ChangeLog: * config/darwin.cc (darwin_override_options): Handle fPIE. Signed-off-by: Iain Sandoe --- gcc/config/darwin

[pushed] Darwin: Make metadata symbol lables linker-visible for GNU objc.

2023-10-26 Thread Iain Sandoe
for NeXT the names are in separate sections). gcc/ChangeLog: * config/darwin.h (darwin_label_is_anonymous_local_objc_name): Make metadata names linker-visibile for GNU objective C. Signed-off-by: Iain Sandoe --- gcc/config/darwin.h | 2 +- 1 file changed, 1 insertion(+)

[PATCH] testsuite, aarch64: Normalise options to aarch64.exp.

2023-10-26 Thread Iain Sandoe
lts. e.g. for --with-cpu=xgene1 we see over 100 excess fails which are removed by this change. gcc/testsuite/ChangeLog: * gcc.target/aarch64/aarch64.exp: Use aarch64-with-arch-dg-options to normaize the options to the tests in aarch64.exp. Signed-off-by: Iain Sandoe ---

[PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-10-26 Thread Iain Sandoe
not delineate functions when frame output is switched off. TODO: consider adding -mtest-markers or something similar to inject assembler comments that can be scanned for. gcc/testsuite/ChangeLog: * lib/scanasm.exp: Initial handling for Mach-O function body scans. Signed-off-by: Iain San

[PATCH] aarch64: Make assembler bug workaround configurable.

2023-10-26 Thread Iain Sandoe
ase architecture supports it. However, that also triggers a different bug in another assembler. So make the fix configurable. gcc/ChangeLog: * common/config/aarch64/aarch64-common.cc: Make the asm crc bug workaround configurable. Signed-off-by: Iain Sandoe --- gcc/common/con

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-10-26 Thread Iain Sandoe
Hi Richard, > On 26 Oct 2023, at 20:49, Richard Sandiford wrote: > > Iain Sandoe writes: >> This was written before Thomas' modification to the ELF-handling to allow >> a config-based change for target details. I did consider updating this >> to try and use

Re: [PATCH v2 2/4] libgrust: Add libproc_macro and build system

2023-10-27 Thread Iain Sandoe
> On 26 Oct 2023, at 09:21, Thomas Schwinge wrote: > > Hi! > > First, I've pushed into GCC upstream Git branch devel/rust/libgrust-v2 > the "v2" libgrust changes as posted by Arthur, so that people can easily > test this before it getting into Git master branch. > > I'll myself later try this

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-10-27 Thread Iain Sandoe
Hi Richard, > On 26 Oct 2023, at 21:00, Iain Sandoe wrote: >> On 26 Oct 2023, at 20:49, Richard Sandiford >> wrote: >> >> Iain Sandoe writes: >>> This was written before Thomas' modification to the ELF-handling to allow >>> a config-based c

Re: [PATCH] testsuite, aarch64: Normalise options to aarch64.exp.

2023-10-27 Thread Iain Sandoe
Hi Andrew, > On 26 Oct 2023, at 20:00, Andrew Pinski wrote: > > On Thu, Oct 26, 2023 at 11:58 AM Iain Sandoe wrote: >> >> tested on cfarm185 (aarch64-linux-gnu, xgene1) and with the aarch64 >> Darwin prototype. It is possible that some initial fallout could o

Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext

2023-10-28 Thread Iain Sandoe
Hi Arsen, > On 28 Oct 2023, at 10:22, Arsen Arsenović wrote: > Andrew Pinski writes: > >> One comment from me. It would be nice to update install.texi in >> gcc/doc/ to make a mention of this requirement for non-glibc hosts. > > What do you think of the following: The hiccup for me is that w

[pushed] testsuite, X86, Darwin: Skip tests with incompatible output.

2023-10-29 Thread Iain Sandoe
2-1.c: Likewise. * gcc.target/i386/apx-push2pop2_force_drap-1.c: Likewise. Signed-off-by: Iain Sandoe --- gcc/testsuite/gcc.target/i386/apx-interrupt-1.c| 1 + gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c| 1 + gcc/testsuite/gcc.target/i386/apx-push2pop2_force_d

[pushed] testsuite, X86, Darwin: Skip a test for mcmodel=large.

2023-10-29 Thread Iain Sandoe
Tested on x86_64-darwin, pushed to trunk, thanks Iain --- 8< --- The large model is not implemented so far for Darwin (and the codegen will be different when it is). gcc/testsuite/ChangeLog: * gcc.target/i386/large-data.c: Skip for Darwin. Signed-off-by: Iain Sandoe ---

[PATCH] testsuite, x86: Handle a broken assembler.

2023-10-29 Thread Iain Sandoe
gcc/testsuite/ChangeLog: * lib/target-supports.exp: Test an asm line that fails on broken Darwin assembler versions. Signed-off-by: Iain Sandoe --- gcc/testsuite/lib/target-supports.exp | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/lib/target-supports.exp b/

Re: [PATCH] Testsuite, Darwin: skip PIE test

2023-10-30 Thread Iain Sandoe
HI FX, > On 30 Oct 2023, at 11:43, FX Coudert wrote: > The recent commit of > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634347.html has made > this test invalid. We now don’t emit __PIE__, and the test should be skipped > on darwin. > > Fixes the new failure on x86_64-apple-darw

Re: [PATCH] Testsuite, i386: Fix test by passing -march

2023-10-30 Thread Iain Sandoe
> On 30 Oct 2023, at 11:53, FX Coudert wrote: > The newly introduced test gcc.target/i386/pr111698.c currently fails on > Darwin, where the default arch is core2. > Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to > pass a recent value to -march, and I can confirm t

Re: [PATCH] Testsuite, Darwin: Fix trampoline warning

2023-10-30 Thread Iain Sandoe
Hi FX, > On 30 Oct 2023, at 13:50, FX Coudert wrote: > > Heap-based trampolines are enabled on darwin20 and later, meaning that no > warning is emitted. > Fixes the test failure on x86_64-apple-darwin21 > > OK to push? OK, thanks Iain

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-30 Thread Iain Sandoe
Hi Martin, > On 30 Oct 2023, at 16:17, Martin Jambor wrote: > On Tue, Aug 15 2023, FX Coudert via Gcc-patches wrote: >> > > [...] > >> From e1cf04cadb9fa065fb3f7d6bccf9ed6f1e9e3fc1 Mon Sep 17 00:00:00 2001 >> From: Iain Sandoe >> Date: Sun, 28 Mar 202

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-30 Thread Iain Sandoe
Hi Folks > On 30 Oct 2023, at 16:31, FX Coudert wrote: > >> +enable_darwin_at_rpath_$1=no > > I actually don’t understand why this one would have $1 in the name, unlike > all other regenerated configure files. What value do we expect for $1 at this > point in the file? That’s just plain weird

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-10-31 Thread Iain Sandoe
Hi Simon, (please cc me on Darwin-related patches) > On 29 Oct 2023, at 11:51, Simon Wright wrote: > > This change affects only Ada. > > In gcc/ada/adaint.c(__gnat_get_file_names_case_sensitive), the > assumption for __APPLE__ is that file names are case-insensitive > unless __arm__ or __arm64

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-04 Thread Iain Sandoe
Hi Folks > On 4 Nov 2023, at 17:02, Simon Wright wrote: > > On 3 Nov 2023, at 08:39, Arnaud Charlet wrote: >> So without changing fundamentally the model, you can't decide dynamically >> for the whole >> system. Making the choice based on the current directory is pretty random, >> since the

Re: [PATCH] Testsuite, i386: Mark test as requiring dfp

2023-11-05 Thread Iain Sandoe
Hi FX > On 5 Nov 2023, at 10:33, FX Coudert wrote: > > kind ping for this easy patch IMO adding feature tests for features required by a test falls into the “obvious” category, Iain > > >> Le 30 oct. 2023 à 15:19, FX Coudert a écrit : >> >> Hi, >> >> The test is currently failing on x86

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-11-05 Thread Iain Sandoe
Hi Richard, > On 5 Nov 2023, at 12:11, Richard Sandiford wrote: > > Iain Sandoe writes: >>> On 26 Oct 2023, at 21:00, Iain Sandoe wrote: >> >>>> On 26 Oct 2023, at 20:49, Richard Sandiford >> wrote: >>>> >>>> Iain Sandoe

Re: [PR100127] Test for coroutine header in clang-compatible tests

2023-02-17 Thread Iain Sandoe
Hi, > On 17 Feb 2023, at 06:42, Alexandre Oliva via Gcc-patches > wrote: > > > The test is compatible with clang as well as gcc, but ISTM that > testing for the __clang__ macro is just as potentially error-prone as > macros that used to be GCC-specific are now defined in compilers that > aim f

Re: C++ modules and AAPCS/ARM EABI clash on inline key methods

2023-02-24 Thread Iain Sandoe
> On 24 Feb 2023, at 10:23, Richard Earnshaw via Gcc-patches > wrote: > > > > On 23/02/2023 21:20, Alexandre Oliva wrote: >> On Feb 23, 2023, Alexandre Oliva wrote: >>> On Feb 23, 2023, Richard Earnshaw wrote: On 22/02/2023 19:57, Alexandre Oliva wrote: > On Feb 21, 2023, Richard

Re: [PATCH][stage1] Remove conditionals around free()

2023-03-03 Thread Iain Sandoe
> On 3 Mar 2023, at 23:11, Bernhard Reutner-Fischer via Fortran > wrote: > > On 2 March 2023 02:23:10 CET, Jerry D wrote: >> On 3/1/23 4:07 PM, Steve Kargl via Fortran wrote: >>> On Wed, Mar 01, 2023 at 10:28:56PM +0100, Bernhard Reutner-Fischer via >>> Fortran wrote: libgfortran/caf/

Re: [PATCH 11/14] objc: use _P() defines from tree.h

2023-05-14 Thread Iain Sandoe
H Bernhard, > On 14 May 2023, at 00:23, Bernhard Reutner-Fischer via Gcc-patches > wrote: > > From: Bernhard Reutner-Fischer > > gcc/objc/ChangeLog: > > * objc-act.cc (objc_volatilize_decl): Use _P() defines from tree.h. > (objc_is_global_reference_p): Ditto. > (objc_genera

Re: [PATCH 03/14] gcc/config/*: use _P() defines from tree.h

2023-05-14 Thread Iain Sandoe
Hi Bernhard > On 14 May 2023, at 00:23, Bernhard Reutner-Fischer via Gcc-patches > wrote: > > From: Bernhard Reutner-Fischer > > gcc/ChangeLog: > > * config/darwin-c.cc (darwin_pragma_unused): Ditto. > * config/darwin.cc (is_objc_metadata): Ditto. > * config/rs6000/darwin

Re: [PATCH][RFC] c-family: Implement __has_feature and __has_extension [PR60512]

2023-05-14 Thread Iain Sandoe
Hi Alex, thanks for working on this. I’ve applied this patch and evaluated on a few Darwin versions (which is the target currently most affected, I believe): > On 9 May 2023, at 13:07, Alex Coplan wrote: > This patch implements clang's __has_feature and __has_extension in GCC. Thanks, this bl

Re: [PATCH] c++: coroutines - Overlap variables in frame [PR105989]

2023-05-14 Thread Iain Sandoe
is optimisation) Do you have any metrics on the reductions in frame size for realistic coroutines? thanks Iain > > On Jul 13 2022, at 2:54 pm, Michal Jankovic > wrote: > >> Hi Iain, >> >> thanks for the info. I have some follow-up questions. >> >> O

Re: [PATCH] c++: coroutines - Overlap variables in frame [PR105989]

2023-05-14 Thread Iain Sandoe
not obviously repeat them. thanks Iain > > thanks, > Michal > > On May 14 2023, at 6:07 pm, Iain Sandoe wrote: > >> Hi Michal, >> >>> On 14 May 2023, at 16:36, Michal Jankovič >>> wrote: >>> >>> Rebased the patch to GCC 14 trunk. Boo

Re: [PATCH] configure: Implement --enable-host-pie

2023-05-16 Thread Iain Sandoe
Hi Marek, > On 16 May 2023, at 16:29, Marek Polacek via Gcc-patches > wrote: > > Ping. I’m trying this on Darwin (since I have a local patch to do this for modern [darwin20+] versions, which do not allow non-PIE) I think you are missing a hunk to deal with Ada. thanks for the patch Iain >

[pushed] testsuite, Darwin : Skip ELF-specific tests.

2021-01-31 Thread Iain Sandoe
Hi, A number of ELF-specific tests were introduced in r11-6140, one of which fails on all Mach-O/Darwin platforms. On examination, the tests have no meaningful parallel for Mach-O which dead strips at the symbol level, and does not make use of function sections (the fact that a used and an unused

[PATCH, constexpr, coroutines ] Generic lambda coroutines cannot be constexpr [PR96251].

2021-02-22 Thread Iain Sandoe
Hi, PR96251 (and dups) is a rejects-valid bug against coroutines (but I’m not sure that the problem is really there). * coroutines cannot be constexpr. * Part of the way that the coroutine implementation works is a consequence of the "lazy discovery of coroutine-ness”; whenever we first encou

Re: [PATCH, constexpr, coroutines ] Generic lambda coroutines cannot be constexpr [PR96251].

2021-02-23 Thread Iain Sandoe
Hi Jason, Jason Merrill wrote: > On 2/22/21 3:59 PM, Iain Sandoe wrote: >> * I was not able to see any way in which the instantiation process >> could be made to bail in this case and re-try for non-constexpr. > > Many of the other places that set cp_function_cha

[pushed] testsuite, coroutines : Make final_suspend calls noexcept.

2021-02-24 Thread Iain Sandoe
Hi, The wording of [dcl.fct.def.coroutine]/15 states: The expression co_await promise.final_suspend() shall not be potentially-throwing. A fair number of testcases are not correctly marked. Fixed here. mechanical patch, tested on x86_64-darwin, x86-64-linux-gnu, pushed as obvious thanks Iain g

[PATCH] coroutines : Remove throwing_cleanup marks from the ramp [PR95822].

2021-02-24 Thread Iain Sandoe
Hi, The FE contains a mechanism for cleaning up return expressions if a function throws during the execution of cleanups prior to the return. If the original function has a return value with a non-trivial DTOR and the body contains a var with a DTOR that might throw, the function decl is marked "

[PATCH] coroutines : Call promise CTOR with parm copies [PR97587].

2021-02-24 Thread Iain Sandoe
Hi, As the PR notes, we were calling the promise CTOR with the original function parameters, not the copy (as pointed, a previous wording of the section on this was unambiguous). Fixed thus. tested on x86_64-darwin, x86_64-linux-gnu, this is a wrong-code bug, OK for master / 10.x? thanks Iain

[PATCH] Darwin, testsuite : Prune 'object file not found for object'.

2021-02-24 Thread Iain Sandoe
Hi, This is not a GCC problem, but a fault in the static linker where, when a source file is used multiple times, with conditional compilation the source file is only referenced by the linker for the first object. Then, when dsymutil tries to find the source file for next object based off that sou

[PATCH] dwarf2unwind : Force the CFA after remember/restore pairs [44107/48097].

2021-02-26 Thread Iain Sandoe
Hi This address one of the more long-standing and serious regressions for Darwin. GCC emits unwind code by default on the assumption that the unwinder will be (or have the same capability) as the one in the current libgcc_s. For Darwin platforms, this is not the case - some of them are based on

[PATCH] coroutines : Handle exceptions throw before the first await_resume() [PR95615].

2021-02-26 Thread Iain Sandoe
Hi, The coroutine body is wrapped in a try-catch block which is responsible for handling any exceptions thrown by the original function body. Originally, the initial suspend expression was outside this, but an amendment to the standard places the await_resume call inside and everything else outsi

[PATCH] Objective-C++ : Fix handling of unnamed message parms [PR49070].

2021-02-26 Thread Iain Sandoe
Hi. We were discussing proposed reflection splicing syntax - [:reflection:] in SG7 which has some similarities with objective-c++ message syntax with unnamed params. This reminded me that we have a *very* long-standing regression against objective-c++ where it is not able to handle unnamed messag

Re: [PATCH] coroutines : Remove throwing_cleanup marks from the ramp [PR95822].

2021-02-26 Thread Iain Sandoe
Jason Merrill wrote: On 2/24/21 3:06 PM, Iain Sandoe wrote: The FE contains a mechanism for cleaning up return expressions if a function throws during the execution of cleanups prior to the return. If the original function has a return value with a non-trivial DTOR and the body contains a

[PATCH] libgomp, testsuite : Require alias support for PR96390 testcase.

2021-02-27 Thread Iain Sandoe
Hi, This test fails everywhere on Darwin, which does not have support for symbol aliases. Add a dg-require-alias to UNSUPPORT it. Ordinarily, I would have considered adding the dg-require as ‘obvious’ but I see that you already handled one case specifically (so wonder if there is some reason no

[pushed] Darwin : Update a disgnostic message [NFC].

2021-02-27 Thread Iain Sandoe
Hi The avoids a contraction and a format diagnostic warning. (it’s debatable whether this is really a useful user-facing error - but leaving that to another day). tested on x86_64-darwin, pushed to master, thanks Iain gcc/ChangeLog: * config/host-darwin.c (darwin_gt_pch_use_address): M

Re: [PATCH] coroutines : Remove throwing_cleanup marks from the ramp [PR95822].

2021-02-28 Thread Iain Sandoe
Jason Merrill wrote: On 2/26/21 4:36 PM, Iain Sandoe wrote: Jason Merrill wrote: On 2/24/21 3:06 PM, Iain Sandoe wrote: So (a) the 'throwing_cleanup' is no longer correct for the ramp and (b) we do not need to transfer it to the actor which only contains void retur

[pushed] testsuite, coroutines : Mark final awaiters and co_await operators noexcept.

2021-02-28 Thread Iain Sandoe
Hi, Fixing up some non-conforming testcases. This is part of the requirement of [dcl.fct.def.coroutine]/15. In addition to promise final_suspend() calls, the following cases must also be noexcept as per discussion in PR95616. - finalSuspendObj.operator co_await() - finalSuspendAwaiter.await_rea

ping^1 Re: [PATCH] Darwin, testsuite : Prune 'object file not found for object'.

2021-03-03 Thread Iain Sandoe
Iain Sandoe wrote: This is not a GCC problem, but a fault in the static linker where, when a source file is used multiple times, with conditional compilation the source file is only referenced by the linker for the first object. Then, when dsymutil tries to find the source file for next object

Re: [PATCH] coroutines: Correct frame capture of compiler temps [PR95591+4].

2021-03-03 Thread Iain Sandoe
Jason Merrill wrote: I notice this patch includes + var_nest_node () = default; which will break GCC 10 bootstrap with a C++98 compiler; we only switched to C++11 for GCC 11. Hmm, the patch was already backported… … I will fix this. I missed the warning during testing. Iain

Re: [PATCH] coroutines: Correct frame capture of compiler temps [PR95591+4].

2021-03-04 Thread Iain Sandoe
Iain Sandoe wrote: > Jason Merrill wrote: > >> I notice this patch includes >> >> + var_nest_node () = default; >> >> which will break GCC 10 bootstrap with a C++98 compiler; we only >> switched to C++11 for GCC 11. > > Hmm, the patch was

[PATCH] coroutines : Do not accept throwing final await expressions [PR95616].

2021-03-04 Thread Iain Sandoe
Hi, >From the PR: The wording of [dcl.fct.def.coroutine]/15 states: * The expression co_await promise.final_suspend() shall not be potentially-throwing ([except.spec]). See http://eel.is/c++draft/dcl.fct.def.coroutine#15 and http://eel.is/c++draft/except.spec#6 ie. all of the following must

[PATCH] coroutines : Adjust constraints on when to build ctors [PR98118].

2021-03-04 Thread Iain Sandoe
Hi, PR98118 shows that TYPE_NEEDS_CONSTRUCTING is a necessary, but not sufficient, condition for determining when we need to build a constructor. Use type_build_ctor_call() instead. tested on x86_64-darwin, x86_64-linux-gnu, [ ice on valid ] OK for master / 10.x? thanks Iain gcc/cp/ChangeLog:

ping^1 Re: [PATCH] Objective-C++ : Fix handling of unnamed message parms [PR49070].

2021-03-05 Thread Iain Sandoe
Although this is an Objective-C++ patch, I need to touch stuff outside “objc local” contexts, so think it needs review, (this is a regression fix for all open branches). Iain Sandoe wrote: We were discussing proposed reflection splicing syntax - [:reflection:] in SG7 which has some

Re: [PATCH] libgcov: Fix build on Darwin [PR99406]

2021-03-05 Thread Iain Sandoe
Jakub Jelinek via Gcc-patches wrote: As reported, bootstrap currently fails on older Darwin because MAP_ANONYMOUS is not defined. The following is what gcc/system.h does, so I think it should work for libgcov. Build tested on x86_64-linux, ok for trunk? bootstrap suceeded r11-7524 + this p

Re: [PATCH] coroutines : Do not accept throwing final await expressions [PR95616].

2021-03-05 Thread Iain Sandoe
Nathan Sidwell wrote: On 3/4/21 2:54 PM, Iain Sandoe wrote: Hi, From the PR: The wording of [dcl.fct.def.coroutine]/15 states: * The expression co_await promise.final_suspend() shall not be potentially-throwing ([except.spec]). See http://eel.is/c++draft/dcl.fct.def.coroutine#15 and http

[pushed] Darwin, X86, config: Adjust 'as' command lines [PR100340].

2021-08-17 Thread Iain Sandoe
. tested on x86_64-darwin20, x86_64-darwin17, i686-darwin9 and on x86_64-linux. Pushed to master, thanks Iain Signed-off-by: Iain Sandoe PR target/100340 - Bootstrap fails with Clang 12.0.5 (XCode 12.5) PR target/100340 gcc/ChangeLog: * config.in: Regenerate. * config

[pushed] Darwin: Reset section names table at the end of compile.

2021-08-17 Thread Iain Sandoe
-by: Iain Sandoe gcc/ChangeLog: * config/darwin.c (darwin_file_end): Reset and reclaim the section names table at the end of compile. --- gcc/config/darwin.c | 8 1 file changed, 8 insertions(+) diff --git a/gcc/config/darwin.c b/gcc/config/darwin.c index b160c23ea56

[PATCH] configure, jit: Allow for 'make check-gcc-jit'.

2021-08-17 Thread Iain Sandoe
ce feature that allows the user to do "make check-gcc-jit" at the top level of the build to check that facility in isolation from others. Signed-off-by: Iain Sandoe ChangeLog: * Makefile.def: Add a jit check target for the jit language. * Makefile.in: Regenerat

[pushed] Darwin, libcc1: Handle hosts with mdynamic-no-pic support.

2021-08-17 Thread Iain Sandoe
Hi, The default for building host-side binaries for mdynamic-no-pic hosts is to enable this. However, it is not compatible with dynamic libraries, so must be switched off for libcc1. tested on i686-darwin9, x86_64-darwin, x86_64-linux, pushed to master, thanks, Iain Signed-off-by: Iain Sandoe

[pushed] Objective-C: Default flag_objc_sjlj_exceptions off for NeXT ABI >= 2.

2021-08-17 Thread Iain Sandoe
Hi, This patch from Matt, adjusts the default exception model for all targets that might use NeXT ABI 2 (currently, Darwin had handled this locally). tested on x86_64-darwin, i686-darwin, x86_64-linux, pushed to master, thanks, Iain = Signed-off-by: Matt Jacobson gcc/c-family/ChangeLog:

[pushed] Darwin: Handle the -rpath command line option.

2021-08-18 Thread Iain Sandoe
Hi, This handles the command line '-rpath' option by passing it through to the static linker. tested on x86_64, i686-darwin, pushed to master, thanks, Iain Signed-off-by: Iain Sandoe gcc/ChangeLog: * config.gcc: Include rpath.opt for Darwin. * confi

[pushed] libiberty, Darwin : Fix simple-object LTO table for cross-endian case.

2021-08-18 Thread Iain Sandoe
x86_64-darwin to powerpc-darwin, pushed to master, thanks Iain Signed-off-by: Iain Sandoe libiberty/ChangeLog: * simple-object-mach-o.c (simple_object_mach_o_write_segment): Arrange to swap the LTO index tables where needed. --- libiberty/simple-object-mach-o.c | 5 + 1

  1   2   3   4   5   6   7   8   9   10   >