[Patch, avr, PR85624] - Fix ICE when initializing 128-byte aligned array

2018-07-18 Thread Senthil Kumar Selvaraj
also adds a testcase. Regression test showed no new failures, ok to commit to trunk? Regards Senthil gcc/ChangeLog: 2018-07-18 Senthil Kumar Selvaraj PR target/85624 * config/avr/avr.md (*clrmemqi): Change mode of operands[2] from QI to HI. gcc/testsuite/ChangeLog

[Patch, avr, PR86635] Fix miscompilation with __memx and libgcc float function __gtsf2

2018-07-25 Thread Senthil Kumar Selvaraj
with clobbered regs and substitutes pseudos in their place. The patch also adds a testcase to verify a is actually read. Reg testing passed. Ok to commit to trunk? Regards Senthil gcc/ChangeLog: 2018-07-25 Senthil Kumar Selvaraj * config/avr/avr-protos.h (avr_emit2_fix_outputs): New prot

Re: [Patch, avr, PR86635] Fix miscompilation with __memx and libgcc float function __gtsf2

2018-07-26 Thread Senthil Kumar Selvaraj
Senthil Kumar Selvaraj writes: > The below patch fixes a miscompilation of function calls with__memx address > space > arguments. > > For code like > > extern const __memx float a; > extern const float b; > > int diff () { return a > b; } > > when c

Re: [Patch] Fix infinite loop/crash if array initializer index equals max value

2013-09-04 Thread Senthil Kumar Selvaraj
On Fri, Aug 23, 2013 at 09:49:55PM +, Joseph S. Myers wrote: > On Thu, 22 Aug 2013, Selvaraj, Senthil_Kumar wrote: > > > 2013-08-23 Senthil Kumar Selvaraj > > * c-typeck.c (output_pending_init_elements): Handle overflow of > > constructor_unfilled_index.

[Patch, avr] Emit diagnostics if -f{pic,PIC,pie,PIE} or -shared is passed

2013-11-04 Thread Senthil Kumar Selvaraj
r if -shared is provided ( config/mep/mep.c and config/s390/tpf.h already do something very similar). Regression tested with no new failures.Tests which exercise PIC now report as unsupported. If ok, could someone commit please? I don't have commit access. Regards Senthil gcc/ChangeLog 2013-

[Patch, testsuite] Require scheduling support in gcc.dg/superblock.c

2013-11-04 Thread Senthil Kumar Selvaraj
se? I do not have commit access. Regards Senthil gcc/testsuite 2013-11-04 Senthil Kumar Selvaraj * gcc.dg/superblock.c: Require scheduling support diff --git gcc/testsuite/gcc.dg/superblock.c gcc/testsuite/gcc.dg/superblock.c index 2b9aedf..272d161 100644 --- gcc/testsuite/g

[Patch, avr] Restore default value of PARAM_ALLOW_STORE_DATA_RACES to 1

2016-02-01 Thread Senthil Kumar Selvaraj
with interrupts will need special handling for atomic access anyway, so I thought we should revert the default back to allow store data races. If this is ok, could someone commit please? I don't have commit access. Regards Senthil gcc/ChangeLog 2016-02-01 Senthil Kumar Selvaraj

[Patch, testsuite] Require int32 target support in sso tests

2016-02-04 Thread Senthil Kumar Selvaraj
o the host machine. If this patch is ok, could someone commit please? I don't have commit access. Regards Senthil gcc/testsuite/ChangeLog 2016-02-04 Senthil Kumar Selvaraj * gcc/testsuite/gcc.dg/sso/p1.c: Add dg-require-effective-target int32. * gcc/testsuite/gcc.dg/sso/p2.c: Li

Re: PATCH] Fix PR 31531: A microoptimization of isnegative of signed integer

2016-02-08 Thread Senthil Kumar Selvaraj
Hurugalawadi, Naveen writes: > Hi, > > Please find attached the patch that performs optimization on unsigned values. > > Original fold-const part implemented in match.pd. > > Please review the patch and let us know if it's OK? > > Regression Tested on X86_64 with no regressions. > > Thanks, > Nav

Re: [Patch, testsuite] Require int32 target support in sso tests

2016-02-22 Thread Senthil Kumar Selvaraj
Mike Stump okayed the patch (https://gcc.gnu.org/ml/gcc-patches/2016-02/msg00321.html). Could someone commit it for me please? I don't have commit access. Regards Senthil Senthil Kumar Selvaraj writes: > Hi, > > When running the regression testsuite for the AVR target, I notic

Re: [Patch, testsuite] Require int32 target support in sso tests

2016-02-22 Thread Senthil Kumar Selvaraj
Mike Stump writes: > On Feb 22, 2016, at 12:41 AM, Senthil Kumar Selvaraj > wrote: >> Could someone commit it for me please? I don't have commit access. > > Could you test out: > > Index: sso.exp > =

[Patch, testsuite] Skip addr_equal-1 if target keeps null pointer checks

2015-09-28 Thread Senthil Kumar Selvaraj
the builtin_constant_p to a false value, resulting in the test failure. If this is ok, could someone commit please? I don't have commit access. Regards Senthil gcc/testsuite/ChangeLog 2015-09-28 Senthil Kumar Selvaraj * gcc.dg/addr_equal-1.c: Skip test if target keeps nul

Re: [Patch, testsuite] Skip addr_equal-1 if target keeps null pointer checks

2015-09-28 Thread Senthil Kumar Selvaraj
On Mon, Sep 28, 2015 at 01:38:18PM -0600, Jeff Law wrote: > On 09/28/2015 02:15 AM, Senthil Kumar Selvaraj wrote: > >Hi, > > > > The below patch skips gcc.dg/addr_equal-1.c if the target keeps null > > pointer checks. > > > > The test fails for suc

[Patch, avr] Fix PR 67839 - bit addressable instructions generated for out of range addresses

2015-10-05 Thread Senthil Kumar Selvaraj
thil Kumar Selvaraj PR target/67839 * config/avr/predicates.md (low_io_address_operand): Don't consider MODE when computing upper bound. (io_address_operand): Likewise. gcc/testsuite/ChangeLog 2015-10-05 Senthil Kumar Selvaraj PR target/67839

Re: [Patch, avr] Fix PR 67839 - bit addressable instructions generated for out of range addresses

2015-10-16 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil On Mon, Oct 05, 2015 at 02:30:58PM +0530, Senthil Kumar Selvaraj wrote: > Hi, > > As part of support for io and io_low attributes, the upper bound of > the range check for low IO and IO addresses was changed from hardcoded > values to hardcode

Re: [Patch, avr] Fix PR 67839 - bit addressable instructions generated for out of range addresses

2015-10-27 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil On Fri, Oct 16, 2015 at 03:17:17PM +0530, Senthil Kumar Selvaraj wrote: > Ping! > > Regards > Senthil > > On Mon, Oct 05, 2015 at 02:30:58PM +0530, Senthil Kumar Selvaraj wrote: > > Hi, > > > > As part of support for io and i

[Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

2015-11-13 Thread Senthil Kumar Selvaraj
aller. Bootstrapped and reg tested on x86_64 (with --enable-languages=c,c++). If ok, could you commit please? I don't have commit access. Regards Senthil gcc/ChangeLog 2015-11-11 Senthil Kumar Selvaraj * tree-vrp.c (simplify_cond_using_ranges): Fold only if innerop

Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

2015-11-14 Thread Senthil Kumar Selvaraj
On Sat, Nov 14, 2015 at 09:13:41AM +0100, Marc Glisse wrote: > On Sat, 14 Nov 2015, Senthil Kumar Selvaraj wrote: > > >This patch came out of a discussion held in the gcc mailing list > >(https://gcc.gnu.org/ml/gcc/2015-11/msg00067.html). > > > >The patch restrict

Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

2015-11-14 Thread Senthil Kumar Selvaraj
On Sat, Nov 14, 2015 at 09:57:40AM +0100, Richard Biener wrote: > On November 14, 2015 9:49:28 AM GMT+01:00, Senthil Kumar Selvaraj > wrote: > >On Sat, Nov 14, 2015 at 09:13:41AM +0100, Marc Glisse wrote: > >> On Sat, 14 Nov 2015, Senthil Kumar Selvaraj wrote: > >>

Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

2015-11-17 Thread Senthil Kumar Selvaraj
On Mon, Nov 16, 2015 at 10:02:15AM +0100, Richard Biener wrote: > On Sat, 14 Nov 2015, Senthil Kumar Selvaraj wrote: > > > On Sat, Nov 14, 2015 at 09:57:40AM +0100, Richard Biener wrote: > > > On November 14, 2015 9:49:28 AM GMT+01:00, Senthil Kumar Selvaraj > > >

Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

2015-11-18 Thread Senthil Kumar Selvaraj
On Wed, Nov 18, 2015 at 09:36:21AM +0100, Richard Biener wrote: > On Wed, 18 Nov 2015, Senthil Kumar Selvaraj wrote: > > > On Mon, Nov 16, 2015 at 10:02:15AM +0100, Richard Biener wrote: > > > On Sat, 14 Nov 2015, Senthil Kumar Selvaraj wrote: > > > > > &g

Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

2015-11-20 Thread Senthil Kumar Selvaraj
On Thu, Nov 19, 2015 at 10:31:41AM -0700, Jeff Law wrote: > On 11/18/2015 11:20 PM, Senthil Kumar Selvaraj wrote: > >On Wed, Nov 18, 2015 at 09:36:21AM +0100, Richard Biener wrote: > >> > >>Otherwise ok. > > > >See modified patch below. If you think vrp98.c

Re: [Patch, avr, PR85624] - Fix ICE when initializing 128-byte aligned array

2018-08-06 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil Senthil Kumar Selvaraj writes: > Hi, > > The below patch fixes an ICE for the avr target when the setmemhi > expander is involved. > > The setmemhi expander generated RTL ends up as an unrecognized insn > if the alignment of the destination exceed

Re: [Patch, avr, PR85624] - Fix ICE when initializing 128-byte aligned array

2018-08-06 Thread Senthil Kumar Selvaraj
Jeff Law writes: > On 08/06/2018 04:53 AM, Senthil Kumar Selvaraj wrote: >> Ping! >> >> Regards >> Senthil >> >> Senthil Kumar Selvaraj writes: >> >>> Hi, >>> >>> The below patch fixes an ICE for the avr target w

[Ping, avr] Emit diagnostics if -f{pic,PIC,pie,PIE} or -shared is passed

2013-11-18 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil On Mon, Nov 04, 2013 at 06:45:19PM +0530, Senthil Kumar Selvaraj wrote: > The AVR backend does not generate position independent code, yet it > happily accepts -fpic, -fPIC, -fpie and -fPIE. The generated code > doesn't change at all. Also, it accepts the -sh

Fix address space computation in expand_debug_expr

2014-06-04 Thread Senthil Kumar Selvaraj
For the AVR target, assertions in convert_debug_memory_address cause a couple of ICEs (see PR 52472). Jakub suggested returning a NULL rtx, which works, but on debugging further, I found that expand_debug_expr appears to incorrectly compute the address space for ADDR_EXPR and MEM_REFs. For ADDR_EX

Re: Fix address space computation in expand_debug_expr

2014-06-05 Thread Senthil Kumar Selvaraj
On Thu, Jun 05, 2014 at 09:46:25AM +0200, Richard Biener wrote: > On Wed, Jun 4, 2014 at 10:06 PM, Senthil Kumar Selvaraj > wrote: > > For the AVR target, assertions in convert_debug_memory_address cause a > > couple of ICEs (see PR 52472). Jakub suggested returning a NULL rt

Re: [dwarf, RFC] Emitting per-function dwarf info

2015-05-19 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil On Fri, Apr 10, 2015 at 12:19:36PM +0530, Senthil Kumar Selvaraj wrote: > Hi, > > This (rather big) patch is an attempt to generate per function DWARF > information for functions that go into their own sections (through > -ffunction-section or otherwi

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-16 Thread Senthil Kumar Selvaraj
On Thu, Apr 16, 2015 at 11:02:05AM +0200, Georg-Johann Lay wrote: > Am 04/16/2015 um 08:43 AM schrieb Senthil Kumar Selvaraj: > >This patch fixes PR 65657. > > The following artifact appears to be PR63633. > I did see that one - unfortunately, that fix won't help here. I

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-17 Thread Senthil Kumar Selvaraj
On Thu, Apr 16, 2015 at 06:47:26PM +0200, Georg-Johann Lay wrote: > Am 04/16/2015 um 11:28 AM schrieb Senthil Kumar Selvaraj: > >On Thu, Apr 16, 2015 at 11:02:05AM +0200, Georg-Johann Lay wrote: > >>Am 04/16/2015 um 08:43 AM schrieb Senthil Kumar Selvaraj: > >>

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-23 Thread Senthil Kumar Selvaraj
On Fri, Apr 17, 2015 at 01:16:58PM +0530, Senthil Kumar Selvaraj wrote: > On Thu, Apr 16, 2015 at 06:47:26PM +0200, Georg-Johann Lay wrote: > > Am 04/16/2015 um 11:28 AM schrieb Senthil Kumar Selvaraj: > > >On Thu, Apr 16, 2015 at 11:02:05AM +0200, Georg-Johann Lay wrote: > &g

Re: [patch,avr]: Fix various problems with specs and specs file generation.

2015-03-03 Thread Senthil Kumar Selvaraj
On Mon, Mar 02, 2015 at 08:40:17PM +0100, Georg-Johann Lay wrote: > The new specs file generation introduces several problems. This patch > > - Fix build warnings > > - Clean up unused code and the old, now dead specs definitions. > > - Removes unused files and adjust build scripts / rules. >

[patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-15 Thread Senthil Kumar Selvaraj
? If not, could someone commit this please? I don't have commit access. Regards Senthil gcc/ChangeLog 2015-04-16 Senthil Kumar Selvaraj * config/avr/avr.c (avr_rtx_costs_1): Increase cost for MEM rtx in non-default address space. gcc/testsuite/ChangeLog 2015-04-16 Se

Re: [patch, avr] Fix PR64331: insn output and insn length computation rely on REG_DEAD notes.

2015-02-23 Thread Senthil Kumar Selvaraj
On Mon, Feb 23, 2015 at 11:53:52AM +0100, Georg-Johann Lay wrote: > This patch fixes PR64331 which produced wrong code because of outdated (too > many) REG_DEAD notes. These notes are not (re)computed per default, hence > do the computation by hand each time avr.c:reg_unused_after is called in a >

[Patch, testsuite] Fix some more bogus failures for avr

2016-08-03 Thread Senthil Kumar Selvaraj
Hi, Committed below patch to trunk as obvious. Regards Senthil 2016-08-03 Senthil Kumar Selvaraj * gcc.dg/init-excess-2.c: Require int32plus. * gcc.dg/pr44024.c: Skip if target keeps null pointer checks. * gcc.dg/pr59963-2.c: Require int32plus. * gcc.dg

[Patch, wwwdocs] Add caveat for AVR port

2016-08-08 Thread Senthil Kumar Selvaraj
Hi, This doc patch informs the user that a specific (or higher) version of binutils is a prerequisite for the fix for a rather vexing bug (PR 71151) that was fixed for 6.2. I've added it to the Caveats section; is there a better place? If not, ok to commit? Regards Senthil Index: chan

Re: [Patch, wwwdocs] Add caveat for AVR port

2016-08-08 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > On 08.08.2016 10:24, Senthil Kumar Selvaraj wrote: >> Hi, >> >> This doc patch informs the user that a specific (or higher) version of >> binutils is a prerequisite for the fix for a rather vexing bug (PR >> 71151) that was fixed

Re: [Patch, tentative, reload] Make push_reload work with more types of subregs?

2016-08-08 Thread Senthil Kumar Selvaraj
Bernd Schmidt writes: > On 07/28/2016 09:33 AM, Senthil Kumar Selvaraj wrote: >> >> Is there a reason why only REG and SYMBOL_REFs get valid >> subreg_in_class? I tried extending it handle constants and PLUS >> expressions, and it fixes PR 71873. It also fixes a

Re: [Patch, tentative, reload] Make push_reload work with more types of subregs?

2016-08-10 Thread Senthil Kumar Selvaraj
Bernd Schmidt writes: > On 08/08/2016 05:26 PM, Senthil Kumar Selvaraj wrote: > >> I picked out the commit where you'd added SYMBOL_REF handling (rev >> #190252), and patched that with the below code. Bootstrapped and >> regtested on x86_64-pc-linux - the re

[Patch, testsuite] Skip tests that expect 4 byte alignment for avr

2016-08-11 Thread Senthil Kumar Selvaraj
ommit? Regards Senthil gcc/testsuite/ChangeLog: 2016-08-11 Senthil Kumar Selvaraj * gcc.dg/ipa/propalign-1.c: Skip for targets with !natural_alignment_32 and !natural_alignment_64. * gcc.dg/ipa/propalign-2.c: Likewise. * gcc.dg/ipa/propalign-3.c: Lik

Re: [Patch, testsuite] Skip tests that expect 4 byte alignment for avr

2016-08-16 Thread Senthil Kumar Selvaraj
Jeff Law writes: > On 08/11/2016 01:40 AM, Senthil Kumar Selvaraj wrote: >> Hi, >> >> The below patch adds the AVR target to the list of targets that don't >> have natural_alignment_32. It also skips ipa/propalign-*.c >> tests (w

[Patch, testsuite] Fix more bogus test failures for avr

2016-08-24 Thread Senthil Kumar Selvaraj
gcc/testsuite/ChangeLog 2016-08-24 Senthil Kumar Selvaraj * gcc.c-torture/execute/pr71083.c: Use UINT32_TYPE instead of unsigned int. * gcc.dg/zero_sign_ext_test.c: Require int32plus. Index: gcc/testsuite/gcc.c-torture/execute/pr71083.c

[Patch, testsuite] Fix more bogus failures for avr

2016-09-01 Thread Senthil Kumar Selvaraj
-01 Senthil Kumar Selvaraj * gcc.dg/pr64252.c: Require int32plus. * gcc.dg/pr66299-1.c: Likewise. * gcc.dg/pr66299-2.c: Likewise. * gcc.dg/torture/20131115-1.c: Skip for avr. Index: gcc/testsuite/gcc.dg/pr64252.c

[Patch, testsuite, avr] Skip gcc.dg/Wno-frame-address.c for avr

2016-09-06 Thread Senthil Kumar Selvaraj
Hi, The below patch adds avr to the list of targets excluded for Wno-frame-address.c. Like the other excluded targets, the avr backend only supports the builtin for the current stack frame. Committed to trunk. Regards Senthil gcc/testsuite/ChangeLog: 2016-09-06 Senthil Kumar Selvaraj

[Patch, testsuite] Make some more tests xfail/pass/unsupported for avr

2016-05-25 Thread Senthil Kumar Selvaraj
don't have commit access. Regards Senthil 2016-05-25 Senthil Kumar Selvaraj * c-c++-common/Wduplicated-cond-1.c: Use smaller const literal. * c-c++-common/pr60226.c: Require int32plus. * gcc.c-torture/execute/pr70602.c: Likewise. * gcc.dg/Warray-bounds

[Patch, avr] Fix PR 71151

2016-06-03 Thread Senthil Kumar Selvaraj
that some more. If ok, could someone commit please? Could you also backport to gcc-6-branch? Regards Senthil gcc/ChangeLog 2016-06-03 Senthil Kumar Selvaraj * config/avr/avr.c (avr_asm_function_rodata_section): Remove. * config/avr/avr.c (TARGET_ASM_FUNCTION_RODATA_SE

Re: [Patch, avr] Fix PR 71151

2016-06-07 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > Senthil Kumar Selvaraj schrieb: >> Hi, >> >> This patch fixes PR 71151 by eliminating the >> TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting >> JUMP_TABLES_IN_TEXT_SECTION to 1. >> >> As described in the

[Patch, avr] Fix broken stack-usage-1.c test

2016-06-08 Thread Senthil Kumar Selvaraj
x for making gcc.dg/stack-usage-1.c pass again for avr. If this is ok, could someone commit please? I don't have commit access. Regards Senthil gcc/testsuite/ChangeLog 2016-06-08 Senthil Kumar Selvaraj * gcc.dg/stack-usage-1.c (SIZE): Consider return address when setting S

[Patch, testsuite] Skip some more tests for targets with int size < 32

2016-06-08 Thread Senthil Kumar Selvaraj
? I don't have commit access. Regards Senthil gcc/testsuite/ChangeLog 2016-06-08 Senthil Kumar Selvaraj * gcc.c-torture/execute/bswap-2.c: Require int32plus. * gcc.dg/torture/pr68067-1.c: Likewise. * gcc.dg/torture/pr68067-2.c: Likewise. diff --git gcc/test

Re: [Patch, avr] Fix PR 71151

2016-06-16 Thread Senthil Kumar Selvaraj
Senthil Kumar Selvaraj writes: > Georg-Johann Lay writes: > >> Senthil Kumar Selvaraj schrieb: >>> Hi, >>> >>> This patch fixes PR 71151 by eliminating the >>> TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting >>> JUMP_TABLES_IN_T

Re: [Patch, avr] Fix PR 71151

2016-06-16 Thread Senthil Kumar Selvaraj
Denis Chertykov writes: > 2016-06-16 10:27 GMT+03:00 Senthil Kumar Selvaraj > : >> >> Senthil Kumar Selvaraj writes: >> >>> Georg-Johann Lay writes: >>> >>>> Senthil Kumar Selvaraj schrieb: >>>&g

MAINTAINERS (Write After Approval): Add myself

2016-06-18 Thread Senthil Kumar Selvaraj
Added myself to MAINTAINERS (Write After Approval). Regards Senthil Index: ChangeLog === --- ChangeLog (revision 237571) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2016-06-18 Senthil Kumar Selvaraj + + * MAINTAINERS

Re: [Patch, avr] Fix PR 71151

2016-06-18 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > Senthil Kumar Selvaraj schrieb: >> Hi, >> >> This patch fixes PR 71151 by eliminating the >> TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting >> JUMP_TABLES_IN_TEXT_SECTION to 1. >> >> As described in the

[Patch, testsuite] Mark some more tests as UNSUPPORTED for avr

2016-06-20 Thread Senthil Kumar Selvaraj
Hi, This patch fixes some bogus failures for the avr target by requiring int32plus or ptr32plus support. Ok for trunk? Regards Senthil gcc/testsuite/ChangeLog: 2016-06-20 Senthil Kumar Selvaraj * c-c++-common/pr68657-1.c: Require ptr32plus support. * c-c++-common

Re: [Patch, avr] Fix PR 71151

2016-06-22 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > Senthil Kumar Selvaraj schrieb: >> Senthil Kumar Selvaraj writes: >> >>> Georg-Johann Lay writes: >>> >>>> Senthil Kumar Selvaraj schrieb: >>>>> Hi, >>>>> >>>>> [set JUMP_TABL

Re: [patch,avr]: ad PR71151: Make test cases pass on smaller targets.

2016-06-23 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > On 22.06.2016 19:06, Mike Stump wrote: >> On Jun 22, 2016, at 7:21 AM, Georg-Johann Lay wrote: >>> >>> Some tests for PR71151 assume that the target MCU has a 3-byte PC. The >>> tests are failing because the simulator (avrtest) rejects to load the >>> respective execut

[Patch, testsuite, committed] Fix cunroll-13.c failure for avr

2017-05-09 Thread Senthil Kumar Selvaraj
hil gcc/testsuite/ 2017-05-09 Senthil Kumar Selvaraj * gcc.dg/tree-ssa/cunroll-13.c: Use __INT32_TYPE__ for for targets with __SIZEOF_INT__ < 4. diff --git gcc/testsuite/gcc.dg/tree-ssa/cunroll-13.c gcc/testsuite/gcc.dg/tree-ssa/cunroll-13.c index f3fe8b51468..904e6dc075b 100

[Patch, testsuite, committed] Fix bogus pr78886.c for avr

2017-05-16 Thread Senthil Kumar Selvaraj
gcc/testsuite/ChangeLog 2017-05-17 Senthil Kumar Selvaraj * gcc.dg/tree-ssa/pr78886.c: Use __SIZE_TYPE__ instead of unsigned long. Index: gcc/testsuite/gcc.dg/tree-ssa/pr78886.c === --- gcc/testsuite/gcc.dg/tre

[Patch, testsuite, committed] Fix bogus builtin-snprintf-warn-3.c failure for avr

2017-05-23 Thread Senthil Kumar Selvaraj
to (16 bit) int size. Fixed by marking the test as unsupported for targets with ptr size < 32. Committed as obvious. Regards Senthil gcc/testsuite/ 2017-05-23 Senthil Kumar Selvaraj * gcc.dg/tree-ssa/builtin-snprintf-warn-3.c: Require ptr32plus. Index: gcc/testsuite/gcc.dg/tre

[Patch, testsuite] Fix failing overflow-1.c for avr

2017-03-21 Thread Senthil Kumar Selvaraj
Hi, The test assumes 32 bit ints, and expects a constant in the dump that is only valid for 32 bit ints. This trivial patch fixes that by explicitly specifying __UINT32_TYPE__ as the type. Committed as obvious. Regards Senthil gcc/testsuite/ChangeLog 2017-03-21 Senthil Kumar Selvaraj

[Patch, testsuite] Fix more failing tests for avr

2017-03-28 Thread Senthil Kumar Selvaraj
Kumar Selvaraj * gcc.c-torture/execute/pr79121.c:Use __{U}INT32_TYPE__ for targets with sizeof(int) < 4. * gcc.c-torture/execute/pr79737-1.c (struct S): Likewise. * gcc.c-torture/execute/pr79737-2.c: Likewise. * gcc.dg/torture/pr79777.c: Likew

[Patch, testsuite] Fix failing builtin-sprintf-warn-{3,10}.c for avr

2017-04-06 Thread Senthil Kumar Selvaraj
est appears to assume all non lp64 targets to be ilp32. For the avr, pointer size and int size are equal, but both are 16 bits, not 32. The patch fixes this by explicitly adding avr to the dejagnu selector. Ok for trunk? Regards Senthil gcc/testsuite/ChangeLog: 2017-04-06 Senthil Ku

[Patch, testsuite] Fix broken pr80341.c for avr

2017-04-19 Thread Senthil Kumar Selvaraj
onversion" of the unsigned short to signed int doesn't occur, and this causes the test to fail. Committed as obvious. Regards Senthil 2017-04-19 Senthil Kumar Selvaraj * gcc.dg/torture/pr80341.c: Require int32plus. Index: g

[Patch, testsuite] Skip pr80170.c for non-ptr32plus targets

2017-04-19 Thread Senthil Kumar Selvaraj
gcc/testsuite/ChangeLog 2017-04-19 Senthil Kumar Selvaraj * gcc.dg/pr80170.c: Require ptr32plus. Index: gcc.dg/pr80170.c === --- gcc.dg/pr80170.c(revision 247010) +++ gcc.dg/pr80170.c(working copy) @@ -1,5 +1,6

[Patch, testsuite] Fix failing attr-alloc_size-10.c for avr

2017-04-25 Thread Senthil Kumar Selvaraj
-04-25 Senthil Kumar Selvaraj * gcc.dg/attr-alloc_size-10.c: Ignore overflow warnings for targets with int size less than 32 bits. Index: gcc/testsuite/gcc.dg/attr-alloc_size-10.c === --- gcc/testsuite/gcc.dg/attr

[Patch, testsuite] Fix bogus pr78138.c failure for avr

2017-05-02 Thread Senthil Kumar Selvaraj
in a couple of FAILs. The patch fixes that by typedef'ing __SIZE_TYPE__ to size_t and using size_t as the type for memcpy's third parameter. Committed to trunk as obvious. Regards Senthil gcc/testsuite/ChangeLog 2017-05-02 Senthil Kumar Selvaraj * gcc.dg/pr78

[Patch, avr]Fix multiple ICE fallout of PR 69764

2016-03-10 Thread Senthil Kumar Selvaraj
mit access. Regards Senthil 2016-03-10 Senthil Kumar Selvaraj * config/avr/avr.md (rotl3): Set mode for operand 2. diff --git gcc/config/avr/avr.md gcc/config/avr/avr.md index ff26f2e..c988446 100644 --- gcc/config/avr/avr.md +++ gcc/config/avr/avr.md @@ -3351,7 +3351,7 @@ (define_

[Patch, testsuite] Skip testcase for avr

2016-03-18 Thread Senthil Kumar Selvaraj
don't have commit access. Regards Senthil gcc/testsuite/ChangeLog 2016-03-16 Senthil Kumar Selvaraj * gcc.c-torture/compile/20151204.c: Skip for avr. diff --git a/gcc/testsuite/gcc.c-torture/compile/20151204.c b/gcc/testsuite/gcc.c-torture/compile/20151204.c index 036316c..0a60871 1

Re: [Patch, testsuite] Skip testcase for avr

2016-03-19 Thread Senthil Kumar Selvaraj
ite/gcc.c-torture/compile/20151204.c >> @@ -1,3 +1,5 @@ >> +/* { dg-skip-if "Array too big" { "avr-*-*" } { "*" } { "" } } */ > > just one nit: please omit the default args to dg-skip-if, they are > unnecessary. > Done. gcc/testsuite/

[Patch, testsuite] Require int32plus and scheduling support for some tests

2016-04-04 Thread Senthil Kumar Selvaraj
lus - they either use bit shifts wider than 16 bits (AVR's int size), or use int constants that are too big for a 16 bit int. If ok, could someone commit please? I don't have commit access. Regards Senthil 2016-04-04 Senthil Kumar Selvaraj * gcc.c-torture/compile/pr69102.c

[Patch] Fix PR 60040

2016-04-07 Thread Senthil Kumar Selvaraj
sions. If ok, could someone commit please? I don't have commit access. Regards Senthil gcc/ChangeLog 2016-04-07 Joern Rennecke Senthil Kumar Selvaraj PR target/60040 * reload1.c (find_reload_regs): Add tentative parameter. and don't report s

Re: [Patch, testsuite] Require int32plus and scheduling support for some tests

2016-04-13 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil Senthil Kumar Selvaraj writes: > Hi, > > This patch add dg-require-effective-target directives to a few tests > that were failing unnecessarily for the AVR target. > > One of them invokes the compiler with -fschedule-insns2 - I've > requi

Re: [Patch] Fix PR 60040

2016-04-15 Thread Senthil Kumar Selvaraj
Bernd Schmidt writes: > On 04/07/2016 01:52 PM, Senthil Kumar Selvaraj wrote: >>The below patch fixes PR 60040 by not halting with a hard error on >>a spill failure, if reload knows that it has to run again anyway. > > Some additional information as to how this situ

Re: [Patch] Fix PR 60040

2016-04-25 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil Senthil Kumar Selvaraj writes: > Bernd Schmidt writes: > >> On 04/07/2016 01:52 PM, Senthil Kumar Selvaraj wrote: >>>The below patch fixes PR 60040 by not halting with a hard error on >>>a spill failure, if reload knows that it has t

[Patch, testsuite] Require int32plus for pr70421.c

2016-09-16 Thread Senthil Kumar Selvaraj
Hi, This patch fixes a bogus testsuite failure for the avr target. The test has integer literals that only fit on targets with int size >= 32. Committed to trunk. Regards Senthil gcc/testsuite/ChangeLog 2016-09-16 Senthil Kumar Selvaraj * gcc.dg/torture/pr70421.c: Requ

[Patch, reload, tentative, PR 71627] Tweak conditions in find_valid_class_1

2016-09-16 Thread Senthil Kumar Selvaraj
Hi, The below patch fixes what I think are a couple of problems with reload.c:find_valid_class_1. First, even if no regno is in_hard_reg_set_p, it goes ahead and considers rclass as valid. bad is set only if a regno is in the reg class *and* HARD_REGNO_MODE_OK is false - if both are fal

[Patch, testsuite] Make pr64130.c pass for avr

2016-09-20 Thread Senthil Kumar Selvaraj
nthil Kumar Selvaraj * gcc.dg/tree-ssa/pr64130.c: Use __UINT32_TYPE__ instead of int. Index: gcc.dg/tree-ssa/pr64130.c === --- gcc.dg/tree-ssa/pr64130.c (revision 240299) +++ gcc.dg/tree-ssa/pr64130.c (revision 240300) @@

[Patch, avr] Provide correct LD offset bound in avr_address_cost

2016-09-21 Thread Senthil Kumar Selvaraj
aling SImode costs by 2 for DImode muls. With both changes in, there are no regressions, and the builtin-arith-overflow-* tests now PASS and don't timeout. Ok to commit to trunk and backport to 5.x? Regards Senthil gcc/ChangeLog: 2016-09-21 Senthil Kumar Selvaraj * config

Backport fix for PR 65210 to gcc-5-branch

2016-09-22 Thread Senthil Kumar Selvaraj
Hi, Is it ok to backport PR 65210 to gcc-5-branch? The patch is already in 6.x and trunk. Regards Senthil gcc/ChangeLog 2016-09-22 Senthil Kumar Selvaraj Backport from trunk r227496 PR target/65210 * config/avr/avr.c (avr_eval_addr_attrib): Look for io_low

Re: [Patch, avr] Backport fix for PR 65210 to gcc-5-branch

2016-09-26 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil Senthil Kumar Selvaraj writes: > Hi, > > Is it ok to backport PR 65210 to gcc-5-branch? The patch is already in > 6.x and trunk. > > Regards > Senthil > > gcc/ChangeLog > > 2016-09-22 Senthil Kumar Selvaraj > > Backport

Re: [Patch, reload, tentative, PR 71627] Tweak conditions in find_valid_class_1

2016-09-26 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil Senthil Kumar Selvaraj writes: > Hi, > > The below patch fixes what I think are a couple of problems with > reload.c:find_valid_class_1. > > First, even if no regno is in_hard_reg_set_p, it goes ahead and > considers rclass as valid. bad is s

[Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c

2016-09-27 Thread Senthil Kumar Selvaraj
unexpected warnings. Comitted to trunk. Regards Senthil 2016-09-27 Senthil Kumar Selvaraj * gcc.dg/tree-ssa/builtin-sprintf-warn-1.c: Require int32plus. PR fortran/77666 Index: gcc.dg/tree-ssa/builtin-sprint

Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c

2016-09-27 Thread Senthil Kumar Selvaraj
James Greenhalgh writes: > On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote: >> Hi, >> >> This patch requires int32plus for >> gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, as it reports a bunch of >> failures for a 16 bit int tar

[Patch, testsuite] Add ffat-lto-objects to gcc.target/avr/torture/builtins_error.c

2016-10-03 Thread Senthil Kumar Selvaraj
consistently at compile, as expected. Committed to trunk. Regards Senthil gcc/testsuite/ChangeLog: 2016-10-03 Senthil Kumar Selvaraj * gcc.target/avr/torture/builtins-error.c: Add -ffat-lto-objects option. Index: gcc/testsuite/gcc.target/avr/torture/builtins-error.c

[Patch, testsuite] Fix pr69941.c test failure for avr

2016-10-05 Thread Senthil Kumar Selvaraj
/ChangeLog 2016-10-05 Senthil Kumar Selvaraj * gcc.dg/torture/pr69941.c: Use __INT32_TYPE__ instead of int if __SIZEOF_INT__ is less than 4 bytes. Index: gcc/testsuite/gcc.dg/torture/pr69941.c === --- gcc/testsuite

[Patch, testsuite] Fix gcc.g/tree-ssa/pr59597.c failure for avr

2016-10-11 Thread Senthil Kumar Selvaraj
reg testing with avr and x86_64-pc-linux Regards Senthil gcc/testsuite/ChangeLog 2016-10-11 Senthil Kumar Selvaraj * gcc.dg/tree-ssa/pr59597.c: Typedef __INT32_TYPE__ to i32. (main): Declare j as i32 instead of int. Index: gcc/testsuite/gcc.dg/tree-ssa/pr5959

Re: [Patch, reload, tentative, PR 71627] Tweak conditions in find_valid_class_1

2016-10-12 Thread Senthil Kumar Selvaraj
Bernd Schmidt writes: > On 09/16/2016 09:02 PM, Senthil Kumar Selvaraj wrote: >> Does this make sense? I ran a reg test for the avr target with a >> slightly older version of this patch, it did not show any regressions. >> If this is the right fix, I'll make sure

[Patch] Backport fix for PR 52085 to gcc-5-branch?

2016-10-17 Thread Senthil Kumar Selvaraj
10-17 Senthil Kumar Selvaraj Backport from mainline 2015-04-25 Marek Polacek PR c/52085 * c-decl.c (finish_enum): Copy over TYPE_ALIGN. Also check for "mode" attribute. gcc/testsuite/ChangeLog 2016-10-17 Senthil Kumar Selvaraj Backpor

Re: [Patch] Backport fix for PR 52085 to gcc-5-branch?

2016-10-17 Thread Senthil Kumar Selvaraj
Richard Biener writes: > On Mon, Oct 17, 2016 at 12:21 PM, Senthil Kumar Selvaraj > wrote: >> Hi, >> >> The fix for PR 52085 went into trunk when trunk was 6.0. I ran into the >> same issue on a gcc 5.x and found that the fix didn't get backported. >&g

Re: [Patch] Backport fix for PR 52085 to gcc-5-branch?

2016-10-18 Thread Senthil Kumar Selvaraj
Jakub Jelinek writes: > On Tue, Oct 18, 2016 at 10:12:24AM +0200, Richard Biener wrote: >> On Mon, Oct 17, 2016 at 6:57 PM, Senthil Kumar Selvaraj >> wrote: >> > >> > Richard Biener writes: >> > >> >> On Mon, Oct 17, 2016 at 12

Re: [Patch, reload, tentative, PR 71627] Tweak conditions in find_valid_class_1

2016-10-18 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil Senthil Kumar Selvaraj writes: > Bernd Schmidt writes: > >> On 09/16/2016 09:02 PM, Senthil Kumar Selvaraj wrote: >>> Does this make sense? I ran a reg test for the avr target with a >>> slightly older version of this patch, it did not

Re: [Patch] Backport fix for PR 52085 to gcc-5-branch?

2016-10-18 Thread Senthil Kumar Selvaraj
Jakub Jelinek writes: > On Tue, Oct 18, 2016 at 02:46:29PM +0530, Senthil Kumar Selvaraj wrote: >> > I'm not convinced it is desirable to backport such changes, it affects ABI, >> > people are used to deal with minor ABI changes in between major GCC >> > rele

[Patch,testsuite] Fix sso.exp not calling torture-finish for avr

2016-10-18 Thread Senthil Kumar Selvaraj
s like the avr for which the effective target condition is true, and this leaves torture-options set, which causes the errors and differing options. The below patch makes the return occur earlier - before calling the init functions. Committed to trunk. Regards Senthil 2016-10-18 Sen

Re: [Patch, reload, tentative, PR 71627] Tweak conditions in find_valid_class_1

2016-10-18 Thread Senthil Kumar Selvaraj
Bernd Schmidt writes: > On 10/13/2016 08:57 AM, Senthil Kumar Selvaraj wrote: >> >> 2016-10-13 Senthil Kumar Selvaraj >> >> * reload.c (find_valid_class_1): Allow regclass if atleast one >> regno in class is ok. Compute and use rclass size based on

Re: [Patch, reload, tentative, PR 71627] Tweak conditions in find_valid_class_1

2016-10-21 Thread Senthil Kumar Selvaraj
Bernd Schmidt writes: > On 10/18/2016 02:15 PM, Senthil Kumar Selvaraj wrote: >> Will do both the changes and re-run the reg tests. Ok for trunk if the >> tests pass for x86_64-pc-linux and avr? >> > Probably but let's see the patch first. How does this look? Boots

[Patch, testsuite] Skip gcc.dg/lto/pr60449_0.c for avr

2016-10-31 Thread Senthil Kumar Selvaraj
Hi, gcc.dg/lto/pr60449_0.c fails to link for the avr target because it doesn't have an implementation for gettimeofday. This patch therefore skips the test for avr. Committed to trunk as obvious. Regards Senthil gcc/testsuite/ChangeLog 2016-10-31 Senthil Kumar Sel

[Patch, testsuite] Fix bogus PR 78170 failure for avr

2016-11-03 Thread Senthil Kumar Selvaraj
Hi, The below patch requires int32plus for gcc.c-torture/execute/pr78170.c, as it has int bitfields that are more than 16 bits wide. Committed to trunk as obvious. Regards Senthil gcc/testsuite/ChangeLog 2016-11-03 Senthil Kumar Selvaraj * gcc.c-torture/execute/pr78170.c

[Patch, testsuite] Add new effective-target_store_merge

2016-11-03 Thread Senthil Kumar Selvaraj
gcc/testsuite/ChangeLog 2016-11-03 Senthil Kumar Selvaraj * gcc.dg/store_merging_1.c: Require store_merge. * gcc.dg/store_merging_2.c: Likewise. * gcc.dg/store_merging_4.c: Likewise. * gcc.dg/store_merging_5.c: Likewise. * gcc.dg/store_merging_6.c: Lik

[Patch, avr] Fix PR 50739 - nameless error with -fmerge-all-constants

2016-07-04 Thread Senthil Kumar Selvaraj
e set by switch_section anyway. Reg testing showed no new regressions. Ok for trunk and backport to 6.x? Regards Senthil gcc/testsuite/ChangeLog: 2016-07-05 Senthil Kumar Selvaraj PR target/50739 * gcc.target/avr/pr50739.c: New test. gcc/ChangeLog: 2016-07-05 Senthil

Re: [Patch, avr] Fix PR 50739 - nameless error with -fmerge-all-constants

2016-07-04 Thread Senthil Kumar Selvaraj
Senthil Kumar Selvaraj writes: > Hi, > > This patch fixes a problem with fmerge-all-constants and the progmem > attribute - on trunk, the below testcase errors out with a section > conflict error. > > When avr_asm_select_section renames .rodata.xyz section to >

  1   2   >