Re: [committed][nvptx] Set -misa=sm_35 by default

2021-05-03 Thread Tom de Vries
On 3/23/21 9:04 AM, Thomas Schwinge wrote: > From eac0d3458f38cd5bb4c930b2887a547b64b046ef Mon Sep 17 00:00:00 2001 > From: Thomas Schwinge > Date: Wed, 13 Jan 2021 09:04:47 +0100 > Subject: [PATCH] [nvptx] Let nvptx-as figure out the target architecture > [PR97348] > > ... now that it has been

Re: [PATCH][openmp, simt] Error out for user-defined reduction

2021-05-03 Thread Tom de Vries
On 5/3/21 12:31 PM, Jakub Jelinek wrote: > On Mon, May 03, 2021 at 12:24:10PM +0200, Tom de Vries wrote: >> The test-case included in this patch contains this target region: >> ... >> for (int i0 = 0 ; i0 < N0 ; i0++ ) >> counter_N0.i += 1; >> ... >&

Re: [committed][nvptx] Set -misa=sm_35 by default

2021-05-03 Thread Tom de Vries
On 3/23/21 9:04 AM, Thomas Schwinge wrote: > What is your opinion about backporting that (plus Tobias' documentation > update, plus corresponding web 'changes.html' updates?) to release > branches, so that nvptx offloading users may use GCC 10/9/8 with CUDA > 11.0+? Hmm, so you're talking about ma

Re: [Patch] + [nvptx RFH/RFC]: OpenMP: Fix SIMT for complex/float reduction with && and ||

2021-05-06 Thread Tom de Vries
On 5/6/21 12:30 PM, Jakub Jelinek wrote: > On Thu, May 06, 2021 at 12:17:03PM +0200, Tobias Burnus wrote: >> OpenMP: Fix SIMT for complex/float reduction with && and || >> >> gcc/ChangeLog: >> >> * omp-low.c (lower_rec_input_clauses): Also handle SIMT part >> for complex/float recution wi

Re: [Patch] + [nvptx RFH/RFC]: OpenMP: Fix SIMT for complex/float reduction with && and ||

2021-05-06 Thread Tom de Vries
On 5/6/21 3:12 PM, Tom de Vries wrote: > On 5/6/21 12:30 PM, Jakub Jelinek wrote: >> On Thu, May 06, 2021 at 12:17:03PM +0200, Tobias Burnus wrote: >>> OpenMP: Fix SIMT for complex/float reduction with && and || >>> >>> gcc/ChangeLog: >>> >&

Re: [Patch] + [nvptx RFH/RFC]: OpenMP: Fix SIMT for complex/float reduction with && and ||

2021-05-07 Thread Tom de Vries
On 5/7/21 12:05 PM, Tobias Burnus wrote: > On 06.05.21 16:32, Jakub Jelinek wrote: > >> s/recution/reduction/ > Fixed. >> This comment needs to be adjusted to talk about non-integral types. > Fixed. >> Is this hunk still needed when the first hunk is in? > > No - and now removed. > > Updated cod

[PATCH][nvptx] Add -mptx=3.1/6.3

2021-05-12 Thread Tom de Vries
Hi, Add nvptx option -mptx that sets the ptx ISA version. This is currently hardcoded to 3.1. Tested libgomp on x86_64-linux with nvptx accelerator, both with default set to 3.1 and 6.3. Any comments? Thanks, - Tom [nvptx] Add -mptx=3.1/6.3 gcc/ChangeLog: 2021-05-12 Tom de Vries

Re: [PATCH][nvptx] Add -mptx=3.1/6.3

2021-05-12 Thread Tom de Vries
On 5/12/21 5:50 PM, Tobias Burnus wrote: > Hi, > > On 12.05.21 16:10, Tom de Vries wrote: >> Add nvptx option -mptx that sets the ptx ISA version.  This is currently >> hardcoded to 3.1. >> Tested libgomp on x86_64-linux with nvptx accelerator, both with >> defa

Re: [wwwdocs, patch] gcc-12/changes.html: Document -mptx for nvptx

2021-05-17 Thread Tom de Vries
On 5/17/21 10:49 AM, Tobias Burnus wrote: > Early *PING*  - and I fixed a wording issue in my patch. > > OK? Suggestions? > LGTM, thanks. - Tom > Tobias > > On 14.05.21 00:06, Tobias Burnus wrote: >> Document this new flag, added in >> https://gcc.gnu.org/g:2a1586401a21dcd43e0f904bb6eec26c8b2f

[PATCH][nvptx] Handle memmodel for atomic ops

2021-05-17 Thread Tom de Vries
, - Tom [nvptx] Handle memmodel for atomic ops gcc/ChangeLog: 2021-05-17 Tom de Vries PR target/100497 * config/nvptx/nvptx-protos.h (nvptx_output_atomic_insn): Declare * config/nvptx/nvptx.c (nvptx_output_barrier) (nvptx_output_atomic_insn): New function

Re: [PATCH][nvptx] Handle memmodel for atomic ops

2021-05-17 Thread Tom de Vries
On 5/17/21 6:47 PM, Tobias Burnus wrote: > On 17.05.21 17:49, Tom de Vries wrote: >> [ Tobias, can you test this on volta ? ] > > Unfortunately, it does not seem to help. On a non-Volta system, it still > works (run time 0.3s) but on a Volta system it fails after 1.5s (abort).

[PATCH] [debug] Fix dwarf v4 .debug_macro.dwo

2024-05-14 Thread Tom de Vries
Consider a hello world, compiled with -gsplit-dwarf and dwarf version 4, and -g3: ... $ gcc -gdwarf-4 -gsplit-dwarf /data/vries/hello.c -g3 -save-temps -dA ... In section .debug_macro.dwo, we have: ... .Ldebug_macro0: .value 0x4 # DWARF macro version number .byte 0x2 #

[PATCH] [testsuite] Fix gcc.dg/pr115066.c fail on aarch64

2024-05-14 Thread Tom de Vries
explicitly matching the comment marker. Tested on aarch64 and x86_64. gcc/testsuite/ChangeLog: 2024-05-14 Tom de Vries * gcc.dg/pr115066.c: Don't match comment marker. --- gcc/testsuite/gcc.dg/pr115066.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH, C++, PR58282] Handle noexcept on transactions with -fno-exceptions

2013-09-03 Thread Tom de Vries
6_64. OK for trunk? Thanks, - Tom 2013-09-02 Tom de Vries PR c++/58282 * semantics.c (finish_transaction_stmt, build_transaction_expr): Handle flag_exceptions. diff --git a/gcc/cp/semantics.c b/gcc/cp/semantics.c index ee3503c..c8b328c 100644 --- a/gcc/cp/semantics.c

Re: [PATCH, C++, PR58282] Handle noexcept on transactions with -fno-exceptions

2013-09-06 Thread Tom de Vries
On 04/09/13 19:21, Jason Merrill wrote: > On 09/03/2013 06:03 AM, Tom de Vries wrote: >> * semantics.c (finish_transaction_stmt, build_transaction_expr): Handle >> flag_exceptions. > > I'd rather handle this at a lower level, by making > build_must_not_thro

[Patch, Committed] Fix declared inline after being called warning

2012-10-01 Thread Tom de Vries
ranch. The problem is not present in the 4.6 branch, and with trunk the warning doesn't trigger, I suppose because we're using g++ now. Build on i686-pc-linux-gnu. Thanks, - Tom 2012-10-01 Tom de Vries * var-tracking.c (set_dv_changed): Add an 'inline' function s

Check that unlinked uses do not contain ssa-names when renaming.

2012-10-07 Thread Tom de Vries
? Thanks, - Tom 2012-10-07 Tom de Vries * tree-into-ssa.c (maybe_replace_use): Add assert. Index: gcc/tree-into-ssa.c === --- gcc/tree-into-ssa.c (revision 192023) +++ gcc/tree-into-ssa.c (working copy) @@ -1773,6 +1773,9

[PATCH] Stop looping in move_by_pieces loops when there's no more data to process

2012-10-15 Thread Tom de Vries
1034 gcc_assert (l > 0); (gdb) ... This patch fixes that in this loop, and other move_by_pieces loops. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom 2012-10-16 Tom de Vries * expr.c (move_by_pieces, move_by_pieces_ninsns, can_store_by_pieces) (

[PATCH, ARM] Fix line number data for PIC register setup code

2013-10-13 Thread Tom de Vries
R_TARGET=-fPIC. The patch removes 174 FAILs. Re-testing gcc with target arm-none-linux-gnueabi atm. OK for trunk? Thanks, - Tom 2013-10-13 Tom de Vries * cfgexpand.c (gimple_expand_cfg): Don't commit insertions after NOTE_INSN_FUNCTION_BEG. * gcc.target/arm

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-14 Thread Tom de Vries
On 14/10/13 00:17, Tom de Vries wrote: > This patch makes sure we emit insertions scheduled for the first real BB > before > NOTE_INSN_FUNCTION_BEG. As a consequence, it moves the PIC register setup code > to before the NOTE_INSN_FUNCTION_BEG. This removes the second .loc, and the >

[PATCH, PR58805] Add missing check in stmt_local_def for tail-merge

2013-10-22 Thread Tom de Vries
Richard, This patch adds a missing check for gimple_vdef in stmt_local_def for the tail-merge pass. Bootstrapped and reg-tested on x86_64. OK for trunk, gcc-4_8-branch? Thanks, - Tom 2013-10-22 Tom de Vries PR tree-optimization/58805 * tree-ssa-tail-merge.c (stmt_local_def

Re: [PATCH, PR58805] Add missing check in stmt_local_def for tail-merge

2013-10-23 Thread Tom de Vries
On 22/10/13 20:50, Jeff Law wrote: > On 10/22/13 03:58, Tom de Vries wrote: >> Richard, >> >> This patch adds a missing check for gimple_vdef in stmt_local_def for the >> tail-merge pass. >> >> Bootstrapped and reg-tested on x86_64. >> >> O

Re: [PATCH, C++, PR58282] Handle noexcept on transactions with -fno-exceptions

2013-10-25 Thread Tom de Vries
On 07/09/13 18:54, Jason Merrill wrote: > OK. > I've reproduced the same problem with the 4.7 and 4.8 branch, and checked that applying the patch fixes the problem. Committed to 4.7 and 4.8 branch as well. Thanks, - Tom

[PING] [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-27 Thread Tom de Vries
Ping. Original submission at http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00903.html . This patch fixes a regression of 174 tests in the gdb testsuite for arm-linux-gnueabi with -fPIC (or arm-linux-androideabi) caused by the fix for PR47028. The fix for PR47028 made sure that insertions on the s

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-28 Thread Tom de Vries
> NOTE_INSNS_FUNCTION_BEG. > > So this means that parm_birth_insn can never be null, right? > Yes, AFAICT parm_birth_insn is never NULL at this point. >> 2013-10-13 Tom de Vries >> >> * cfgexpand.c (gimple_expand_cfg): Don't commit insertions after >>

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-29 Thread Tom de Vries
On 29/10/13 09:12, Eric Botcazou wrote: >> Updated patch, re-bootstrapped on x86_64 and committed to trunk. >> >> Also applied to 4.7 and 4.8 branches, the same problem is present there. > > You only asked for approval on trunk though, Eric, Sorry about that. > and I'm not sure we really care >

Re: [PATCH] Handle __builtin_unreachable () using assertions in VRP

2013-11-03 Thread Tom de Vries
On 29/10/13 14:54, Jakub Jelinek wrote: > +/* Return true if all imm uses of VAR are either in STMT, or > + feed (optionally through a chain of single imm uses) GIMPLE_COND > + in basic block COND_BB. */ > + > +static bool > +all_imm_uses_in_stmt_or_feed_cond (tree var, gimple stmt, basic_bloc

Re: [PATCH] Handle __builtin_unreachable () using assertions in VRP

2013-11-04 Thread Tom de Vries
On 04/11/13 01:59, Tom de Vries wrote: > On 29/10/13 14:54, Jakub Jelinek wrote: >> +/* Return true if all imm uses of VAR are either in STMT, or >> + feed (optionally through a chain of single imm uses) GIMPLE_COND >> + in basic block COND_BB. */

Re: [committed] Add oacc_kernels_p argument to pass_parallelize_loops

2016-01-20 Thread Tom de Vries
On 20/01/16 09:54, Thomas Schwinge wrote: Hi! On Mon, 18 Jan 2016 14:07:11 +0100, Tom de Vries wrote: Add oacc_kernels_p argument to pass_parallelize_loops --- a/gcc/tree-parloops.c +++ b/gcc/tree-parloops.c @@ -2315,6 +2367,9 @@ gen_parallel_loop (struct loop *loop, | /* Ensure

[gomp4, committed] Remove reduction clauses in kernels region earlier

2016-01-20 Thread Tom de Vries
Hi, I've committed this patch to gomp-4_0-branch, moving the removal of the reduction clauses in the kernels region earlier, before localize_reductions. Thanks, - Tom Remove reduction clauses in kernels region earlier 2016-01-20 Tom de Vries * gimplify.c (gimplify_omp_for): R

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

2016-01-21 Thread Tom de Vries
On 13/01/16 09:42, Richard Biener wrote: On Tue, 12 Jan 2016, Tom de Vries wrote: On 12/01/16 14:04, Richard Biener wrote: On Tue, 12 Jan 2016, Tom de Vries wrote: On 12/01/16 12:22, Richard Biener wrote: Doesnt' the same issue apply to unsigned int *p; static void __attrib

[PATCH, PR69426] Fix clobber removal in parloops

2016-01-23 Thread Tom de Vries
by the vuse of the clobber. The patch uses replace_uses_by, but unlink_vdef_stmt also works, I'm not sure which one to use. Bootstrapped and reg-tested on x86_64. OK for trunk, gcc-5-branch? Thanks, - Tom Fix clobber removal in parloops 2016-01-23 Tom de Vries PR tree-optimization/

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

2016-01-23 Thread Tom de Vries
On 23/01/16 18:39, Sebastian Pop wrote: diff --git a/gcc/tree-data-ref.c b/gcc/tree-data-ref.c index a40f40d..7ff5db7 100644 --- a/gcc/tree-data-ref.c +++ b/gcc/tree-data-ref.c @@ -1023,6 +1023,10 @@ dr_analyze_indices (struct data_reference *dr, loop_p nest, loop_p loop) build_int_cst (ref

Re: [gomp4, PR68977, Committed] Don't gimplify in ssa mode if seen_error in oacc_xform_loop

2016-01-25 Thread Tom de Vries
On 14/01/16 10:43, Richard Biener wrote: On Wed, Jan 13, 2016 at 9:04 PM, Tom de Vries wrote: Hi, At r231739, there was an ICE when checking code generated by oacc_xform_loop, in case the source contained an error. Due to seen_error (), gimplification during oacc_xform_loop bailed out, and

Re: [PATCH] Fix PR64091

2016-01-25 Thread Tom de Vries
dest->index; bitmap_set_bit (same->succs, index); + e->flags &= ~EDGE_EXECUTABLE; same_succ_edge_flags[index] = e->flags; } EXECUTE_IF_SET_IN_BITMAP (same->succs, 0, j, bj) Backport "Fix PR64091" 2016-01-25 Tom de Vries backport from trun

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

2016-01-26 Thread Tom de Vries
On 24/01/16 09:04, Richard Biener wrote: On January 23, 2016 7:44:23 PM GMT+01:00, Sebastian Pop wrote: On Sat, Jan 23, 2016 at 12:28 PM, Tom de Vries wrote: That was my original patch, and Richard commented: 'I think avoiding a NULL access_fns is ok but it should be done unconditio

Re: [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables

2016-01-26 Thread Tom de Vries
On 25/01/16 14:27, Ilya Verbin wrote: Hi! On Tue, Jan 05, 2016 at 15:56:15 +0100, Tom de Vries wrote: diff --git a/gcc/lto-cgraph.c b/gcc/lto-cgraph.c index 62e5454..cdaee41 100644 --- a/gcc/lto-cgraph.c +++ b/gcc/lto-cgraph.c @@ -1911,6 +1911,11 @@ input_offload_tables (void

[PING^3][PATCH, 12/16] Handle acc loop directive

2016-01-26 Thread Tom de Vries
On 18/01/16 15:27, Tom de Vries wrote: On 24/11/15 13:26, Tom de Vries wrote: On 09/11/15 21:06, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

2016-01-27 Thread Tom de Vries
On 26/01/16 17:59, Sebastian Pop wrote: Tom de Vries wrote: diff --git a/gcc/tree-data-ref.c b/gcc/tree-data-ref.c index a40f40d..4c29fc2 100644 --- a/gcc/tree-data-ref.c +++ b/gcc/tree-data-ref.c @@ -1510,8 +1510,9 @@ initialize_data_dependence_relation (struct data_reference *a, if

Re: [gomp4, PR68977, Committed] Don't gimplify in ssa mode if seen_error in oacc_xform_loop

2016-01-28 Thread Tom de Vries
On 28/01/16 14:32, Richard Biener wrote: On Mon, Jan 25, 2016 at 12:00 PM, Tom de Vries wrote: On 14/01/16 10:43, Richard Biener wrote: On Wed, Jan 13, 2016 at 9:04 PM, Tom de Vries wrote: Hi, At r231739, there was an ICE when checking code generated by oacc_xform_loop, in case the

[PATCH, PR69599] Fix GOMP/GOACC_parallel optimization in ipa-pta

2016-02-08 Thread Tom de Vries
6_64. Build for nvidia accelerator and reg-tested libgomp with various lto settings. OK for trunk, stage4? Thanks, - Tom Fix GOMP/GOACC_parallel optimization in ipa-pta 2016-02-08 Tom de Vries PR tree-optimization/69599 * tree-ssa-structalias.c (fndecl_maybe_in_other_partition

[PATCH, PR59627, c++] Handle DECL_OMP_DECLARE_REDUCTION in discriminator_for_local_entity

2016-02-08 Thread Tom de Vries
mply return '0'. Bootstrapped and reg-tested on x86_64. OK for trunk, stage1? Thanks, - Tom Handle DECL_OMP_DECLARE_REDUCTION in discriminator_for_local_entity 2016-02-08 Tom de Vries PR c++/59627 * mangle.c (discriminator_for_local_entity): Handle DECL_OMP_DECLARE_REDUCTION_P

[PATCH, PR69707] Handle -fdiagnostics-color in lto

2016-02-08 Thread Tom de Vries
Thanks, - Tom Handle -fdiagnostics-color in lto 2016-02-08 Tom de Vries PR lto/69707 * common.opt (fdiagnostics-color=): Remove Driver flag. * lto-wrapper.c (merge_and_complain, append_compiler_options): Handle OPT_fdiagnostics_color_. * testsuite/libgomp.oacc-c-c++-common/parallel-dim

[PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-08 Thread Tom de Vries
->call_cgraph_insertion_hooks (new_node)'. ] Bootstrapped and reg-tested on x86_64. OK for stage1 trunk? Thanks, - Tom Don't call call_cgraph_insertion_hooks in simd_clone_create 2016-02-08 Tom de Vries PR lto/67709 * omp-low.c (simd_clone_create): Remove call t

[PATCH, PR69607] Mark offload symbols as global in lto

2016-02-08 Thread Tom de Vries
. Bootstrapped and reg-tested on x86_64. Build for nvidia accelerator and reg-tested libgomp with various lto settings. OK for trunk, stage1? Thanks, - Tom Mark offload symbols as global in lto 2016-02-08 Tom de Vries PR lto/69607 * lto-partition.c (promote_offload_tables): New function

Re: [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables

2016-02-08 Thread Tom de Vries
On 26/01/16 14:01, Ilya Verbin wrote: On Tue, Jan 26, 2016 at 13:21:57 +0100, Tom de Vries wrote: On 25/01/16 14:27, Ilya Verbin wrote: On Tue, Jan 05, 2016 at 15:56:15 +0100, Tom de Vries wrote: diff --git a/gcc/lto-cgraph.c b/gcc/lto-cgraph.c index 62e5454..cdaee41 100644 --- a/gcc/lto

Re: [PATCH, PR69707] Handle -fdiagnostics-color in lto

2016-02-08 Thread Tom de Vries
On 08/02/16 11:42, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 11:34:39AM +0100, Tom de Vries wrote: Hi, when running libgomp.oacc-c-c++-common/parallel-dims.c with -flto -fno-use-linker-plugin, we run into a failing 'test for excess errors'. The problem is that while -fdiagnos

Re: [PATCH, PR69707] Handle -fdiagnostics-color in lto

2016-02-08 Thread Tom de Vries
On 08/02/16 14:54, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 02:38:17PM +0100, Tom de Vries wrote: hmm, indeed removing the 'Driver' flag from the fdiagnostics-color= entry in common.opt breaks the functioning of fdiagnostics-color= in the gcc driver. This patch leaves the &#x

Re: [PATCH, PR69599] Fix GOMP/GOACC_parallel optimization in ipa-pta

2016-02-08 Thread Tom de Vries
On 08/02/16 11:54, Richard Biener wrote: On Mon, 8 Feb 2016, Tom de Vries wrote: Hi, when compiling the fipa-pta tests in the libgomp testsuite (omp-nested-2.c, pr46032.c) with -flto -flto-partition=max, the tests fail in execution (PR69599). The problem is related to the GOMP/GOACC_parallel

Re: [PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-10 Thread Tom de Vries
On 10/02/16 17:55, Dominique d'Humières wrote: The patch fixes the PR on x86_64-apple-darwin15. OK for stage1 trunk? What it the reason to delay the fix for a couple of months? We're in stage4 ( https://gcc.gnu.org/ml/gcc/2016-01/msg00168.html ): ... trunk is in regression and documentati

Re: [PING^3][PATCH, 12/16] Handle acc loop directive

2016-02-12 Thread Tom de Vries
On 26/01/16 13:49, Jakub Jelinek wrote: On Tue, Jan 26, 2016 at 01:38:39PM +0100, Tom de Vries wrote: Ping^3. ( https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01089.html ) First of all, I wonder if it wouldn't be far easier to handle these during gimplification rather than during omp expa

[RFC, PR68580] Handle pthread_create error in tsan testsuite

2016-02-14 Thread Tom de Vries
d with"); \ exit (0); \ } \ } ... If this patch is committed, I should at least be able to find out if indeed the failure I observe is related to resource exhaustion. Good idea? Any other comments? Thanks, - Tom Handle pthread_create err

[PING][PATCH] Don't mark offload symbols with force_output in ltrans

2016-02-14 Thread Tom de Vries
[ was: [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables ] On 08/02/16 14:20, Tom de Vries wrote: On 26/01/16 14:01, Ilya Verbin wrote: On Tue, Jan 26, 2016 at 13:21:57 +0100, Tom de Vries wrote: On 25/01/16 14:27, Ilya Verbin wrote: On Tue, Jan 05, 2016

Re: [RFC, PR68580] Handle pthread_create error in tsan testsuite

2016-02-15 Thread Tom de Vries
On 15/02/16 08:24, Dmitry Vyukov wrote: If we are talking about pr 68580, then I would try: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68580#c2 first. As I tried to explain in the follow-up comment ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68580#c3 ), since unfortunately I have no reli

[PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-15 Thread Tom de Vries
On 08/02/16 13:54, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 01:46:44PM +0100, Tom de Vries wrote: [ The pass before pass_omp_simd_clone is pass_dispatcher_calls. It has a function create_target_clone, similar to simd_clone_create, with a node.defition and !node.defition part. The

Re: [RFC, PR68580] Handle pthread_create error in tsan testsuite

2016-02-15 Thread Tom de Vries
On 15/02/16 10:07, Bernd Edlinger wrote: On 15/02/16 09:07, Tom de Vries wrote: >>On 15/02/16 08:24, Dmitry Vyukov wrote: >> >>If we are talking about pr 68580, then I would try: >>https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68580#c2 >>first. > >

Re: Use plain -fopenacc to enable OpenACC kernels processing

2016-02-15 Thread Tom de Vries
6 13:06:17 +0100, I wrote: On Mon, 9 Nov 2015 18:39:19 +0100, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. Atm, the paral

Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-16 Thread Tom de Vries
On 16/02/16 03:22, Jan Hubicka wrote: On 08/02/16 13:54, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 01:46:44PM +0100, Tom de Vries wrote: [ The pass before pass_omp_simd_clone is pass_dispatcher_calls. It has a function create_target_clone, similar to simd_clone_create, with a node.defition

Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-16 Thread Tom de Vries
On 16/02/16 11:04, Jakub Jelinek wrote: On Tue, Feb 16, 2016 at 10:56:58AM +0100, Tom de Vries wrote: >AFAIU, it's not a release regression given that: >- this has failed since 4.9.0, and >- the test-case is not supported in 4.8, >so we're not required to fix it in 4.9

Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-16 Thread Tom de Vries
On 16/02/16 12:11, Jakub Jelinek wrote: On Tue, Feb 16, 2016 at 12:10:29PM +0100, Tom de Vries wrote: >On 16/02/16 11:04, Jakub Jelinek wrote: > >On Tue, Feb 16, 2016 at 10:56:58AM +0100, Tom de Vries wrote: > >>>AFAIU, it's not a release regression given that: &g

Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

2016-02-16 Thread Tom de Vries
On 16/02/16 17:54, Jakub Jelinek wrote: On Tue, Feb 16, 2016 at 05:52:55PM +0100, Tom de Vries wrote: Committed both patches to 4.9 and 5 branches. In order to run testsuite/libgomp.fortran/declare-simd-4.f90 with the 4.9 branch build, I needed in addition: - r212268 https://gcc.gnu.org

Re: [PATCH] Fix driver handling of multiple -ftree-parallelize-loops= options (PR driver/69805)

2016-02-16 Thread Tom de Vries
string, 'X' is substituted. %:gt(%{fsome-option-value=*:%*} 1) ... OK for stage4 trunk? Thanks, - Tom Add documentation for spec function gt in invoke.texi 2016-02-16 Tom de Vries * doc/invoke.texi (@node Spec Files): Document spec function gt. --- gcc

Re: [PATCH, PR69607] Mark offload symbols as global in lto

2016-02-17 Thread Tom de Vries
On 08/02/16 14:00, Tom de Vries wrote: Hi, when running libgomp.c testsuite with "-flto -flto-partition=1to1 -fno-toplevel-reorder" we run into many compilation failures like this: ... /tmp/.ltrans0.ltrans.o:(.gnu.offload_funcs+0x1a0): undefined reference to `MAIN__._o

[PATCH] Add debug_function_to_file

2016-02-17 Thread Tom de Vries
... (gdb) call debug_function_to_file (cfun.decl, "foo.1.txt", 0) ... Hmm, now I wonder if the order 'cfun.decl, 0, "foo.1.txt"' would make more sense (first two parameters the same as in debug_function). OK for stage1 trunk if bootstrap and reg-test succeeds? Thanks, - Tom A

[PATCH] Add debug_function_graph_to_file

2016-02-17 Thread Tom de Vries
... (gdb) call debug_function_graph_to_file (cfun.decl, "foo.1.dot") ... [ I'll post a follow-up WIP patch that adds the flags parameter. ] OK for stage1 trunk if bootstrap and reg-test succeeds? Thanks, - Tom Add debug_function_graph_to_file 2016-02-17 Tom de Vries

Re: [PATCH] Add debug_function_to_file

2016-02-17 Thread Tom de Vries
On 17/02/16 14:42, Richard Biener wrote: On Wed, Feb 17, 2016 at 1:41 PM, Tom de Vries wrote: >Hi, > >once in a while I'm in a gdb debug session debugging cc1, and want to print >the current function to file. > >There's a debug function debug_function that print

Re: [PATCH, PR69607] Mark offload symbols as global in lto

2016-02-17 Thread Tom de Vries
On 17/02/16 13:30, Jakub Jelinek wrote: On Wed, Feb 17, 2016 at 01:02:17PM +0100, Tom de Vries wrote: Mark offload symbols as global in lto I'm really not familiar with that part of LTO, so I'm CCing Honza and Richard here. 2016-02-08 Tom de Vries PR lto/69607

Re: [PATCH] Fix driver handling of multiple -ftree-parallelize-loops= options (PR driver/69805)

2016-02-18 Thread Tom de Vries
On 17/02/16 17:07, Sandra Loosemore wrote: On 02/17/2016 12:14 AM, Tom de Vries wrote: Here's the documentation entry for the gt spec function (I forgot to add it when introducing the function), using the new semantics. Copy-pasting from the resulting .info viewed in emacs for a

Re: [PATCH] Fix driver handling of multiple -ftree-parallelize-loops= options (PR driver/69805)

2016-02-18 Thread Tom de Vries
On 16/02/16 16:24, Jakub Jelinek wrote: Passing the - and ftree-parallelize-loops= stuff looks weird, and we have %* that substitutes just the variable part of the option, so in addition to fixing the case of multiple options I've also changed %:gt() behaviour, so that it now gets just the number

Re: [RFC, PR68580] Handle pthread_create error in tsan testsuite

2016-02-18 Thread Tom de Vries
On 15/02/16 12:29, Bernd Edlinger wrote: Here is a patch that puts each value on it's own 8-byte aligned memory location. From my experience with tsan tests, sharing shadow memory slots between v and q or o is the most likely explanation for the occasional inability to spot the race condition on

Re: [PATCH] Add debug_function_to_file

2016-02-18 Thread Tom de Vries
On 17/02/16 14:42, Richard Biener wrote: On Wed, Feb 17, 2016 at 1:41 PM, Tom de Vries wrote: Hi, once in a while I'm in a gdb debug session debugging cc1, and want to print the current function to file. There's a debug function debug_function that prints a function to stderr, and

Re: [PATCH] Add debug_function_to_file

2016-02-18 Thread Tom de Vries
On 18/02/16 16:10, Richard Biener wrote: On Thu, Feb 18, 2016 at 3:29 PM, Tom de Vries wrote: >On 17/02/16 14:42, Richard Biener wrote: >> >>On Wed, Feb 17, 2016 at 1:41 PM, Tom de Vries >>wrote: >>> >>>Hi, >>> >>>once in a while I

Re: [PATCH] Add debug_function_to_file

2016-02-18 Thread Tom de Vries
On 18/02/16 16:27, Richard Biener wrote: I would be nice if we could avoid the ${1,2,3} printouts and value >>> >history >>> >assignments, but I'm not sure how to do that. >>> > Using gdb.parse_and_eval does the trick. This updated version uses gdb.parse_and_eval, and adds error handling.

Re: [PATCH] Add debug_function_to_file

2016-02-18 Thread Tom de Vries
argument to dump_bb_for_graph. I ran out of steam at rtl_dump_bb_for_graph, and resorted to the same save-restore dump_flags trick, although it felt a bit hacky to me. Thanks, - Tom Use flags parameter to debug_function_graph_to_file 2016-02-17 Tom de Vries * cfghooks.c (dump_bb_for_graph): Add

Re: [PATCH] Add debug_function_to_file

2016-02-18 Thread Tom de Vries
On 18/02/16 16:43, Tom de Vries wrote: On 18/02/16 16:27, Richard Biener wrote: I would be nice if we could avoid the ${1,2,3} printouts and value >>> >history >>> >assignments, but I'm not sure how to do that. >>> > Using gdb.parse_and_eval doe

Re: [PATCH] Add debug_function_to_file

2016-02-18 Thread Tom de Vries
On 18/02/16 16:27, Richard Biener wrote: Attached is what I have for now, it works if you call it like (gdb) dot-fn cfun (gdb) dot-fn cfun, 1<<6 w/o that arg parsing;) I'll play with it some more tomorrow. This version: - uses arg parsing - adds error handling - uses a temp file instead of a

Re: [PATCH] Add debug_function_to_file

2016-02-19 Thread Tom de Vries
On 18/02/16 20:41, David Malcolm wrote: On Thu, 2016-02-18 at 18:26 +0100, Tom de Vries wrote: On 18/02/16 16:43, Tom de Vries wrote: On 18/02/16 16:27, Richard Biener wrote: I would be nice if we could avoid the ${1,2,3} printouts and value history assignments, but I'm not sure how

Re: [PATCH] Add debug_function_to_file

2016-02-19 Thread Tom de Vries
On 19/02/16 10:44, Richard Biener wrote: On Fri, Feb 19, 2016 at 1:37 AM, Tom de Vries wrote: On 18/02/16 16:27, Richard Biener wrote: Attached is what I have for now, it works if you call it like (gdb) dot-fn cfun (gdb) dot-fn cfun, 1<<6 w/o that arg parsing;) I'll play with i

[RFC] Add contrib/fix-ChangeLog.sh

2016-02-20 Thread Tom de Vries
Hi, this patch adds a script contrib/fix-ChangeLog.sh. It fixes whitespace issues, and shows ChangeLog lines that look suspicious. Using the script, I was able to find a stray changelog entry (removed in rr233583, https://gcc.gnu.org/viewcvs?rev=233583&root=gcc&view=rev ). And I've Any comm

Re: [RFC] Add contrib/fix-ChangeLog.sh

2016-02-20 Thread Tom de Vries
On 20/02/16 15:04, Tom de Vries wrote: Hi, this patch adds a script contrib/fix-ChangeLog.sh. It fixes whitespace issues, and shows ChangeLog lines that look suspicious. Using the script, I was able to find a stray changelog entry (removed in rr233583, https://gcc.gnu.org/viewcvs?rev=233583

Re: [PING^3][PATCH, 12/16] Handle acc loop directive

2016-02-22 Thread Tom de Vries
On 12/02/16 12:10, Tom de Vries wrote: On 26/01/16 13:49, Jakub Jelinek wrote: On Tue, Jan 26, 2016 at 01:38:39PM +0100, Tom de Vries wrote: Ping^3. ( https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01089.html ) First of all, I wonder if it wouldn't be far easier to handle these d

Re: [PATCH][RFC][Offloading] Fix PR68463

2016-02-22 Thread Tom de Vries
On 22/02/16 19:07, Ilya Verbin wrote: 2016-02-22 18:13 GMT+03:00 Thomas Schwinge: >On Sat, 20 Feb 2016 13:54:20 +0300, Ilya Verbin wrote: >>On Fri, Feb 19, 2016 at 15:53:08 +0100, Jakub Jelinek wrote: >> >On Wed, Feb 10, 2016 at 08:19:34PM +0300, Ilya Verbin wrote: >> > >This patch adds crto

[PING][PATCH, PR69607] Mark offload symbols as global in lto

2016-02-24 Thread Tom de Vries
On 17/02/16 16:48, Tom de Vries wrote: On 17/02/16 13:30, Jakub Jelinek wrote: On Wed, Feb 17, 2016 at 01:02:17PM +0100, Tom de Vries wrote: Mark offload symbols as global in lto I'm really not familiar with that part of LTO, so I'm CCing Honza and Richard here. 2016-02-08 To

Re: [patch, fortran] PR69110 ICE with NEWUNIT

2016-02-27 Thread Tom de Vries
On 25-02-16 01:54, Jerry DeLisle wrote: This patch from Steve on c.l.f Fixes the segfault from attempting a string compare where there is no string yet. Regression tested on x86-64. New test case. OK for trunk. Regards, Jerry 2016-02-24 Jerry DeLisle Steven G. Kargl

Re: [PING^3][PATCH, 12/16] Handle acc loop directive

2016-02-28 Thread Tom de Vries
On 22-02-16 11:57, Jakub Jelinek wrote: On Mon, Feb 22, 2016 at 11:54:46AM +0100, Tom de Vries wrote: Following up on your suggestion to implement this during gimplification, I wrote attached patch. I'll put it through some openacc testing and add testcases. Is this approach acceptabl

[PATCH, PR68659] Handle addr_expr and component_ref in graphite-ast-to-ast

2016-03-01 Thread Tom de Vries
failing test-case gcc.dg/graphite/id-pr45230-1.c to pass. Bootstrapped and reg-tested on x86_64. OK for stage4 trunk? Thanks, - Tom Handle addr_expr and component_ref in graphite-ast-to-ast 2016-03-01 Tom de Vries PR tree-optimization/68659 * graphite-isl-ast-to-gimple.c

Re: [Ada] Fix unexpectedly large frame with calls manipulating strings

2016-03-01 Thread Tom de Vries
On 29-02-16 10:17, Eric Botcazou wrote: Another long-standing regression present in the compiler (dating back to the Tree-SSA merge): the compiler generates code that has an unexpectedly large stack usage for nested calls on strings, because the gimplifier creates temporaries in the outermost sco

[PATCH] Handle oacc region in oacc routine

2016-03-01 Thread Tom de Vries
, ran goacc.exp regression test. OK for stage4 trunk, if complete bootstrap/reg-test succeeds? Thanks, - Tom Handle oacc region in oacc routine 2015-10-16 Tom de Vries * omp-low.c (check_omp_nesting_restrictions): Check for oacc region in oacc routine. * c-c++-common/goacc/nesting-fail-1.c (f_ac

Re: [PATCH, PR68659] Handle addr_expr and component_ref in graphite-ast-to-ast

2016-03-02 Thread Tom de Vries
On 01-03-16 10:45, Richard Biener wrote: On Tue, 1 Mar 2016, Tom de Vries wrote: Hi, this patch fixes graphite PR68659, which is a 6 regression. The patch fixes two things: - by handling new_expr == NULL_TREE in collect_all_ssa_names, it handles a COMPONENT_REF where operand 2 is

Re: [PATCH] Handle oacc region in oacc routine

2016-03-02 Thread Tom de Vries
On 01-03-16 12:37, Jakub Jelinek wrote: On Tue, Mar 01, 2016 at 06:24:58PM +0100, Tom de Vries wrote: --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -3715,6 +3715,14 @@ check_omp_nesting_restrictions (gimple *stmt, omp_context *ctx) kind == OMP_CLAUSE_DEPEND_SOURCE ? "s

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-11-26 Thread Tom de Vries
On 26-11-13 11:12, Richard Biener wrote: On Tue, Nov 26, 2013 at 8:57 AM, Tom de Vries wrote: Jason, This patch prevents creating out-of-bounds BIT_FIELD_REFs in 3 locations. It fixes a SIGSEGV (triggered by gimple_fold_indirect_ref_1) in simplify_bitfield_ref. I've added an assert to d

Re: [PATCH] Handle vector increment/decrement in build_unary_op

2013-11-27 Thread Tom de Vries
On 27-11-13 01:21, Jason Merrill wrote: On 11/26/2013 03:47 AM, Marc Glisse wrote: On Tue, 26 Nov 2013, Tom de Vries wrote: * g++.dg/pr59032.C: New testcase. * gcc.dg/pr59032.c: Same. I didn't check very carefully, but they look similar. If they are indeed the same, could it mo

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-11-27 Thread Tom de Vries
On 27-11-13 07:20, Jeff Law wrote: On 11/26/13 14:10, Tom de Vries wrote: On 26-11-13 11:12, Richard Biener wrote: On Tue, Nov 26, 2013 at 8:57 AM, Tom de Vries wrote: Jason, This patch prevents creating out-of-bounds BIT_FIELD_REFs in 3 locations. It fixes a SIGSEGV (triggered by

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-12-03 Thread Tom de Vries
On 03-12-13 13:49, Jakub Jelinek wrote: On Thu, Nov 28, 2013 at 12:23:43AM +0100, Tom de Vries wrote: Committed to trunk. Also ok for 4.8 branch? It's a 4.8/4.9 regression. Ok, but I guess you need to adjust your patch for 4.8 (tree_to_* and tree_fits_* to host_integerp/tree_low_cst

Re: [PATCH][10/10] -fuse-caller-save - Add test-case

2013-12-05 Thread Tom de Vries
On 27-04-13 12:01, Richard Sandiford wrote: Tom de Vries writes: +/* { dg-do run } */ +/* { dg-options "-fuse-caller-save -save-temps" } */ +/* { dg-skip-if "" { *-*-* } { "*" } { "-Os" } } */ +/* Testing -fuse-caller-save optimization option. */ + +s

Re: [PATCH][IRA] Analysis of register usage of functions for usage by IRA.

2013-12-05 Thread Tom de Vries
On 14-03-13 10:34, Tom de Vries wrote: I thought about implementing your optimization for LRA by myself. But it >is ok if you decide to work on it. At least, I am not going to start >this work for a month. >>I'm also currently looking at how to use the analysis in LRA

Re: [PATCH][05/10] -fuse-caller-save - Implement TARGET_FN_OTHER_HARD_REG_USAGE hook for ARM

2013-12-05 Thread Tom de Vries
On 30-03-13 18:11, Tom de Vries wrote: Richard, This patch series adds analysis of register usage of functions for usage by IRA. The original post is here ( http://gcc.gnu.org/ml/gcc-patches/2013-01/msg01234.html ). This patch implements the target hook TARGET_FN_OTHER_HARD_REG_USAGE for ARM

Re: [PATCH][07/10] -fuse-caller-save - Use collected register usage information

2013-12-05 Thread Tom de Vries
On 30-03-13 18:11, Tom de Vries wrote: Paolo, This patch series adds analysis of register usage of functions for usage by IRA. The original post is here ( http://gcc.gnu.org/ml/gcc-patches/2013-01/msg01234.html ). This patch uses the information of which registers are clobbered by a call in

[PATCH] -fuse-caller-save - Implement TARGET_FN_OTHER_HARD_REG_USAGE hook for MIPS

2013-12-07 Thread Tom de Vries
-11-12 Chung-Lin Tang Tom de Vries * config/mips/mips.c (POST_CALL_TMP_REG): Define. (mips_split_call): Use POST_CALL_TMP_REG. (mips_fn_other_hard_reg_usage): New function. (TARGET_FN_OTHER_HARD_REG_USAGE): Define targhook using new function. diff --git a/gcc/config/mips/mips.c

Re: question about REG_PARM_STACK_SPACE usage in expand_call

2013-12-14 Thread Tom de Vries
d. Bootstrapped and reg-tested attached patch on x86_64. Committed to trunk. Thanks, - Tom jeff 2013-12-14 Tom de Vries * calls.c (expand_call): Fix REG_PARM_STACK_SPACE comparison. diff --git a/gcc/calls.c b/gcc/calls.c index 2226e78..501474b 100644 --- a/gcc/calls.c +++ b/gcc/calls.c @@ -2595,

<    1   2   3   4   5   6   7   8   9   10   >