Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-08-29 Thread Elle Stone
If anyone would like to try the lcms2 high bit depth plug-in, I put up instructions on compiling Gimp from git and the lcms2 plug-in, plus babl and gegl, with the modified babl/babl/util.h file: http://ninedegreesbelow.com/temp/gimp-lcms-6.html -- http://ninedegreesbelow.com Articles and tutori

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-08-28 Thread Elle Stone
On 8/27/12, Øyvind Kolås wrote: > On Mon, Aug 27, 2012 at 4:08 PM, Elle Stone wrote: >> My lcms2 plug-in now does do correct ICC profile conversions, from any >> RGB color space, to any RGB color space, at 8-bit integer, 16-bit >> integer, and 32-bit floating point. >> >> However, to get it to w

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-08-27 Thread Øyvind Kolås
On Mon, Aug 27, 2012 at 4:08 PM, Elle Stone wrote: > My lcms2 plug-in now does do correct ICC profile conversions, from any > RGB color space, to any RGB color space, at 8-bit integer, 16-bit > integer, and 32-bit floating point. > > However, to get it to work, I had to modify the babl/babl/util.h

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-08-27 Thread Elle Stone
My lcms2 plug-in now does do correct ICC profile conversions, from any RGB color space, to any RGB color space, at 8-bit integer, 16-bit integer, and 32-bit floating point. However, to get it to work, I had to modify the babl/babl/util.h file. After modifying the babl/babl/util.h file, 16-bit tif

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-08-14 Thread Elle Stone
On 8/13/12, Elle Stone wrote: > Upon converting to any other ICC profile, the colors come out all wrong > . . . then the colors are magically right. Which is both bizarre and wrong. A coding error/oversight on my part is the answer to the "magically right": the new profile is embedded even if the

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-08-13 Thread Elle Stone
I posted an update to my effort to port the lcms plugin to lcms2 and get it to do high-bit-depth color conversions: http://ninedegreesbelow.com/temp/gimp-lcms-4.html Summary of current state of plugin: It uses lcms2. It does high bit depth conversions, but some options are not available yet. It

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-26 Thread Elle Stone
On 7/24/12, Michael Schumacher wrote: > there are two bug reports in Bugzilla about changes in GIMP related to > lcms2: > > This one introduces lcms2 to get support for ICC V4 profiles: > https://bugzilla.gnome.org/show_bug.cgi?id=662739 > > > That one has been created to move everything to lcms2

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-25 Thread Burnie West
On 07/25/2012 05:25 AM, Elle Stone wrote: It always surprises me how few people are working on a project as big, important, and widely used as Gimp. I'd love to work on it, but I can't keep up with the starting point :-) ___ gimp-developer-list maili

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-25 Thread Alexandre Prokoudine
On Wed, Jul 25, 2012 at 4:25 PM, Elle Stone wrote: > On a related note, I reported a bug back in 2010: > https://bugzilla.gnome.org/show_bug.cgi?id=620781 (I changed my > website domain, the link I gave in the bug report is no longer > available). That bug still persists in Gimp 2.8/2.9 if the sRG

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-25 Thread Elle Stone
>So please, just go ahead, look at the patches in bugzilla, pick the >best stuff from your patches and the bugzilla ones, and all will be >fine. OK, I'm working on it. And I promise to keep communicating actively. I'm making two Gimp from git installations, one for the existing lcms2 patches (than

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-25 Thread Michael Natterer
On Tue, 2012-07-24 at 17:37 -0400, Elle Stone wrote: > Perhaps what I really should be asking is what is the process by which > an existing patch to the Gimp code is applied so that everyone can use > it? Your way of doing patches *and* actively communicating is the only way that will guarantee yo

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Burnie West
This is beautiful, Jernej - I've moved this entire conversation to my gimp-developer/coding help subdirectory. Thanks. On 07/24/2012 02:58 PM, Jernej Simončič wrote: On Tuesday, July 24, 2012, 23:37:16, Elle Stone wrote: In particular, by what process does Gimp get patched to use lcms2? ( I

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Elle Stone
Jernej, thanks! That is a very clear explanation of how to use patch. -- http://ninedegreesbelow.com Articles and tutorials on open source digital imaging and photography ___ gimp-developer-list mailing list gimp-developer-list@gnome.org https://mail.gn

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Jernej Simončič
On Tuesday, July 24, 2012, 23:37:16, Elle Stone wrote: > In particular, by what process does Gimp get patched to use lcms2? ( I > kinda doubt that the Gimp developers are going to let Elle Stone patch > Gimp, as the chances are very great that Elle Stone would break Gimp > in the process.) If you

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Elle Stone
Perhaps what I really should be asking is what is the process by which an existing patch to the Gimp code is applied so that everyone can use it? In particular, by what process does Gimp get patched to use lcms2? ( I kinda doubt that the Gimp developers are going to let Elle Stone patch Gimp, as t

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Michael Schumacher
On 24.07.2012 23:16, Elle Stone wrote: How does one apply a patch? What does "apply a patch" mean? You use the patch program to apply the changes that are contained in the attachments to the bug report to the GIMP code. The usage example from the Wikipedia article about patch should do: htt

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Elle Stone
How does one apply a patch? What does "apply a patch" mean? On 7/24/12, Michael Schumacher wrote: > On 24.07.2012 23:00, Elle Stone wrote: > >> may I ask why the Gimp from git that I'm using (which is really >> recent, July 13, 2012) is still using lcms1 if there are patches for >> lcms2? > > Bec

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Michael Schumacher
On 24.07.2012 23:00, Elle Stone wrote: may I ask why the Gimp from git that I'm using (which is really recent, July 13, 2012) is still using lcms1 if there are patches for lcms2? Because no one has tried and applied the patches yet. HTH, Michael __

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Elle Stone
Yes, it looks like both of them are concerned with exactly what I've been trying to do. Sigh. As I'm working with Gimp 2.9 from git, and have no clue how Gimp development works, and only got involved because I really want Gimp color conversion to use high bit-depth, and my impression was that mak

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Michael Schumacher
On 24.07.2012 17:47, Elle Stone wrote: Just an update. I rewrote the existing Gimp lcms.c plug-in to use lcm2. It seems to work just like the current Gimp plug-in. If anyone is interested in testing it, I can supply the code. Also, has anyone seen this Ubuntu bug report? Completely replace lc

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-24 Thread Elle Stone
On 7/20/12, Elle Stone wrote: > On 7/20/12, Øyvind Kolås wrote: >> As we move along towards embracing a fully GEGLified workflow, >> different things will happen at different times. The initial thing to >> reach for is likely to support the 2.8 era manual colormanagement. >> With a fully GEGLifie

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-20 Thread Elle Stone
On 7/20/12, Øyvind Kolås wrote: > As we move along towards embracing a fully GEGLified workflow, > different things will happen at different times. The initial thing to > reach for is likely to support the 2.8 era manual colormanagement. > With a fully GEGLified system there will still be the need

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-20 Thread Øyvind Kolås
On Fri, Jul 20, 2012 at 11:46 PM, Elle Stone wrote: > Hi, John, > By "native space" do you mean whatever color space the image > 1. Is my > impression correct? Is Gimp planning to use a very large > internal working space for all image manipulation? If the answer is > "No", ignore questions 2, 3,

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-20 Thread Elle Stone
Hi, John, By "native space" do you mean whatever color space the image happens to be in when you open it? As per the jpegs generated by my point-and-shoot are all in the sRGB color space? Or if someone hands me a file in the AdobeRGB color space, then that file's "native" color space is AdobeRGB?

Re: [Gimp-developer] the Gimp lcms.c plug-in

2012-07-19 Thread John Harris
Elle, I am not a programmer but I am a color professional. so here is my input regarding your last question: > It seems to me that you will always need ICC profiles, to convert an image from whatever ICC color space profile it happens to be in, to your internal working space, and from your intern

[Gimp-developer] the Gimp lcms.c plug-in

2012-07-19 Thread Elle Stone
I've been working on porting the Gimp lcms.c plug-in from using LittleCMS version 1 to using LittleCMS version 2. This will make possible high bit-depth ICC profile conversions. I'm not a super-experienced c-coder, nor have I ever worked with the lcms engine before. So I'm learning as I go. So far