On Thu, Jun 4, 2015 at 8:38 PM, Allen Hubbe wrote:
> On Thu, Jun 4, 2015 at 6:53 PM, Remi Lespinet
> wrote:
>> On Thu, Jun 4, 2015 at 1:17 PM, Remi LESPINET
>> wrote:
>>>
>>> Hi,
>>>
>>> Working on git-send-email, I've seen that there&#
On Thu, Jun 4, 2015 at 6:53 PM, Remi Lespinet
wrote:
> On Thu, Jun 4, 2015 at 1:17 PM, Remi LESPINET
> wrote:
>>
>> Hi,
>>
>> Working on git-send-email, I've seen that there's no aliases support
>> when manually adding a recipient in a 'To' or 'Cc' field in a patch
>> and for the --to-cmd and --c
This looks good.
On Mon, Jun 1, 2015 at 2:22 PM, Eric Sunshine wrote:
> On Mon, Jun 01, 2015 at 07:43:08AM -0400, Allen Hubbe wrote:
>> On May 31, 2015 at 6:29 PM, Eric Sunshine wrote:
>> > Sendmail aliases[1] supports expansion to a file ("/path/name") or
>&g
This series looks very good to me. Thanks for the extra work you've
done to make the sendmail alias support much better :)
I'm not too concerned about this, but if you think it would be
appropriate you may use it:
Acked-by: Allen Hubbe
On Sun, May 31, 2015 at 6:29 PM, Eric Sunsh
According to the documentation, the parser should print a warning for
any explicitly unsupported constructs. These are now explicitly
unsupported, so the parser should warn on |, /, and :include: .
Perhaps the lines that match should be ignored like the others, too.
On Sun, May 31, 2015 at 6:29 P
, chloe, Other
Quoted aliases and quoted addresses are not supported.
Line continuations are not supported.
Warnings are printed for explicitly unsupported constructs, and any
other lines that are not matched by the parser.
Signed-off-by: Allen Hubbe
---
Notes:
This v6 makes the following
On Tue, May 26, 2015 at 4:53 PM, Eric Sunshine wrote:
> On Tue, May 26, 2015 at 3:41 PM, Allen Hubbe wrote:
>> On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine
>> wrote:
>>> On Saturday, May 23, 2015, Allen Hubbe wrote:
>>>> + # rec
On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine wrote:
> On Saturday, May 23, 2015, Allen Hubbe wrote:
>> Note that this only adds support for a limited subset of the sendmail
>> format. The format is is as follows.
>>
>> : [, ...]
>>
>> Aliases are
On Mon, May 25, 2015 at 9:58 PM, Junio C Hamano wrote:
> Allen Hubbe writes:
>
>> Thanks for letting me know. Are you still expecting v6 from me then?
>> The other thing you asked for was a change in the documentation: just
>> mention the email programs' do
On Mon, May 25, 2015 at 5:35 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Junio C Hamano writes:
>>
>> FYI, I have tentatively queued this on top of your patch. Please
>> see "git log master..cf954075" to double check.
>
> Sorry but I had a typo there...
>
>> git format-patch -
On Sat, May 23, 2015 at 6:24 PM, Allen Hubbe wrote:
> On Sat, May 23, 2015 at 2:07 PM, Junio C Hamano wrote:
>> Junio C Hamano writes:
>>
>>> A small thing I noticed in the test (and this patch is not adding a
>>> new "breakage"---there are a few exi
On Sat, May 23, 2015 at 2:00 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>>> diff --git a/Documentation/git-send-email.txt
>>> b/Documentation/git-send-email.txt
>>> index 804554609def..97387fd27a8d 100644
>>> --- a/Documentation/git-send-email.txt
>>> +++ b/Documentation/git-send-email
On Sat, May 23, 2015 at 2:07 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> A small thing I noticed in the test (and this patch is not adding a
>> new "breakage"---there are a few existing instances) is the use of
>> "~/"; it should be spelled "$HOME/" instead for portability (not in
>>
loe, Other
Unlike the standard sendmail format, this does not support quoted
aliases or quoted addresses. Line continuations are not supported.
Warnings are printed for explicitly unsupported constructs, and any
other lines that are not recognized.
Signed-off-by: Allen Hubbe
---
Notes:
This v5 r
On Fri, May 22, 2015 at 1:17 PM, Junio C Hamano wrote:
> Allen Hubbe writes:
>
>> On Fri, May 22, 2015 at 10:44 AM, Junio C Hamano wrote:
>>
>>> Let me step back a bit. Earlier you said your aim is not to use an
>>> alias file you already have and
On Fri, May 22, 2015 at 12:53 PM, Eric Sunshine wrote:
> On Fri, May 22, 2015 at 8:12 AM, Allen Hubbe wrote:
>> On Fri, May 22, 2015 at 12:29 AM, Eric Sunshine
>> wrote:
>>> On Thu, May 21, 2015 at 11:40 PM, Allen Hubbe wrote:
>>>> +If the format is &#x
On Fri, May 22, 2015 at 10:44 AM, Junio C Hamano wrote:
> Allen Hubbe writes:
>
>> It depends what we want to do with this parser: accept existing
>> sendmail aliases files in git, or enforce that git alias files are
>> usable for sendmail. I really don't exp
On Thu, May 21, 2015 at 11:59 PM, Eric Sunshine wrote:
> On Thu, May 21, 2015 at 11:19 PM, Allen Hubbe wrote:
>> On May 21, 2015 9:05 PM, "Eric Sunshine" wrote:
>>> On Thu, May 21, 2015 at 8:16 PM, Allen Hubbe wrote:
>>> > +test_expect_success
On Fri, May 22, 2015 at 12:29 AM, Eric Sunshine wrote:
> On Thu, May 21, 2015 at 11:40 PM, Allen Hubbe wrote:
>> This format is more simple than the other alias file formats, so it may
>> be preferred by some users. [...]
>> Signed-off-by: Allen Hubbe
>> ---
>&g
bcgrp: bob, chloe, Other
Signed-off-by: Allen Hubbe
---
Notes:
Note, v3 was sent in error. This v4 presents changes since v2.
This v4 extends the syntax to allow blank lines, and comments. The test
case is extended with comments added to alias file input.
The Documentatio
Please ignore v3... this is the same as v2 for some reason. I will
resend as v4.
On Thu, May 21, 2015 at 11:35 PM, Allen Hubbe wrote:
> This format is more simple than the other alias file formats, so it may
> be preferred by some users. The format is as f
bcgrp: bob, chloe, Other
Signed-off-by: Allen Hubbe
---
Notes:
This v3 extends the syntax to allow blank lines, and comments. The test
case is extended with comments added to alias file input.
The Documentation/git-send-email.txt is updated with a description of
the simple forma
On May 21, 2015 9:05 PM, "Eric Sunshine" wrote:
>
> On Thu, May 21, 2015 at 8:16 PM, Allen Hubbe wrote:
> > This format is more simple than the other alias file formats, so it may
> > be preferred by some users. The format is as follows.
> >
> > : [, ..
...@example.com
abgroup: alice, bob
bcgrp: bob, chloe, Other
Signed-off-by: Allen Hubbe
---
Notes:
The v1 of this patch had the following subject line:
git-send-email.perl: Add sendmail aliases support
This v2 renames this email alias format to simple, because the syntax
On Thu, May 21, 2015 at 5:38 PM, Junio C Hamano wrote:
> Allen Hubbe writes:
>
>> Those are good points. Maybe I shouldn't even mention sendmail at
>> all, not in the name of the format, and not in the commit message.
>> What name would be a good name for this forma
On Thu, May 21, 2015 at 5:05 PM, Eric Sunshine wrote:
> On Thu, May 21, 2015 at 4:48 PM, Allen Hubbe wrote:
>> My motivation for this patch was not really to support the sendmail
>> aliases file directly. The commit message may therefore be
>> misleading. So, I could al
On Thu, May 21, 2015 at 4:19 PM, Junio C Hamano wrote:
> Allen Hubbe writes:
>
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index e1e9b14..5f2ec0d 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>>
ine. This patch does not do anything with the trailing '\',
and ignores lines starting with whitespace.
This patch also ignores lines that starts with '#', comment character,
and empty lines.
Signed-off-by: Allen Hubbe
---
git-send-email.perl | 7 ++-
1 file changed, 6 inse
28 matches
Mail list logo
