Add --dissociate option to add and update commands, both clone helper commands
that already have the --reference option --dissociate pairs with.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 10 +-
builtin/submodule--helper.c | 16 +---
git
flag, but it
is not documented.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 7 +++
git-submodule.sh| 5 -
t/t7400-submodule-basic.sh | 16
3 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/Documentation
independent clones rather than depending
on the reference.
This is a resubmission with comments from Stefan Beller, Eric Sunshine, and
Junio C Hamano addressed.
Casey Fitzpatrick (3):
submodule: clean up subsititions in script
submodule: add --progress option to add command
submodule: add
oolean values in the
script by using a substitution.
Signed-off-by: Casey Fitzpatrick
---
git-submodule.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 24914963c..262547968 100755
--- a/git-submodule.sh
+++ b/git
Thanks I will amend and re-submit (this time with -v$N, I apologize
for creating a confusing mess in everyone's email clients :))
On Wed, May 2, 2018 at 1:59 AM, Junio C Hamano wrote:
> Casey Fitzpatrick writes:
>
>> 'recommend_shallow' and 'jobs' var
Thanks I was not aware of that option.
On Wed, May 2, 2018 at 12:37 AM, Junio C Hamano wrote:
> Casey Fitzpatrick writes:
>
>> These patches add --progress and --dissociate options to git submodule.
>>
>> The --progress option existed beforehand, but only for the upda
ng a substitution.
Signed-off-by: Casey Fitzpatrick
---
git-submodule.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 24914963c..262547968 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
Add --dissociate option to add and update commands, both clone helper commands
that already have the --reference option --dissociate pairs with.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 10 +-
builtin/submodule--helper.c | 16 +---
git
flag, but it
is not documented.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 7 +++
git-submodule.sh| 5 -
t/t7400-submodule-basic.sh | 16
3 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/Documentation
independent clones rather than depending
on the reference.
This is a resubmission with comments from Stefan Beller and Eric Sunshine
addressed.
Casey Fitzpatrick (3):
submodule: clean up subsititions in script
submodule: add --progress option to add command
submodule: add --dissociate option to
Just noticed I missed the other 'test_must_fail'. Resubmitting in a few moments.
On Tue, May 1, 2018 at 8:27 PM, Casey Fitzpatrick wrote:
> Add --dissociate option to add and update commands, both clone helper commands
> that already have the --reference option --disso
flag, but it
is not documented.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 7 +++
git-submodule.sh| 5 -
t/t7400-submodule-basic.sh | 16
3 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/Documentation
'recommend_shallow' and 'jobs' variables do not need quotes (they never contain
spaces) and do not require any additional prefix, therefore remove the
unnecessary subsitition.
'progress' is a boolean value. Treat it like the other boolean values in the
script by using a substitution.
---
git-subm
independent clones rather than depending
on the reference.
This is a resubmission with comments from Stefan Beller and Eric Sunshine
addressed.
Casey Fitzpatrick (3):
submodule: clean up subsititions in script
submodule: add --progress option to add command
submodule: add --dissociate option to
Add --dissociate option to add and update commands, both clone helper commands
that already have the --reference option --dissociate pairs with.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 10 +-
builtin/submodule--helper.c | 16 +---
git
y 1, 2018 at 4:25 PM, Eric Sunshine wrote:
> On Tue, May 1, 2018 at 2:09 PM, Casey Fitzpatrick wrote:
>> submodule: Add --dissociate option to add/update commands
>
> s/Add/add/
>
>> Add --dissociate option to add and update commands, both clone helper
>> commands
&g
Thanks, I'll clean it up based on your comments. I based the tests
from t5606-clone-options.sh; I'm not sure why now but I thought I
needed that clone -o thing from there, but it appears useless.
On Tue, May 1, 2018 at 2:41 PM, Stefan Beller wrote:
> On Tue, May 1, 2018 at 11
Add --dissociate option to add and update commands, both clone helper commands
that already have the --reference option --dissociate pairs with.
Add documentation.
Add tests.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 10 +-
builtin/submodule--helper.c
--progress was missing from add command, was only in update.
Add --progress where it makes sense (both clone helper commands).
Add missing documentation entry.
Add test.
Signed-off-by: Casey Fitzpatrick
---
Documentation/git-submodule.txt | 7 +++
git-submodule.sh| 5
independent clones rather than depending
on the reference.
I apologize for any errors I may have made in creation of these patches or the
formatting of these emails. This is the first time I have submitted patches to
a mailing list.
Casey Fitzpatrick (2):
submodule: Add --progress option to add
Sure, I'll take a crack at it and submit a patch.
On Mon, Apr 30, 2018 at 2:19 PM, Stefan Beller wrote:
> On Mon, Apr 30, 2018 at 1:29 AM, Casey Fitzpatrick wrote:
>> This seems to be a hole in the git feature set. I believe it is fairly
>> easily worked around, but it woul
It also seems to be missing "--progress", and I imagine others.
Perhaps submodule add/update should be reworked to automatically
accept all the options that clone would?
On Mon, Apr 30, 2018 at 4:29 AM, Casey Fitzpatrick wrote:
> This seems to be a hole in the git feature set. I
This seems to be a hole in the git feature set. I believe it is fairly
easily worked around, but it would be best to provide the option for
ease of use (and maybe performance?).
git clone has both a --reference feature and a --dissociate option,
with dissociate allowing for a reference to *only* s
23 matches
Mail list logo
