On 2015-11-05 03:24, Jeff King wrote:
> There was also some discussion with curl upstream of providing a new
> authentication interface, where we would provide curl with
> authentication callbacks, and it would trigger them if and when
> credentials were needed. Somebody upstream was working on a p
/https_proxy/all_proxy
environment variables, which would otherwise be evaluated as a fallback by curl.
Without this, we would have different semantics for git configuration and
environment variables.
Signed-off-by: Knut Franke
Helped-by: Junio C Hamano
Helped-by: Eric Sunshine
---
Documentation
Changes in the fourth iteration:
* update Documentation/technical/api-remote.txt to reflect the addition to
struct remote
* update documentation of http.proxy in Documentation/config.txt to mention the
possibility of having git fill in missing proxy password
* fix decl-after-stmt
* generali
configuration
variables http.proxyAuthmethod and remote..proxyAuthmethod (in analogy
to http.proxy and remote..proxy).
The following values are supported:
* anyauth (default)
* basic
* digest
* negotiate
* ntlm
Signed-off-by: Knut Franke
Helped-by: Junio C Hamano
Helped-by: Eric Sunshine
On 2015-11-02 14:54, Junio C Hamano wrote:
> > static void init_curl_proxy_auth(CURL *result)
> > {
> > + if (proxy_auth.username) {
> > + if (!proxy_auth.password)
> > + credential_fill(&proxy_auth);
> > +#if LIBCURL_VERSION_NUM >= 0x071301
> > + curl_easy
On 2015-11-02 14:46, Junio C Hamano wrote:
> > Reviewed-by: Junio C Hamano
> > Reviewed-by: Eric Sunshine
>
> Please add these only when you are doing the final submission,
> sending the same version reviewed by these people after they said
> the patch(es) look good. To credit others for helpin
/https_proxy/all_proxy
environment variables, which would otherwise be evaluated as a fallback by curl.
Without this, we would have different semantics for git configuration and
environment variables.
Signed-off-by: Knut Franke
Reviewed-by: Junio C Hamano
Reviewed-by: Eric Sunshine
---
http.c
configuration
variables http.proxyAuthmethod and remote..proxyAuthmethod (in analogy
to http.proxy and remote..proxy).
The following values are supported:
* anyauth (default)
* basic
* digest
* negotiate
* ntlm
Signed-off-by: Knut Franke
Reviewed-by: Junio C Hamano
Reviewed-by: Eric Sunshine
Changes in the third iteration:
* don't break support for curl < 7.10.7
* fix some memory leaks
* explicitly set anyauth as fallback for unsupported proyx authmethod setting,
and tell the user what we did
* clean up usage of curl version #ifdefs
* fix more code formatting / style / naming is
On 2015-10-28 14:58, Eric Sunshine wrote:
> > + }
> > + if (!curl_http_proxy) {
> > + copy_from_env(&curl_http_proxy, "ALL_PROXY");
> > + copy_from_env(&curl_http_proxy, "all_proxy");
> > + }
>
> If this sort of
Junio C Hamano wrote:
> > + if (http_proxy_authmethod) {
> > + int i;
> > + for (i = 0; i < ARRAY_SIZE(http_proxy_authmethods); i++) {
> > + if (!strcmp(http_proxy_authmethod,
> > http_proxy_authmethods[i].name)) {
> > + curl_easy_s
Fixes in the second iteration:
* rename http.proxy-authmethod to http.proxyAuthmethod for consistency with
other core git variables
* issue warning() instead of error() for unsupported authentication method, for
consistency with http.sslVersion
* fix some code formatting / style issues
/https_proxy/all_proxy
environment variables, which would otherwise be evaluated as a fallback by curl.
Without this, we would have different semantics for git configuration and
environment variables.
Signed-off-by: Knut Franke
---
http.c | 63
configuration
variables http.proxyAuthmethod and remote..proxyAuthmethod (in analogy
to http.proxy and remote..proxy).
The following values are supported:
* anyauth (default)
* basic
* digest
* negotiate
* ntlm
Signed-off-by: Knut Franke
---
Documentation/config.txt | 28 ++
http.c
On 2015-10-26 13:33, Junio C Hamano wrote:
> Call yours "http.proxyAuthmethod" in the documentation, and use
> strcmp("http.proxyauthmethod", var) in the options callback code.
[...]
> Strange indentation here...
[...]
> Along the same line as how we do sslversions[] instead of a long
> if/else if/
configuration
variables http.proxy-authmethod and remote..proxy-authmethod (in analogy
to http.proxy and remote..proxy).
The following values are supported:
* anyauth (default)
* basic
* digest
* negotiate
* ntlm
Signed-off-by: Knut Franke
---
Documentation/config.txt | 28 ++
http.c
/https_proxy/all_proxy
environment variables, which would otherwise be evaluated as a fallback by curl.
Without this, we would have different semantics for git configuration and
environment variables.
Signed-off-by: Knut Franke
---
http.c | 63
Sometimes it's helpful (at least psychologically) to have this feature
easily accessible. Code borrows heavily from cherrypick.
Signed-off-by: Knut Franke
---
gitk | 62
++
1 file changed, 62 insertions(+)
diff --git a/gitk b
18 matches
Mail list logo