Re: [PATCH 2/2] am: plug FILE * leak in split_mail_conv()

2016-05-11 Thread Mikael Magnusson
%s"), >> mail, strerror(errno)); >> + } > > Presumably `fclose` doesn't ever overwrite errno in practice, but I > guess it could in theory. It probably does pretty often in general, but not when the file is opened

Re: [PATCH 0/1] Introduce a way to create a branch and worktree at the same time

2016-03-10 Thread Mikael Magnusson
ory at all. That way /usr/src only has one git-related directory and no worktrees are nested. The only downside is if you work in master most of the time, you have to type "/master" more. I think this is what Duy suggested too, but you interpreted it as having /usr/src/git-master, /us

Re: Forcing git to pack objects

2015-12-19 Thread Mikael Magnusson
files are > still there. Is it possible to ask git to put all those objects in > .pack files? Or did I mess something on my repo? > > Just in case, that's a repo I use at work that's working on a windows > box (git for windows 2.6.3). > > Thanks in advance. git rep

Re: [PATCH] Optimize usage of grep by passing -q

2015-11-16 Thread Mikael Magnusson
POSIX specifies -q, so you should be fine. http://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html -- Mikael Magnusson -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Git feature request: mark a commit as minor

2015-10-02 Thread Mikael Magnusson
considered a minor > change. The issue is that not everyone considers these changes as > "minor". You should be able to use a combination of the --grep option > in log to search for all commits who don't contain that string in the > right format. Could also be a

Re: [FEATURE REQUEST] Filter-branch extend progress with a simple estimated time remaning

2015-08-30 Thread Mikael Magnusson
cpu 2.332 total perl -e 'print time' 0.69s user 1.45s system 73% cpu 2.921 total date +%s 0.27s user 0.99s system 78% cpu 1.604 total and for comparison, /bin/true 0.02s user 0.26s system 24% cpu 1.127 total -- Mikael Magnusson -- To unsubscribe from this list: send the line &qu

Re: [FEATURE REQUEST] Filter-branch extend progress with a simple estimated time remaning

2015-08-30 Thread Mikael Magnusson
Sun, Aug 30, 2015 at 10:04 AM, Mikael Magnusson wrote: >> On Sun, Aug 30, 2015 at 5:15 AM, Eric Sunshine >> wrote: >>> (Please don't top-post on this list.) Ah, I got caught up on the ETA part. Do note that date +%s is also a gnu extension and won't work everywher

Re: [FEATURE REQUEST] Filter-branch extend progress with a simple estimated time remaning

2015-08-30 Thread Mikael Magnusson
wk 'BEGIN{srand();print srand()}' srand() in awk returns the previous seed value, and calling it without an argument sets it to time of day, so the above sequence should return seconds since the epoch, or at least something in seconds that is relative to a fixed point which is all tha

Re: [PATCH v5 2/2] worktree: add 'list' command

2015-08-24 Thread Mikael Magnusson
linked worktrees. The default > +format of the list includes the full path to the worktree and the branch or > +revision that the head of that worktree is currently pointing to. Maybe just "and the branch or revision currently checked out in that worktree."? -- Mikael

Re: Draft of Git Rev News edition 6

2015-08-06 Thread Mikael Magnusson
h you might not have sent at all, I had to click like 5 things, and a few of those turned out to be dead ends. I suppose once you know where they are published, it is easy to find, but I did not :). -- Mikael Magnusson -- To unsubscribe from this list: send the line "unsubscribe git" i

Re: [ANNOUNCE] Git v2.5.0

2015-07-27 Thread Mikael Magnusson
ng the borrowee and borrowers aware of each other. > >Consider this as still an experimental feature; its UI is still >likely to change. It might be helpful to list what the replacement actually is in this entry. -- Mikael Magnusson -- To unsubscribe from this list: send the line "unsubsc

Re: [RFC/PATCH] worktree: replace "checkout --to" with "worktree new"

2015-06-30 Thread Mikael Magnusson
directory, rebase it to upstream, delete that worktree, and then git reset --hard in the original checkout. The result is a rebased branch that touches a minimum of source files so the rebuild is faster. (In some projects I have a lot of local commits that get rebased, but maybe upstream only t

Re: [PATCH/RFC v2 2/2] git-am: add am.threeWay config variable

2015-06-02 Thread Mikael Magnusson
-3-way' > + from the command line. > + See linkgit:git-am[1]. > + This part spells it 3-way while everywhere else appears to be 3way. -- Mikael Magnusson -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Mikael Magnusson
p.version-control.git/258886 Someone sent a patch that never went anywhere, http://comments.gmane.org/gmane.comp.version-control.git/258895 -- Mikael Magnusson -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] difftool: honor --trust-exit-code for builtin tools

2014-11-15 Thread Mikael Magnusson
gt; + status=$? >> return $status >> } > > Thanks for a quick turn-around. As a hot-fix for what is already in > -rc I am fine with this fix but the patch makes me wonder if $status > as a global shell variable has any significance. $status is an alias for $? i

"git foo_bar" prints two config errors

2014-10-30 Thread Mikael Magnusson
git --help'. but, % ln -s /bin/tty ~/bin/git-の; ln -s /bin/tty ~/bin/git-foo_bar % git の error: invalid key: pager.の /dev/pts/51 % git foo_bar error: invalid key: pager.foo_bar /dev/pts/51 The command itself is accepted, so I think we shouldn't print the errors. -- Mikael Magnu

Re: let git grep consider sub projects

2014-10-07 Thread Mikael Magnusson
ng to quote the metacharacters not only once, but twice, can be a significant annoyance. Eg, first protect it from git submodule foreach parsing it, and then from the shell running the individual commands. -- Mikael Magnusson -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html