Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-10 Thread Junio C Hamano
Eric Wong writes: > Jonathan Nieder wrote: >> Michael J Gruber wrote: >> > Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41: >> >> >> Signed-off-by: Jonathan Nieder >> > >> > Tested with Subversion 1.6.18. > > Thanks both. Also pushed to "master" on git://bogomips.org/git-svn.git > (commi

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-10 Thread Eric Wong
Jonathan Nieder wrote: > Eric Wong wrote: > > Jonathan Nieder wrote: > > >> -- >8 -- > >> Subject: Git::SVN::Editor::T: pass $deletions to ->A and ->D > > > > For future reference, it'd be slightly easier for me to apply if you > > included the From: (and Date:) headers so I don't have to yank+p

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-10 Thread Jonathan Nieder
Eric Wong wrote: > Jonathan Nieder wrote: >> -- >8 -- >> Subject: Git::SVN::Editor::T: pass $deletions to ->A and ->D > > For future reference, it'd be slightly easier for me to apply if you > included the From: (and Date:) headers so I don't have to yank+paste > them myself :> Ah, I assumed you

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-10 Thread Eric Wong
Jonathan Nieder wrote: > Eric Wong wrote: > > > Thanks both. Also pushed to "master" on git://bogomips.org/git-svn.git > > (commit 44bc5ac71fd99f195bf1a3bea63c11139d2d535f) > > > > Jonathan Nieder (2): > > git svn: work around SVN 1.7 mishandling of svn:special changes > > svn test:

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-10 Thread Jonathan Nieder
Eric Wong wrote: > Thanks both. Also pushed to "master" on git://bogomips.org/git-svn.git > (commit 44bc5ac71fd99f195bf1a3bea63c11139d2d535f) > > Jonathan Nieder (2): > git svn: work around SVN 1.7 mishandling of svn:special changes > svn test: escape peg revision separator using empt

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-10 Thread Eric Wong
Jonathan Nieder wrote: > Michael J Gruber wrote: > > Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41: > > >> Signed-off-by: Jonathan Nieder > > > > Tested with Subversion 1.6.18. Thanks both. Also pushed to "master" on git://bogomips.org/git-svn.git (commit 44bc5ac71fd99f195bf1a3bea63c111

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-09 Thread Jonathan Nieder
Michael J Gruber wrote: > Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41: >> Signed-off-by: Jonathan Nieder > > Tested with Subversion 1.6.18. [...] > I haven't checked other svn versions but this approach looks perfectly > sensible. It makes us test branch names which can't even be created

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-09 Thread Michael J Gruber
Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41: > This test script uses "svn cp" to create a branch with an @-sign in > its name: > > svn cp "pr ject/trunk" "pr ject/branches/not-a@{0}reflog" > > That sets up for later tests that fetch the branch and check that git > svn mangles the r

[PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-09 Thread Jonathan Nieder
This test script uses "svn cp" to create a branch with an @-sign in its name: svn cp "pr ject/trunk" "pr ject/branches/not-a@{0}reflog" That sets up for later tests that fetch the branch and check that git svn mangles the refname appropriately. Unfortunately, modern svn versions interpre