Re: [PATCH/RFCv5 2/3] git rebase -i: warn about removed commits

2015-06-10 Thread Remi Galan Alfonso
Matthieu Moy writes: > Remi Galan Alfonso writes: > > > Matthieu Moy writes: > >> > +warn_file "$todo".miss > >> > >> I would find it more elegant with less intermediate files, like > >> > >> git rev-list $opt <"$todo".miss | while read -r line > >> do > >> warn

Re: [PATCH/RFCv5 2/3] git rebase -i: warn about removed commits

2015-06-10 Thread Matthieu Moy
Remi Galan Alfonso writes: > Matthieu Moy writes: >> > +warn_file "$todo".miss >> >> I would find it more elegant with less intermediate files, like >> >> git rev-list $opt <"$todo".miss | while read -r line >> do >> warn " - $line" >> done > > I am not really s

Re: [PATCH/RFCv5 2/3] git rebase -i: warn about removed commits

2015-06-10 Thread Remi Galan Alfonso
Matthieu Moy writes: > > +warn_file "$todo".miss > > I would find it more elegant with less intermediate files, like > > git rev-list $opt <"$todo".miss | while read -r line > do > warn " - $line" > done I am not really sure since I also use warn_file to display

Re: [PATCH/RFCv5 2/3] git rebase -i: warn about removed commits

2015-06-10 Thread Matthieu Moy
Galan Rémi writes: > Check if commits were removed (i.e. a line was deleted) and print > warnings or stop git rebase depending on the value of the > configuration variable rebase.missingCommitsCheck. > > This patch gives the user the possibility to avoid silent loss of > information (losing a com

[PATCH/RFCv5 2/3] git rebase -i: warn about removed commits

2015-06-10 Thread Galan Rémi
Check if commits were removed (i.e. a line was deleted) and print warnings or stop git rebase depending on the value of the configuration variable rebase.missingCommitsCheck. This patch gives the user the possibility to avoid silent loss of information (losing a commit through deleting the line in