Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-20 Thread Christian Couder
On Fri, Nov 21, 2014 at 12:33 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> So I have read the man page on the trailers and it seems like the solution >> to my problem in removing parts from the commit message. >> However I did not find out, if it can be run automatically, whenever >> ca

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-20 Thread Junio C Hamano
Stefan Beller writes: > So I have read the man page on the trailers and it seems like the solution > to my problem in removing parts from the commit message. > However I did not find out, if it can be run automatically, whenever > calling format-patch > > Maybe all that is missing here is an opti

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-20 Thread Stefan Beller
On Tue, Nov 18, 2014 at 07:40:07AM +0100, Christian Couder wrote: > On Mon, Nov 17, 2014 at 8:20 PM, Junio C Hamano wrote: > > Junio C Hamano writes: > > > >> (I am not saying that there should be an easy way to drop cruft left > >> by third-party systems such as "Change-id:" line) ... > > > > He

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-18 Thread Junio C Hamano
Stefan Beller writes: > Do we have similar filters somewhere in place already, > so I could have a look at the code architecture, > the api, and how the user would operate that? The clean/smudge filters interacts with the payload data and the end user configuration in a similar way, I would say.

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-17 Thread Christian Couder
On Mon, Nov 17, 2014 at 8:20 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> (I am not saying that there should be an easy way to drop cruft left >> by third-party systems such as "Change-id:" line) ... > > Heh, that was "should not be", but I guess it was probably obvious. > > Sorry for

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-17 Thread Stefan Beller
Junio, thanks for pointing out, why my patch doesn't make sense here. Do we have similar filters somewhere in place already, so I could have a look at the code architecture, the api, and how the user would operate that? The way you're proposing, doesn't sound as if a hook would be the right thin

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-17 Thread Junio C Hamano
Junio C Hamano writes: > (I am not saying that there should be an easy way to drop cruft left > by third-party systems such as "Change-id:" line) ... Heh, that was "should not be", but I guess it was probably obvious. Sorry for the noise. -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-17 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> +post-format-patch >> + >> + >> +This hook is called after format-patch created a patch and it is >> +invoked with the filename of the patch as the first parameter. > > Such an interface would not work well with --stdout mode, woul

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-17 Thread Stefan Beller
On Sun, Nov 16, 2014 at 10:40 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> +post-format-patch >> + >> + >> +This hook is called after format-patch created a patch and it is >> +invoked with the filename of the patch as the first parameter. > > Such an interface would not wor

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-16 Thread Junio C Hamano
Stefan Beller writes: > +post-format-patch > + > + > +This hook is called after format-patch created a patch and it is > +invoked with the filename of the patch as the first parameter. Such an interface would not work well with --stdout mode, would it? And if this only works with o

Re: [PATCH] Introduce a hook to run after formatting patches

2014-11-15 Thread Philip Oakley
From: "Stefan Beller" This comes in handy if you want to post-process formatted patches. One examplary use case would be removing ChangeIds, which are used in Gerrit, a program sitting on top of Git, used for tracking different versions of a patch. Another use case would be checking if all your

[PATCH] Introduce a hook to run after formatting patches

2014-11-14 Thread Stefan Beller
This comes in handy if you want to post-process formatted patches. One examplary use case would be removing ChangeIds, which are used in Gerrit, a program sitting on top of Git, used for tracking different versions of a patch. Another use case would be checking if all your commits are signed off,