On Fri, May 29, 2015 at 2:40 PM, Junio C Hamano wrote:
>
> Quentin Neill writes:
>
> > Thanks for the thorough review!
> > I have adjusted the commit messages and updated the documentation changes.
> > I'm in trying to add tests, I'll probably have some issues but will
> > post something that wor
Quentin Neill writes:
> Thanks for the thorough review!
> I have adjusted the commit messages and updated the documentation changes.
> I'm in trying to add tests, I'll probably have some issues but will
> post something that works soon.
Hi, I was sweeping my old mailbox for leftover bits, and no
Eric Sunshine writes:
> On Thu, Apr 30, 2015 at 10:03 AM, Quentin Neill
> wrote:
>> I'm thinking of a test file that will test all the git blame options,
>> but for this
>> patch it will only test the new showEmail config. I read t/README and
>> tentatively named the new test file "t/8009-blam
Eric Sunshine writes:
> Right. Rather than having a separate global 'show_email' variable and
> consulting that variable in parallel with OUTPUT_SHOW_EMAIL throughout
> the code, instead set the OUTPUT_SHOW_EMAIL bit in git_blame_config().
> To do this, take advantage of the "callback data" argum
On Mon, Apr 27, 2015 at 9:46 AM, Quentin Neill wrote:
> On Fri, Apr 24, 2015 at 12:22 AM, Eric Sunshine
> wrote:
>> It's not clear why you relocated documentation of --show-email from
>> git-blame.txt to blame-options.txt, and the commit message does not
>> explain the move. If there's a good re
On Mon, Apr 27, 2015 at 2:10 PM, Junio C Hamano wrote:
> Quentin Neill writes:
>> Eric Sunshine writes:
>>> Quentin Neill writes:
- if (opt & OUTPUT_SHOW_EMAIL)
+ if ((opt & OUTPUT_SHOW_EMAIL) || show_email)
>>>
>>> The desired behavior is f
Quentin Neill writes:
>> It's not clear why you relocated documentation of --show-email from
>> git-blame.txt to blame-options.txt, and the commit message does not
>> explain the move. If there's a good reason for the relocation, the
>> justification should be spelled out so that people reviewing
Thanks for the thorough review!
I have adjusted the commit messages and updated the documentation changes.
I'm in trying to add tests, I'll probably have some issues but will
post something that works soon.
As for the comments on behavior, see my responses below.
--
Quentin
"There! His Majesty ca
Thanks for the submission. See comments below...
On Thu, Apr 23, 2015 at 10:13 PM, Quentin Neill wrote:
> From: Quentin Neill
You should drop this line. git-am will pluck your name and email
automatically from the email From: header.
> If you prefer seeing emails in your git blame outp
From: Quentin Neill
If you prefer seeing emails in your git blame output, rather
than sprinkling '-e' options everywhere you can just set
the new config blame.showemail to true.
---
Documentation/blame-options.txt | 5 +
Documentation/git-blame.txt | 4
bui
10 matches
Mail list logo
