Re: [PATCH] cache.h: add missing NORETURN on git_die_config*()

2014-08-05 Thread Tanay Abhra
On 8/5/2014 7:27 PM, Ramsay Jones wrote: > > Commit 3a2a9527 ("config: add `git_die_config()` to the config-set > API", 01-08-2014) added git_die_config() and git_die_config_linenr() > functions, but forgot to include the NORETURN attribute in their > declarations. Sparse complains like so: > >

[PATCH] cache.h: add missing NORETURN on git_die_config*()

2014-08-05 Thread Ramsay Jones
Commit 3a2a9527 ("config: add `git_die_config()` to the config-set API", 01-08-2014) added git_die_config() and git_die_config_linenr() functions, but forgot to include the NORETURN attribute in their declarations. Sparse complains like so: SP config.c config.c:1567:6: error: symbol '