Re: [PATCH] status_printf_ln: Suppress false positive warnings of empty format string.

2013-07-19 Thread Junio C Hamano
Stefan Beller writes: > This is a response to 8dd0ee823f1829a3aa228c3c73e31de5c89b5317. > > Instead of having an empty string as format for the printf like function > status_printf_ln, we could insert an empty string into the format > parameter. > > A similar fixup commit is found in linux (2e4c3

Re: [PATCH] status_printf_ln: Suppress false positive warnings of empty format string.

2013-07-19 Thread Stefan Beller
> > Even if the " " variant is faster, it does not matter if its output > is incorrect ;-) Agreed. > I think we discussed this already? The conclusion was it is silly > for GCC to warn on -Wformat-zero-length for user-defined function in > the first place, IIRC. func(other, args, fmt,...), wh

[PATCH] status_printf_ln: Suppress false positive warnings of empty format string.

2013-07-19 Thread Stefan Beller
This is a response to 8dd0ee823f1829a3aa228c3c73e31de5c89b5317. Instead of having an empty string as format for the printf like function status_printf_ln, we could insert an empty string into the format parameter. A similar fixup commit is found in linux (2e4c332913b5), but there the empty string