Re: [PATCH 07/13] prune_remote(): use delete_refs()

2015-06-09 Thread Jeff King
On Tue, Jun 09, 2015 at 12:50:13PM +0200, Michael Haggerty wrote: > The new code (in delete_refs()) allows delete_ref() to emit its error, > but then follows it up with > > error(_("could not remove reference %s"), refname) > > The "could not remove reference" error originally came from a si

Re: [PATCH 07/13] prune_remote(): use delete_refs()

2015-06-09 Thread Michael Haggerty
On 06/08/2015 07:12 PM, Jeff King wrote: > On Mon, Jun 08, 2015 at 09:57:04AM -0700, Stefan Beller wrote: > >> On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty >> wrote: >>> This will result in errors being emitted for references that can't be >>> deleted, but that is a good thing. >> >> This so

Re: [PATCH 07/13] prune_remote(): use delete_refs()

2015-06-08 Thread Jeff King
On Mon, Jun 08, 2015 at 09:57:04AM -0700, Stefan Beller wrote: > On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty wrote: > > This will result in errors being emitted for references that can't be > > deleted, but that is a good thing. > > This sounds a bit like hand-waving to me. "Trust me, I'm a

Re: [PATCH 07/13] prune_remote(): use delete_refs()

2015-06-08 Thread Stefan Beller
On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty wrote: > This will result in errors being emitted for references that can't be > deleted, but that is a good thing. This sounds a bit like hand-waving to me. "Trust me, I'm an engineer!". > > Signed-off-by: Michael Haggerty > --- > builtin/remo

[PATCH 07/13] prune_remote(): use delete_refs()

2015-06-08 Thread Michael Haggerty
This will result in errors being emitted for references that can't be deleted, but that is a good thing. Signed-off-by: Michael Haggerty --- builtin/remote.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index c8dc724..cc3c741