Re: [PATCH 3/3] t/t7106-reset-unborn-branch.sh: Add PERL prerequisite

2013-08-25 Thread Jonathan Nieder
Junio C Hamano wrote: > The change to the one that feeds 'y' to "reset -p" may be a bit too > pedantic, as we are not in the business of testing "echo y", though. Yeah, that's true. Here's a patch for squashing in. diff --git i/t/t7106-reset-unborn-branch.sh w/t/t7106-reset-unborn-branch.sh ind

Re: [PATCH 3/3] t/t7106-reset-unborn-branch.sh: Add PERL prerequisite

2013-08-24 Thread Junio C Hamano
Jonathan Nieder writes: > Kacper Kornet wrote: > >> Signed-off-by: Kacper Kornet > > Thanks. > > Reviewed-by: Jonathan Nieder > > Here's a style cleanup on top. > > -- >8 -- > Subject: reset test: modernize style > > Avoid command substitution and pipes to ensure that the exit status > from eac

Re: [PATCH 3/3] t/t7106-reset-unborn-branch.sh: Add PERL prerequisite

2013-08-24 Thread Jonathan Nieder
Kacper Kornet wrote: > Signed-off-by: Kacper Kornet Thanks. Reviewed-by: Jonathan Nieder Here's a style cleanup on top. -- >8 -- Subject: reset test: modernize style Avoid command substitution and pipes to ensure that the exit status from each git command is tested (and in particular that a

[PATCH 3/3] t/t7106-reset-unborn-branch.sh: Add PERL prerequisite

2013-08-23 Thread Kacper Kornet
The test 'reset -p' uses git-reset -p, so it depends on the perl code. Signed-off-by: Kacper Kornet --- t/t7106-reset-unborn-branch.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7106-reset-unborn-branch.sh b/t/t7106-reset-unborn-branch.sh index 8062cf5..499cd88 100755