On 12/26/2013 11:34 PM, Jonathan Nieder wrote:
> Michael Haggerty wrote:
>
>> [Subject: safe_create_leading_directories(): add "slash" pointer]
>
> Is this a cleanup or improving the (internal) functionality of the
> function somehow? The above one-liner doesn't sum up for me in an
> obvious way
Michael Haggerty wrote:
> [Subject: safe_create_leading_directories(): add "slash" pointer]
Is this a cleanup or improving the (internal) functionality of the
function somehow? The above one-liner doesn't sum up for me in an
obvious way why this is a good change.
> Keep track of the position of
Keep track of the position of the slash character separately, and
restore the slash character at a single place, at the end of the while
loop. This makes the next change easier to implement.
Signed-off-by: Michael Haggerty
---
sha1_file.c | 36 ++--
1 file change
3 matches
Mail list logo
