Re: [PATCH v2 09/11] parse-options.h: add macros for '--contains' option

2015-06-15 Thread karthik nayak
On Tue, Jun 16, 2015 at 12:57 AM, Junio C Hamano wrote: > Christian Couder writes: > >> The PARSE_OPT_HIDDEN flag is removed below. This means that "--with" >> will appear in the "git tag -h" output, which means that "--with" >> should appear in the documentation... >> The commit message may also

Re: [PATCH v2 09/11] parse-options.h: add macros for '--contains' option

2015-06-15 Thread Junio C Hamano
Christian Couder writes: > The PARSE_OPT_HIDDEN flag is removed below. This means that "--with" > will appear in the "git tag -h" output, which means that "--with" > should appear in the documentation... > The commit message may also want to tell that with is not hidden any more. Or why is it a

Re: [PATCH v2 09/11] parse-options.h: add macros for '--contains' option

2015-06-13 Thread karthik nayak
On Sun, Jun 14, 2015 at 11:43 AM, Christian Couder wrote: > On Sat, Jun 13, 2015 at 10:18 PM, Karthik Nayak wrote: >> Add a macro for using the '--contains' option in parse-options.h >> also include an optional '--with' option macro which performs the >> same action as '--contains'. >> >> Make ta

Re: [PATCH v2 09/11] parse-options.h: add macros for '--contains' option

2015-06-13 Thread Christian Couder
On Sat, Jun 13, 2015 at 10:18 PM, Karthik Nayak wrote: > Add a macro for using the '--contains' option in parse-options.h > also include an optional '--with' option macro which performs the > same action as '--contains'. > > Make tag.c use this new macro > > Mentored-by: Christian Couder > Mentor

[PATCH v2 09/11] parse-options.h: add macros for '--contains' option

2015-06-13 Thread Karthik Nayak
Add a macro for using the '--contains' option in parse-options.h also include an optional '--with' option macro which performs the same action as '--contains'. Make tag.c use this new macro Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off-by: Karthik Nayak --- builtin/tag.c