On 03 Sep 2015, at 23:31, Junio C Hamano wrote:
> Lars Schneider writes:
>
>> In case I agree with a reviewer. What is the more appropriate action?
>> A response like the one above or a new role that includes the change
>> right away? I don’t want to spam the list with lots of tiny changes…
>
Lars Schneider writes:
> In case I agree with a reviewer. What is the more appropriate action?
> A response like the one above or a new role that includes the change
> right away? I don’t want to spam the list with lots of tiny changes…
Responding to review comment like you did with "will do" is
On 03 Sep 2015, at 22:18, Junio C Hamano wrote:
> Lars Schneider writes:
>
>> On 03 Sep 2015, at 21:55, Luke Diamand wrote:
>>
>>> On 03/09/15 17:35, larsxschnei...@gmail.com wrote:
From: Lars Schneider
>>>
>>> I think this commit may need some explanation!
>>
>> The functions
Lars Schneider writes:
> On 03 Sep 2015, at 21:55, Luke Diamand wrote:
>
>> On 03/09/15 17:35, larsxschnei...@gmail.com wrote:
>>> From: Lars Schneider
>>>
>>
>> I think this commit may need some explanation!
>
> The functions “gitConfig” and “gitConfigBool” are almost
> identical. Make “gitC
On 03 Sep 2015, at 21:55, Luke Diamand wrote:
> On 03/09/15 17:35, larsxschnei...@gmail.com wrote:
>> From: Lars Schneider
>>
>
> I think this commit may need some explanation!
The functions “gitConfig” and “gitConfigBool” are almost identical. Make
“gitConfig” more generic by adding an opt
On 03/09/15 17:35, larsxschnei...@gmail.com wrote:
From: Lars Schneider
I think this commit may need some explanation!
Signed-off-by: Lars Schneider
---
git-p4.py | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 073f87b..c139ca
From: Lars Schneider
Signed-off-by: Lars Schneider
---
git-p4.py | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 073f87b..c139cab 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -604,9 +604,12 @@ def gitBranchExists(branch):
_gitConfig =
7 matches
Mail list logo