Re: [PATCH v3 03/19] refs.c: make ref_transaction_commit return an error string

2014-04-28 Thread Ronnie Sahlberg
Good points. On Fri, Apr 25, 2014 at 3:10 PM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> Let ref_transaction_commit return an optional error string that describes >> the transaction failure. Start by returning the same error as >> update_ref_lock >> returns, modulo the initial error

Re: [PATCH v3 03/19] refs.c: make ref_transaction_commit return an error string

2014-04-25 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Let ref_transaction_commit return an optional error string that describes > the transaction failure. Start by returning the same error as update_ref_lock > returns, modulo the initial error:/fatal: preamble. s/returns/prints/? > This will make it easier for callers to c

[PATCH v3 03/19] refs.c: make ref_transaction_commit return an error string

2014-04-25 Thread Ronnie Sahlberg
Let ref_transaction_commit return an optional error string that describes the transaction failure. Start by returning the same error as update_ref_lock returns, modulo the initial error:/fatal: preamble. This will make it easier for callers to craft better error messages when a transaction call fa