Re: [PATCH v3 11/21] pack-objects: use bitmaps when packing objects

2013-12-21 Thread Jeff King
On Sat, Dec 07, 2013 at 04:47:20PM +0100, Thomas Rast wrote: > > +static off_t write_reused_pack(struct sha1file *f) > > +{ > > + uint8_t buffer[8192]; > > We usually just call this 'unsigned char'. I can see why this would be > more portable, but git would already fall apart badly on an archi

Re: [PATCH v3 11/21] pack-objects: use bitmaps when packing objects

2013-12-07 Thread Thomas Rast
This week's nits... I found this harder to read than the previous patch, but I think it's mostly because the existing code is already a bit tangled. I think the second item below is worth fixing, though. Jeff King writes: > +static off_t write_reused_pack(struct sha1file *f) > +{ > + uint

[PATCH v3 11/21] pack-objects: use bitmaps when packing objects

2013-11-14 Thread Jeff King
From: Vicent Marti In this patch, we use the bitmap API to perform the `Counting Objects` phase in pack-objects, rather than a traditional walk through the object graph. For a reasonably-packed large repo, the time to fetch and clone is often dominated by the full-object revision walk during the