Re: [PATCH v5 22/35] git_config_set_multivar_in_file(): avoid call to rollback_lock_file()

2014-09-23 Thread Michael Haggerty
On 09/17/2014 12:28 AM, Jonathan Nieder wrote: > Michael Haggerty wrote: > >> After commit_lock_file() is called, then the lock_file object is >> necessarily either committed or rolled back. So there is no need to >> call rollback_lock_file() again in either of these cases. >> >> Signed-off-by: M

Re: [PATCH v5 22/35] git_config_set_multivar_in_file(): avoid call to rollback_lock_file()

2014-09-16 Thread Jonathan Nieder
Michael Haggerty wrote: > After commit_lock_file() is called, then the lock_file object is > necessarily either committed or rolled back. So there is no need to > call rollback_lock_file() again in either of these cases. > > Signed-off-by: Michael Haggerty This seems to involve an unadvertised

[PATCH v5 22/35] git_config_set_multivar_in_file(): avoid call to rollback_lock_file()

2014-09-16 Thread Michael Haggerty
After commit_lock_file() is called, then the lock_file object is necessarily either committed or rolled back. So there is no need to call rollback_lock_file() again in either of these cases. Signed-off-by: Michael Haggerty --- config.c | 14 +++--- 1 file changed, 7 insertions(+), 7 del