On Sat, Jun 13, 2015 at 1:57 AM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> I think it is needed later when "struct ref_sort" is moved into
>> ref-filter.h, because then the used_atom[] array is not moved.
>
> Now I am confused. used_atom[] is the mechanism we use to give a
> small in
Christian Couder writes:
> I think it is needed later when "struct ref_sort" is moved into
> ref-filter.h, because then the used_atom[] array is not moved.
Now I am confused. used_atom[] is the mechanism we use to give a
small integer to each atom used in the %(placeholder) string, so
that we d
On Fri, Jun 12, 2015 at 8:29 PM, Karthik Nayak wrote:
> On 06/12/2015 11:34 PM, Junio C Hamano wrote:
>>
>> Karthik Nayak writes:
>>
What change since 9f613dd do you have in mind, exactly, though?
>>>
>>>
>>> Well initially the atoms were indexed into used_atom array, which
>>> later was rem
On 06/12/2015 11:34 PM, Junio C Hamano wrote:
Karthik Nayak writes:
What change since 9f613dd do you have in mind, exactly, though?
Well initially the atoms were indexed into used_atom array, which
later was removed. Hence the comment becomes obsolete.
Later in which commit? In builtin/fo
Karthik Nayak writes:
>> What change since 9f613dd do you have in mind, exactly, though?
>
> Well initially the atoms were indexed into used_atom array, which
> later was removed. Hence the comment becomes obsolete.
Later in which commit? In builtin/for-each-ref.c in the version
after applying
On 06/12/2015 11:10 PM, Junio C Hamano wrote:
Karthik Nayak writes:
The comment in 'ref_sort' hasn't been changed 9f613dd.
Bad grammar? "hasn't been changed since 9f613dd", perhaps?
Yes! thanks :)
But more importantly, don't just give an abbreviated object name. I
think "the comment h
Karthik Nayak writes:
> The comment in 'ref_sort' hasn't been changed 9f613dd.
Bad grammar? "hasn't been changed since 9f613dd", perhaps?
But more importantly, don't just give an abbreviated object name. I
think "the comment hasn't changed since the for-each-ref command was
originally introdu
The comment in 'ref_sort' hasn't been changed 9f613dd.
Change the comment to reflect changes made in the code since
9f613dd.
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-off-by: Karthik Nayak
---
builtin/for-each-ref.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
8 matches
Mail list logo
