Re: [PATCH v8 10/44] refs.c: change ref_transaction_update() to do error checking and return status

2014-05-15 Thread Ronnie Sahlberg
On Thu, May 15, 2014 at 12:34 PM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> Update ref_transaction_update() do some basic error checking and return >> non-zero on error. Update all callers to check ref_transaction_update() for >> error. There are currently no conditions in _update that

Re: [PATCH v8 10/44] refs.c: change ref_transaction_update() to do error checking and return status

2014-05-15 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Update ref_transaction_update() do some basic error checking and return > non-zero on error. Update all callers to check ref_transaction_update() for > error. There are currently no conditions in _update that will return error but > there will be in the future. Probably w

[PATCH v8 10/44] refs.c: change ref_transaction_update() to do error checking and return status

2014-05-15 Thread Ronnie Sahlberg
Update ref_transaction_update() do some basic error checking and return non-zero on error. Update all callers to check ref_transaction_update() for error. There are currently no conditions in _update that will return error but there will be in the future. Also check for BUGs during update and die(