Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> And indeed "git bisect terms foo bar" errors out. I think the reason it >> is this way is to allow >> >> $ git bisect terms foo bar >> $ git bisect start >> >> But actually, we can allow "git bisect terms" until BISECT_TERMS is >> created, whi

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Junio C Hamano
Matthieu Moy writes: > This is currently how it's implemented. You need to say > > $ git bisect terms foo bar > $ git bisect start Ahh, it means everything including the description (i.e. "you start bisection") is consistent and perfectly fine. I misread the patch, it seems. Sorry for the nois

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Matthieu Moy
Junio C Hamano writes: > And worse yet, majority of users may read "git bisect start" is > where "you start bisection", but "bisect start" (either called > directly, or via bisect_autostart by the first "git bisect good") > is where you set up the machinery, so doing "bisect terms" before > doing

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Junio C Hamano
Matthieu Moy writes: > Junio C Hamano writes: > >> The second sentence may want to be something like >> >> If you mistyped one of the terms, you can do another "git >> bisect terms " to correct them, but >> that is possible only before you start the bisection. > > Applied, thanks

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Matthieu Moy
Junio C Hamano writes: > The second sentence may want to be something like > > If you mistyped one of the terms, you can do another "git > bisect terms " to correct them, but > that is possible only before you start the bisection. Applied, thanks. I currently have this in add

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-25 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> + >> +git bisect terms >> + > > The mnemonic for "git bisect start bad good" is Bad comes before > Good (B = 0x42, G = 0x47) and this is same for "

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-25 Thread Junio C Hamano
Junio C Hamano writes: >> +Only the first bisection following the `git bisect terms` will use the >> +terms. If you mistyped one of the terms you can do again `git bisect >> +terms `. This paragraph may need further polishing. The first sentence makes it sound as if this is a valid sequence, b

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-25 Thread Junio C Hamano
Matthieu Moy writes: > + > +git bisect terms > + The mnemonic for "git bisect start bad good" is Bad comes before Good (B = 0x42, G = 0x47) and this is same for "new/old", New comes before Old (N =

[PATCH v9 5/5] bisect: allow any terms set by user

2015-06-25 Thread Matthieu Moy
From: Antoine Delaite Introduction of the git bisect terms command. The user can set his own terms. It will work exactly like before. The terms must be set before the start. Signed-off-by: Antoine Delaite Signed-off-by: Louis Stuber Signed-off-by: Matthieu Moy --- Documentation/git-bisect.tx