Re: [PATCHv2] git-diff: Clarify operation when not inside a repository.

2013-08-29 Thread Dale R. Worley
> From: Junio C Hamano > diff --git a/Documentation/git-diff.txt b/Documentation/git-diff.txt > index b1630ba..33fbd8c 100644 > --- a/Documentation/git-diff.txt > +++ b/Documentation/git-diff.txt > @@ -28,11 +28,15 @@ two blob objects, or changes between two files on disk. > words, the diff

Re: [PATCHv2] git-diff: Clarify operation when not inside a repository.

2013-08-28 Thread Junio C Hamano
wor...@alum.mit.edu (Dale R. Worley) writes: >> For now, I'll queue your version as-is modulo style fixes, while >> waiting for others to help polishing the documentation better. > > It'd difficult to figure out how to describe it well. In my > opinion, the problem here is the DWIM nature of the

Re: [PATCHv2] git-diff: Clarify operation when not inside a repository.

2013-08-23 Thread Dale R. Worley
> From: Junio C Hamano > I suspect that it may be a good idea to split the section altogether > to reduce confusion like what triggered this thread, e.g. > > 'git diff' [--options] [--] [...]:: > > This form is to view the changes you made relative to > the index (st

Re: [PATCHv2] git-diff: Clarify operation when not inside a repository.

2013-08-22 Thread Junio C Hamano
wor...@alum.mit.edu (Dale R. Worley) writes: > The error message has been updated from [PATCH]. "git diff" outside a > repository now produces: > > Not a git repository > To compare two paths outside a working tree: > usage: git diff [--no-index] > > This should inform the user of h

[PATCHv2] git-diff: Clarify operation when not inside a repository.

2013-08-22 Thread Dale R. Worley
Clarify documentation for git-diff: State that when not inside a repository, --no-index is implied (and thus two arguments are mandatory). Clarify error message from diff-no-index to inform user that CWD is not inside a repository and thus two arguments are mandatory. Signed-off-by: Dale Worley