[PATCH] upload-pack: fix sparse warnings

2019-03-11 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Jonathan, If you need to re-roll your 'jt/fetch-cdn-offload' branch, could you please squash this into the relevant patches. (The first hunk into commit a8d662e3da4 ("upload-pack: refactor reading of pack-objects out", 2019-03-08) and the second hunk into com

Re: [PATCH] revision.c: fix sparse warnings (sparse algorithm)

2019-01-15 Thread Junio C Hamano
Derrick Stolee writes: > On 1/13/2019 3:55 PM, Ramsay Jones wrote: >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Derrick, >> >> If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could >> you please squash this into the relevant patch [commit 9949aaeef4 >> ("revision: implement spar

Re: [PATCH] revision.c: fix sparse warnings (sparse algorithm)

2019-01-15 Thread Derrick Stolee
On 1/13/2019 3:55 PM, Ramsay Jones wrote: Signed-off-by: Ramsay Jones --- Hi Derrick, If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could you please squash this into the relevant patch [commit 9949aaeef4 ("revision: implement sparse algorithm", 2018-12-14)]. This commit cause

[PATCH] revision.c: fix sparse warnings (sparse algorithm)

2019-01-13 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Derrick, If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could you please squash this into the relevant patch [commit 9949aaeef4 ("revision: implement sparse algorithm", 2018-12-14)]. This commit caused both 'sparse' and my 'static-check.pl'

[PATCH] line-log: Fix sparse warnings

2013-03-07 Thread Ramsay Jones
Sparse issues the following warnings: line-log.c:17:6: warning: symbol 'range_set_grow' was not declared. Should it be static? line-log.c:25:6: warning: symbol 'range_set_init' was not declared. Should it be static? line-log.c:33:6: warning: symbol 'range_set_release' was not declar

[Patch] Fix sparse warnings

2005-08-03 Thread Alecs King
fix one 'should it be static?' warning and two 'mixing declarations and code' warnings. Signed-off-by: Alecs King <[EMAIL PROTECTED]> --- connect.c|3 ++- ssh-pull.c |2 +- tools/mailinfo.c |2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/connect.c

Fix sparse warnings

2005-08-01 Thread Linus Torvalds
A few sparse warnings have crept in again since I checked last time: undeclared variables with global scope. Fix them by marking the private variables properly "static". Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]> Btw, sparse also warns about the "return 0" in receive-pack.c: unpack