Re: [PATCH nd/wildmatch] Correct Git's version of isprint and isspace

2012-11-14 Thread René Scharfe
Am 13.11.2012 20:50, schrieb Linus Torvalds: On Tue, Nov 13, 2012 at 11:40 AM, Linus Torvalds wrote: I have to wonder why you care? As far as I'm concerned, the only valid space is space, TAB and CR/LF. Anything else is *noise*, not space. What's the reason for even caring? Btw, expanding t

Re: [PATCH nd/wildmatch] Correct Git's version of isprint and isspace

2012-11-13 Thread Linus Torvalds
On Tue, Nov 13, 2012 at 11:40 AM, Linus Torvalds wrote: > > I have to wonder why you care? As far as I'm concerned, the only valid > space is space, TAB and CR/LF. > > Anything else is *noise*, not space. What's the reason for even caring? Btw, expanding the whitespace selection may actually be v

Re: [PATCH nd/wildmatch] Correct Git's version of isprint and isspace

2012-11-13 Thread Linus Torvalds
On Tue, Nov 13, 2012 at 11:15 AM, René Scharfe wrote: > > Linus, do you remember if you left them out on purpose? Umm, no. I have to wonder why you care? As far as I'm concerned, the only valid space is space, TAB and CR/LF. Anything else is *noise*, not space. What's the reason for even caring

Re: [PATCH nd/wildmatch] Correct Git's version of isprint and isspace

2012-11-13 Thread Johannes Sixt
Am 13.11.2012 11:46, schrieb Nguyễn Thái Ngọc Duy: > @@ -14,11 +14,11 @@ enum { > P = GIT_PATHSPEC_MAGIC, /* other non-alnum, except for ] and } */ > X = GIT_CNTRL, > U = GIT_PUNCT, > - Z = GIT_CNTRL | GIT_SPACE > + Z = GIT_CNTRL_SPACE > }; > > -const unsigned char sane

Re: [PATCH nd/wildmatch] Correct Git's version of isprint and isspace

2012-11-13 Thread René Scharfe
Am 13.11.2012 11:46, schrieb Nguyễn Thái Ngọc Duy: Git's ispace does not include 11 and 12. [...] > According to glibc-2.14.1 on C locale on Linux, this is wrong. 11 and 12 being vertical tab (\v) and form-feed (\f). This lack goes back to the introduction of git's own character classifier m

Re: [PATCH nd/wildmatch] Correct Git's version of isprint and isspace

2012-11-13 Thread René Scharfe
Am 13.11.2012 11:46, schrieb Nguyễn Thái Ngọc Duy: Git's isprint includes control space characters (10-13). According to glibc-2.14.1 on C locale on Linux, this is wrong. This patch fixes it. isprint() is not in master, yet. Can we perhaps still introduce it in such a way that we never have a

Re: [PATCH nd/wildmatch] Correct Git's version of isprint and isspace

2012-11-13 Thread Jan H. Schönherr
Hi. Am 13.11.2012 11:46, schrieb Nguyễn Thái Ngọc Duy: > Git's ispace does not include 11 and 12. Git's isprint includes > control space characters (10-13). According to glibc-2.14.1 on C > locale on Linux, this is wrong. This patch fixes it. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > I wr