Re: [PATCH v2] send-pack: never fetch when checking exclusions

2019-10-16 Thread Jeff King
On Fri, Oct 11, 2019 at 03:08:22PM -0700, Jonathan Tan wrote: > > As a general rule (and why I'm raising this issue in reply to Jonathan's > > patch), I think most or all sites that want OBJECT_INFO_QUICK will want > > SKIP_FETCH_OBJECT as well, and vice versa. The reasoning is generally > > the s

Re: [PATCH v2] send-pack: never fetch when checking exclusions

2019-10-11 Thread Junio C Hamano
Jeff King writes: > As a general rule (and why I'm raising this issue in reply to Jonathan's > patch), I think most or all sites that want OBJECT_INFO_QUICK will want > SKIP_FETCH_OBJECT as well, and vice versa. The reasoning is generally > the same: > > - it's OK to racily have a false negativ

Re: [PATCH v2] send-pack: never fetch when checking exclusions

2019-10-11 Thread Jonathan Tan
> As a general rule (and why I'm raising this issue in reply to Jonathan's > patch), I think most or all sites that want OBJECT_INFO_QUICK will want > SKIP_FETCH_OBJECT as well, and vice versa. The reasoning is generally > the same: > > - it's OK to racily have a false negative (we'll still be c

Re: [PATCH v2] send-pack: never fetch when checking exclusions

2019-10-11 Thread Jeff King
On Fri, Oct 11, 2019 at 08:31:30AM -0400, Derrick Stolee wrote: > >> Ensure that these lazy fetches do not occur. > > > > That makes sense. For similar reasons, should we be using > > OBJECT_INFO_QUICK here? If the other side has a bunch of ref tips that > > we don't have, we'll end up re-scannin

Re: [PATCH v2] send-pack: never fetch when checking exclusions

2019-10-11 Thread Derrick Stolee
On 10/11/2019 2:12 AM, Jeff King wrote: > On Tue, Oct 08, 2019 at 11:37:39AM -0700, Jonathan Tan wrote: > >> When building the packfile to be sent, send_pack() is given a list of >> remote refs to be used as exclusions. For each ref, it first checks if >> the ref exists locally, and if it does, pa

Re: [PATCH v2] send-pack: never fetch when checking exclusions

2019-10-10 Thread Jeff King
On Tue, Oct 08, 2019 at 11:37:39AM -0700, Jonathan Tan wrote: > When building the packfile to be sent, send_pack() is given a list of > remote refs to be used as exclusions. For each ref, it first checks if > the ref exists locally, and if it does, passes it with a "^" prefix to > pack-objects. Ho