Re: [PATCHv3 1/3] git-p4: add failing test for P4EDITOR handling

2015-05-20 Thread Luke Diamand
On 20/05/15 21:56, Junio C Hamano wrote: Junio C Hamano writes: Luke Diamand writes: + +test_expect_failure 'EDITOR has options' ' +# Check that the P4EDITOR argument can be given command-line +# options, which git-p4 will then pass through to the shell. +test_expect_success 'EDITOR has opt

Re: [PATCHv3 1/3] git-p4: add failing test for P4EDITOR handling

2015-05-20 Thread Junio C Hamano
Junio C Hamano writes: > Luke Diamand writes: > >> + >> +test_expect_failure 'EDITOR has options' ' >> +# Check that the P4EDITOR argument can be given command-line >> +# options, which git-p4 will then pass through to the shell. >> +test_expect_success 'EDITOR has options' ' >> +git p4 clon

Re: [PATCHv3 1/3] git-p4: add failing test for P4EDITOR handling

2015-05-20 Thread Junio C Hamano
Luke Diamand writes: > + > +test_expect_failure 'EDITOR has options' ' > +# Check that the P4EDITOR argument can be given command-line > +# options, which git-p4 will then pass through to the shell. > +test_expect_success 'EDITOR has options' ' > + git p4 clone --dest="$git" //depot && Oops?