Re: git-gui: automatically move focus to staged file before typing commit message?

2019-10-08 Thread Birger Skogeng Pedersen
Hi Pratyush, On Tue, Oct 8, 2019 at 7:59 PM Pratyush Yadav wrote: > On 07/10/19 06:52PM, Birger Skogeng Pedersen wrote: > > So I kinda got this working, but only when focusing the commit message > > widget. > > Isn't this the point of your feature? You change the view when focusing > the commit

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-10-08 Thread Pratyush Yadav
On 07/10/19 06:52PM, Birger Skogeng Pedersen wrote: > So I kinda got this working, but only when focusing the commit message widget. Isn't this the point of your feature? You change the view when focusing the commit message widget. I remember you were explicitly against doing it as soon as all u

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-10-07 Thread Birger Skogeng Pedersen
So I kinda got this working, but only when focusing the commit message widget. I did not manage to get it working when invoking "do_add_all", (e.g. when pressing CTRL/CMD+i). I added this: bind $ui_comm <$M1B-Key-i> {do_add_all;select_staged_file;break} bind $ui_comm <$M1B-Key-I> {do_add_all;sele

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-26 Thread Birger Skogeng Pedersen
On Thu, Sep 26, 2019 at 9:30 PM Pratyush Yadav wrote: > Why are you changing the Alt+4 binding? I couldn't really find an easier way before. > This means your feature won't > work for people who use the mouse to move around in the UI (which I > suppose would be a majority). True. I would much p

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-26 Thread Pratyush Yadav
On 26/09/19 08:33PM, Birger Skogeng Pedersen wrote: > Honestly I'll need some help to get this one implemented. The only > implementation I've got working currently, is to change Alt+4 key bind > to do the following: > - Focus the "Staged Changes" widget (which will select a path in the > list, if

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-26 Thread Birger Skogeng Pedersen
Honestly I'll need some help to get this one implemented. The only implementation I've got working currently, is to change Alt+4 key bind to do the following: - Focus the "Staged Changes" widget (which will select a path in the list, if it isn't focused already), then - Focus the "Commit Message" w

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-16 Thread Pratyush Yadav
On 15/09/19 09:55AM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > On Sat, Sep 14, 2019 at 11:15 PM Pratyush Yadav > wrote: > > Why should it only happen when the commit message widget is selected? > > What's wrong with directly switching focus when all the files are > > staged? > > > > What

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-15 Thread Birger Skogeng Pedersen
Hi Pratyush, On Sat, Sep 14, 2019 at 11:15 PM Pratyush Yadav wrote: > Why should it only happen when the commit message widget is selected? > What's wrong with directly switching focus when all the files are > staged? > > What I have in mind is once there are no more files to stage, the focus > d

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-14 Thread Pratyush Yadav
On 15/09/19 02:45AM, Pratyush Yadav wrote: > On 14/09/19 02:24PM, Birger Skogeng Pedersen wrote: > > Hi everyone, > > > > > > I personally prefer to have the changes I am about to commit visible > > in the diff view, while I write my commit message. So usually I do > > this: > > 1. Stage the file

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-14 Thread Johannes Sixt
Am 14.09.19 um 23:15 schrieb Pratyush Yadav: > On 14/09/19 02:24PM, Birger Skogeng Pedersen wrote: >> When the user >> stages the last file in the "Unstaged Changes" widget, no file is >> selected and the diff view becomes blank. When this is the case, I >> would prefer that git-gui automatically s

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-14 Thread Pratyush Yadav
On 14/09/19 02:24PM, Birger Skogeng Pedersen wrote: > Hi everyone, > > > I personally prefer to have the changes I am about to commit visible > in the diff view, while I write my commit message. So usually I do > this: > 1. Stage the file(s) I've been working on. > 2. Select a file I just staged,