Re: ds/sparse-cone, was Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-15 Thread Junio C Hamano
Derrick Stolee writes: > On 10/15/2019 3:11 AM, Eric Wong wrote: >> Junio C Hamano wrote: >>> Eric Wong writes: >>> I just took a brief look, but that appears to leak memory. "hashmap_free(var, 1)" should be replaced with "hashmap_free_entries(var, struct foo, member)"

Re: ds/sparse-cone, was Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-15 Thread Derrick Stolee
On 10/15/2019 3:11 AM, Eric Wong wrote: > Junio C Hamano wrote: >> Eric Wong writes: >> >>> I just took a brief look, but that appears to leak memory. >>> >>> "hashmap_free(var, 1)" should be replaced with >>> "hashmap_free_entries(var, struct foo, member)" >>> >>> Only "hashmap_free(var, 0)" can

Re: ds/sparse-cone, was Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-15 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > > I just took a brief look, but that appears to leak memory. > > > > "hashmap_free(var, 1)" should be replaced with > > "hashmap_free_entries(var, struct foo, member)" > > > > Only "hashmap_free(var, 0)" can become "hashmap_free(var)" > > I delibera

Re: ds/sparse-cone, was Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-14 Thread Junio C Hamano
Eric Wong writes: > I just took a brief look, but that appears to leak memory. > > "hashmap_free(var, 1)" should be replaced with > "hashmap_free_entries(var, struct foo, member)" > > Only "hashmap_free(var, 0)" can become "hashmap_free(var)" I deliberately avoided merge-time band-aid fixups on

Re: ds/sparse-cone, was Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-14 Thread Eric Wong
Johannes Schindelin wrote: > On Fri, 11 Oct 2019, Junio C Hamano wrote: > > * ds/sparse-cone (2019-10-08) 17 commits > > - sparse-checkout: cone mode should not interact with .gitignore > > - sparse-checkout: write using lockfile > > - sparse-checkout: update working directory in-process > > -

ds/sparse-cone, was Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-12 Thread Johannes Schindelin
Hi Junio, On Fri, 11 Oct 2019, Junio C Hamano wrote: > * ds/sparse-cone (2019-10-08) 17 commits > - sparse-checkout: cone mode should not interact with .gitignore > - sparse-checkout: write using lockfile > - sparse-checkout: update working directory in-process > - sparse-checkout: sanitize f

Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-11 Thread Junio C Hamano
Junio C Hamano writes: > By the way, I think I made a mistake in my calendar math. > > This topic was merged to 'next' on the 7th and it is not especially > tricky; unless I (or somebody else) find glaring issues in it during > the final sanity check before merging it to 'master' during the next

Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-11 Thread Junio C Hamano
Elijah Newren writes: > Did I shoot myself in the foot by being quick to jump on Rene's couple > of cosmetic touch-up suggestions he posted over a week after the > series was originally posted? If the suggested updates were simple enough to do and would improve the result sufficiently (which is

Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-11 Thread Elijah Newren
On Fri, Oct 11, 2019 at 9:42 AM Junio C Hamano wrote: > > Elijah Newren writes: > > >> * en/fast-imexport-nested-tags (2019-10-04) 8 commits > >> (merged to 'next' on 2019-10-07 at 3e75779e10) > >> + fast-export: handle nested tags > >> ... > >> + fast-export: fix exporting a tag and nothing

Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-11 Thread Junio C Hamano
Elijah Newren writes: >> * en/fast-imexport-nested-tags (2019-10-04) 8 commits >> (merged to 'next' on 2019-10-07 at 3e75779e10) >> + fast-export: handle nested tags >> ... >> + fast-export: fix exporting a tag and nothing else >> >> Updates to fast-import/export. >> >> Will merge to 'mast

Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-11 Thread Elijah Newren
On Fri, Oct 11, 2019 at 12:35 AM Junio C Hamano wrote: > [Cooking] [...] > * en/fast-imexport-nested-tags (2019-10-04) 8 commits > (merged to 'next' on 2019-10-07 at 3e75779e10) > + fast-export: handle nested tags > + t9350: add tests for tags of things other than a commit > + fast-export:

What's cooking in git.git (Oct 2019, #03; Fri, 11)

2019-10-11 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. We may want to merge down fixes ac