Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-03-23 Thread Junio C Hamano
Eric Wong writes: > Correct, it's a good time to pull and I don't expect to have more time > to work on new features (lazy load) for a bit. I was under the > impression you already pulled: > > http://mid.gmane.org/xmqq61aol44q@gitster.dls.corp.google.com Indeed I did. I was fooled by my ow

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-03-23 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > "Kyle J. McKay" wrote: > >> The updated patch with the additional fix is below. > > > > Thanks, signed-off and pushed to master on git://bogomips.org/git-svn > > I've dropped my "destroy all tempfiles..." patch. > > I think I missed this exchange.

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-03-23 Thread Junio C Hamano
Eric Wong writes: > "Kyle J. McKay" wrote: >> The updated patch with the additional fix is below. > > Thanks, signed-off and pushed to master on git://bogomips.org/git-svn > I've dropped my "destroy all tempfiles..." patch. I think I missed this exchange. I see these two patches: e0b4cad

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-26 Thread Eric Wong
"Kyle J. McKay" wrote: > The updated patch with the additional fix is below. Thanks, signed-off and pushed to master on git://bogomips.org/git-svn I've dropped my "destroy all tempfiles..." patch. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-26 Thread Kyle J. McKay
On Feb 26, 2015, at 01:09, Nico Schl=F6mer wrote: > All, > > I applied Kyle's latest patch > >> diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm >> index 622535e2..96888228 100644 >> --- a/perl/Git/SVN/Ra.pm >> +++ b/perl/Git/SVN/Ra.pm >> @@ -391,6 +391,7 @@ sub longest_common_path { >> sub gs_

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-26 Thread Nico Schlömer
All, I applied Kyle's latest patch > diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm > index 622535e2..96888228 100644 > --- a/perl/Git/SVN/Ra.pm > +++ b/perl/Git/SVN/Ra.pm > @@ -391,6 +391,7 @@ sub longest_common_path { > sub gs_fetch_loop_common { > my ($self, $base, $head, $gsv, $

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-25 Thread Kyle J. McKay
On Feb 25, 2015, at 07:07, Nico Schlömer wrote: Thanks Kyle for the patch! I applied it and ran ``` git svn clone https://geuz.org/svn/gmsh/trunk ``` Unfortunately, I'm still getting ``` [...] r100 = e2a9b5baa2cebb18591ecb04ff350410d52f36de (refs/remotes/git-svn) error closing pipe: Bad file des

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-25 Thread Eric Wong
Nico Schlömer wrote: > Thanks Kyle for the patch! I applied it and ran > ``` > git svn clone https://geuz.org/svn/gmsh/trunk > ``` > Unfortunately, I'm still getting > ``` > [...] > r100 = e2a9b5baa2cebb18591ecb04ff350410d52f36de (refs/remotes/git-svn) > error closing pipe: Bad file descriptor at

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-25 Thread Kyle J. McKay
I believe I have been able to track down this problem and implement a fix. Please report back if this patch fixes the problem for you. -Kyle -- 8< -- Subject: [PATCH] Git::SVN::Fetcher: avoid premature 'svn_hash' temp file closure Since b19138b (git-svn: Make it incrementally faster by minimizi

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-16 Thread Eric Wong
Nico Schlömer wrote: > I just double-checked and I can only produce this issue on one machine > (tested on 3). Apparently, this is has nothing to do with Git itself > then. > > Any ideas of what could be wrong? What's different about that one machine? e.g. SVN version, 64 vs 32-bit, Perl version

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-16 Thread Nico Schlömer
I just double-checked and I can only produce this issue on one machine (tested on 3). Apparently, this is has nothing to do with Git itself then. Any ideas of what could be wrong? Cheers, Nico On Thu, Feb 12, 2015 at 8:18 PM, Eric Wong wrote: > Valery Yundin wrote: >> On 31 January 2015 at 13:

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-12 Thread Eric Wong
Valery Yundin wrote: > On 31 January 2015 at 13:51, Nico Schlömer wrote: > > I tried the patch and I still get > > ``` > > [...] > > r100 = e2a9b5baa2cebb18591ecb04ff350410d52f36de (refs/remotes/git-svn) > > Unexpected result returned from git cat-file at > > /home/nschloe/share/perl/5.18.2/Git/S

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-31 Thread Valery Yundin
Hi, It seems that the same commit dfa72fdb96 is responsible for the error in "git svn clone https://geuz.org/svn/gmsh/trunk";. But unlike in my case, the patch doesn't fix it. Cheers, Valery On 31 January 2015 at 13:51, Nico Schlömer wrote: > I tried the patch and I still get > ``` > [...] > r

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-31 Thread Nico Schlömer
I tried the patch and I still get ``` [...] r100 = e2a9b5baa2cebb18591ecb04ff350410d52f36de (refs/remotes/git-svn) Unexpected result returned from git cat-file at /home/nschloe/share/perl/5.18.2/Git/SVN/Fetcher.pm line 335. Failed to read object 619f9d1d857fb287d06a70c9dac6b8b534d0de6a at /home/nsc

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Eric Wong
Valery Yundin wrote: > Hi, > > Your patch seems to fix the problem. > I tried several times and I can svn clone the whole repository in one > go without a crash. Thanks for the confirmation. Cc-ing a few other folks who encountered this problem (and Bcc-ing some folks who emailed me privately).

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Valery Yundin
Hi, Your patch seems to fix the problem. I tried several times and I can svn clone the whole repository in one go without a crash. Thanks, Valery On 30 January 2015 at 01:22, Eric Wong wrote: > Valery Yundin wrote: >> Hi, >> >> Here you go: >> dfa72fdb96befbd790f623bb2909a347176753c2 is the fi

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Eric Wong
Valery Yundin wrote: > Hi, > > Here you go: > dfa72fdb96befbd790f623bb2909a347176753c2 is the first bad commit Thank you. Can you give the following patch a try? I have not been able to reproduce the problem on my end. If it doesn't work out, I might be out of ideas for a bit :/ Increasing --lo

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Valery Yundin
Hi, Here you go: dfa72fdb96befbd790f623bb2909a347176753c2 is the first bad commit commit dfa72fdb96befbd790f623bb2909a347176753c2 Author: Eric Wong Date: Fri Oct 24 22:53:52 2014 + git-svn: reload RA every log-window-size Despite attempting to use local memory pools everywhere we

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Eric Wong
Valery Yundin wrote: > Tested on: > git-svn version 2.3.0.rc2 (svn 1.8.11) - FAIL > git-svn version 2.2.2 (svn 1.8.10) - FAIL > git-svn version 1.8.4.5 (svn 1.8.11) - WORKS Thank you for that info. Do you think you can bisect which versions/revisions of git-svn introduced that failure for us? I

git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Valery Yundin
Hi, Looks like there might be a bug in SVN import code. Here is the command that fails > git svn clone --username anonymous > svn://powhegbox.mib.infn.it/trunk/POWHEG-BOX r217 = 2e6cdb1f4604b2256195590fa8275632971eac42 (refs/remotes/git-svn) M lhefread.f M Z_plus_jet

git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-16 Thread Mike
Similar to the issue mintywalker originally mentioned on Jan 8th 2015, during a "git svn clone" I get a Bad File Descriptor error using: git-svn version 2.2.2 (svn 1.8.8) on Ubuntu 14.04. r460 = 456377de3906d689c56e51af842e18abe086a980 (refs/remotes/origin/trunk) A client/binary/

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-13 Thread Eric Wong
Minty wrote: > § git --version > git version 2.2.1 What about "git svn --version" ? (it'll display the SVN binding version, too) > Any advice / pointers would be welcome -- I'd be happy to run any > tests & I'm reasonably comfortable coding in Perl so happy to poke > around where I can. Great t

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-08 Thread Minty
On Thu, Jan 8, 2015 at 12:43 PM, Minty wrote: > git svn clone https://www.example.com/dshfkjhfsjhsdkjfhsdf/nameofrepo > > r869 = 9823c89bbdfa9d51aeb0a16c539049ae96nd5d62 (refs/remotes/git-svn) > Dpath/to/stuff/Example1.java > Dpath/to/stuff/Example2.java > W: -empty_dir: path/to/st

git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-08 Thread Minty
I appear to have hit a bug (or have data that the code fails on) while importing an SVN repo to git. I'm wondering if there is anything I can do to help find / fix the cause, given I appear to have a fail-case. Sadly I can't supply the SVN repo as the code is private. What I did: git svn clone