test bare repository for unit tests

2018-02-21 Thread Basin Ilya
Hi. I want to the test-repo-git under https://github.com/apache/maven-wagon/tree/master/wagon-providers/wagon-scm/src/test/resources/ just like test-repo-cvs and test-repo-svn Which configuation options would suit that? I think core.compression 0 for human readable diffs. also, I need to force lo

Re: Git should preserve modification times at least on request

2018-02-21 Thread Jacob Keller
On Tue, Feb 20, 2018 at 2:05 PM, Peter Backes wrote: > Hi Jeff, > > On Tue, Feb 20, 2018 at 04:16:34PM -0500, Jeff King wrote: >> I think there are some references buried somewhere in that wiki, but did >> you look at any of the third-party tools that store file metadata >> alongside the files in

Re: [PATCH v2 3/9] t3701: use test_write_lines and write_script

2018-02-21 Thread Phillip Wood
On 20/02/18 17:19, Junio C Hamano wrote: Eric Sunshine writes: test_expect_success 'setup fake editor' ' - echo "#!$SHELL_PATH" >fake_editor.sh && - cat >>fake_editor.sh <<-\EOF && + FAKE_EDITOR="$(pwd)/fake-editor.sh" && + write_script "$FAKE_EDITOR" <<-\EOF &&

Re: [PATCH v2 5/9] t3701: add failing test for pathological context lines

2018-02-21 Thread Phillip Wood
On 19/02/18 11:29, Phillip Wood wrote: From: Phillip Wood When a hunk is skipped by add -i the offsets of subsequent hunks are not adjusted to account for any missing insertions due to the skipped hunk. Most of the time this does not matter as apply uses the context lines to apply the subsequen

Re: [PATCH v2 4/9] t3701: don't hard code sha1 hash values

2018-02-21 Thread Phillip Wood
On 20/02/18 17:39, Junio C Hamano wrote: Phillip Wood writes: From: Phillip Wood Purge the index lines from diffs so we're not hard coding sha1 hash values in the expected output. The motivation of this patch is clear, but all-zero object name for missing side of deletion or creation patch

[ANNOUNCE] Git Rev News edition 36

2018-02-21 Thread Christian Couder
Hi everyone, The 36th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/02/21/edition-36/ Thanks a lot to all the contributors! Enjoy, Christian, Jakub, Markus and Gabriel.

Re: Why git-revert doesn't invoke the pre-commit and the commit-msg hooks?

2018-02-21 Thread Gustavo Chaves
2018-02-20 15:00 GMT-03:00 Junio C Hamano : > It would make more sense (if we were to add > an option to run any hook we currently do not run to the command) to > run pre-revert/revert-msg hooks instead, and then people who happen > to want to do the same thing in these hooks what they do for > ord

Re: Duplicate safecrlf warning for racily clean index entry

2018-02-21 Thread Matt McCutchen
On Tue, 2018-02-20 at 08:42 -0500, Matt McCutchen wrote: > In either case, if "git update-index --refresh" (or "git status") is > run before "git add", then "git add" does not print the warning. On > the other hand, if line endings in the working tree file are changed, > then git shows the file as

Re: Duplicate safecrlf warning for racily clean index entry

2018-02-21 Thread Matt McCutchen
On Wed, 2018-02-21 at 08:53 +0100, Torsten Bögershausen wrote: > I don't hava a pointer, but what should happen ? > 2 warnings for 2 "git add" should be OK, I think. > > 1 warning is part of the optimization, that Git does to handle > hundrets and thousands of files efficciently. > > Is the 1/2 w

Re: Question about get_cached_commit_buffer()

2018-02-21 Thread Derrick Stolee
On 2/20/2018 5:57 PM, Jeff King wrote: On Tue, Feb 20, 2018 at 05:12:50PM -0500, Derrick Stolee wrote: In rev-list, the "--header" option outputs a value and expects the buffer to be cached. It outputs the header info only if get_cached_commit_buffer() returns a non-null buffer, giving incorrec

RE: Stackdump from stash save on Windows 10 64-bit

2018-02-21 Thread Johannes Schindelin
Hi Tim, I re-Cc:ed the Git mailing list, as I do not like the pressure of being the only one you ask for help. On Wed, 21 Feb 2018, Tim Mayo wrote: > > Can you please test with v2.16.2 > > Is there a built version somewhere .. or do I have to build it myself? Yes, official Git for Windows ve

Re: [PATCH] t/known-leaky: add list of known-leaky test scripts

2018-02-21 Thread Junio C Hamano
Martin Ågren writes: > On 19 February 2018 at 22:29, Jeff King wrote: > ... >> Or alternatively, we could just not bother with checking this into the >> repository, and it becomes a local thing for people interested in >> leak-testing. What's the value in having a shared known-leaky list, >> esp

Re: [PATCH v2 4/9] t3701: don't hard code sha1 hash values

2018-02-21 Thread Junio C Hamano
Phillip Wood writes: > Keeping the permission bits makes sense (I'd not thought of them when > I created the patch) as we want to check that the file has the correct > permissions. As for the all-zero object name, is it really worth > leaving it in - if a file has been created or deleted then we'

Re: Duplicate safecrlf warning for racily clean index entry

2018-02-21 Thread Junio C Hamano
Matt McCutchen writes: > ... may be an important optimization.) If the line endings are changed > without changing the size or post-conversion content, then no unstaged > change is reported. It does not appear that git saves the pre- > conversion content. Correct. The cached-stat information

Re: [PATCH 1/2] ref-filter: get rid of duplicate code

2018-02-21 Thread Junio C Hamano
Olga Telezhnaya writes: > Make one function from 2 duplicate pieces and invoke it twice. > > Signed-off-by: Olga Telezhnaia > Mentored-by: Christian Couder > Mentored by: Jeff King > --- > ref-filter.c | 45 + > 1 file changed, 21 insertions(+), 24

Re: [PATCH 2/2] ref-filter: get rid of goto

2018-02-21 Thread Junio C Hamano
Olga Telezhnaya writes: > Get rid of goto command in ref-filter for better readability. > > Signed-off-by: Olga Telezhnaia > Mentored-by: Christian Couder > Mentored by: Jeff King > --- > ref-filter.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) It looks like this is the sam

Re: [PATCH v7 0/7] convert: add support for different encodings

2018-02-21 Thread Lars Schneider
> On 16 Feb 2018, at 19:55, Junio C Hamano wrote: > > Jeff King writes: > >> So a full proposal would support both cases: "check this out in the >> local platform's preferred encoding" and "always check this out in >> _this_ encoding". And Lars's proposal is just the second half of that. > >

Re: [PATCH 00/36] object_id part 12

2018-02-21 Thread Junio C Hamano
"brian m. carlson" writes: > This is the twelfth in a series of patches to convert from unsigned char > [20] to struct object_id. This series is based on next. > > Included in this series are conversions for find_unique_abbrev and > lookup_replace_object, as well as parts of the sha1_file code.

[PATCH v2 2/3] config: respect `pager.config` in list/get-mode only

2018-02-21 Thread Martin Ågren
Similar to de121ffe5 (tag: respect `pager.tag` in list-mode only, 2017-08-02), use the DELAY_PAGER_CONFIG-mechanism to only respect `pager.config` when we are listing or "get"ing config. We have several getters and some are guaranteed to give at most one line of output. Paging all getters includin

Re: [PATCH v4 03/13] commit-graph: create git-commit-graph builtin

2018-02-21 Thread Junio C Hamano
Junio C Hamano writes: > Derrick Stolee writes: > >> +int cmd_commit_graph(int argc, const char **argv, const char *prefix) >> +{ >> +static struct option builtin_commit_graph_options[] = { >> +{ OPTION_STRING, 'p', "object-dir", &opts.obj_dir, >> +N_("dir"),

[PATCH] commit: drop uses of get_cached_commit_buffer()

2018-02-21 Thread Derrick Stolee
The get_cached_commit_buffer() method provides access to the buffer loaded for a struct commit, if it was ever loadead and was not freed. Two places use this to inform how to output information about commits. log-tree.c uses this method to short-circuit the output of commit information when the b

Re: [PATCH v4 01/13] commit-graph: add format document

2018-02-21 Thread Stefan Beller
On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: > Add document specifying the binary format for commit graphs. This > format allows for: > > * New versions. > * New hash functions and hash lengths. > * Optional extensions. > > Basic header information is followed by a binary table of conte

Re: [PATCH v3 00/35] protocol version 2

2018-02-21 Thread Brandon Williams
On 02/06, Brandon Williams wrote: > Changes in v3: > * There were some comments about how the protocol should be designed >stateless first. I've made this change and instead of having to >supply the `stateless-rpc=true` capability to force stateless >behavior, the protocol just requir

[PATCH v2 0/3] Re: t7006: add tests for how git config paginates

2018-02-21 Thread Martin Ågren
This is v2 of my series to teach `git config` to only respect `pager.config` when listing configuration, then changing the default to "on". Thanks to Duy and Junio for feedback on the first version. Based on Duy's feeback, I've changed the approach to more carefully divide the various getters into

Re: [PATCH v4 01/13] commit-graph: add format document

2018-02-21 Thread Derrick Stolee
On 2/21/2018 2:23 PM, Stefan Beller wrote: On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: +In order to allow extensions that add extra data to the graph, we organize +the body into "chunks" and provide a binary lookup table at the beginning +of the body. The header includes certain val

[PATCH v2 1/3] t7006: add tests for how git config paginates

2018-02-21 Thread Martin Ågren
The next couple of commits will change how `git config` handles `pager.config`, similar to how de121ffe5 (tag: respect `pager.tag` in list-mode only, 2017-08-02) and ff1e72483 (tag: change default of `pager.tag` to "on", 2017-08-02) changed `git tag`. Similar work has also been done to `git branch`

Re: [PATCH v4 06/13] commit-graph: implement git commit-graph read

2018-02-21 Thread Junio C Hamano
Derrick Stolee writes: > +'read':: > + > +Read a graph file given by the graph-head file and output basic > +details about the graph file. > ++ > +With `--file=` option, consider the graph stored in the file at > +the path /info/. > + A sample reader confusion after reading the above twice:

Re: [PATCH] submodule: indicate that 'submodule.recurse' doesn't apply to clone

2018-02-21 Thread Junio C Hamano
Brandon Williams writes: > Update the documentation for the 'submodule.recurse' config to identify > that the clone command does not respect it. > > Signed-off-by: Brandon Williams > --- > Documentation/config.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks. > diff --git

Re: [PATCH v4 01/13] commit-graph: add format document

2018-02-21 Thread Stefan Beller
>> >> [ so in small repos, where there are fewer than 256 objects, >> F[i] == F[i+1], for all i'th where there is no object starting with i >> byte] > > > Correct. I'm not sure this additional information is valuable for the > document, though. It is not, I was just making sure I'd understand corr

bug in HTTP protocol spec

2018-02-21 Thread Dorian Taylor
Hello list, I had been banging my head all morning trying to figure out why I couldn’t get a little HTTP implementation to clone/push via the smart protocol (just wrapping git-receive-pack/git-upload-pack). I kept getting the following (likely familiar to some) error: ``` fatal: Could not read

Re: [PATCH v4 02/13] graph: add commit graph design document

2018-02-21 Thread Stefan Beller
> +[3] > https://public-inbox.org/git/20170907094718.b6kuzp2uhvkmw...@sigill.intra.peff.net/t/#m7a2ea7b355aeda962e6b86404bcbadc648abfbba > +More discussion about generation numbers and not storing them inside > +commit objects. A valuable quote: Unlike the other public inbox links this li

Re: [PATCH v4 05/13] commit-graph: implement 'git-commit-graph write'

2018-02-21 Thread Junio C Hamano
Derrick Stolee writes: > +static int graph_write(int argc, const char **argv) > +{ > + ... > + graph_name = write_commit_graph(opts.obj_dir); > + > + if (graph_name) { > + printf("%s\n", graph_name); > + FREE_AND_NULL(graph_name); > + } > + > + return 0; >

Re: Question about get_cached_commit_buffer()

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 01:48:11PM -0500, Jeff King wrote: > > What confuses me about this behavior is that the OID is still shown on the > > repeat (and in the case of `git log --oneline` will not actually have a line > > break between two short-OIDs). I don't believe this behavior is something t

Re: Question about get_cached_commit_buffer()

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 09:13:22AM -0500, Derrick Stolee wrote: > > So there it is. It does show commits multiple times, but suppresses the > > verbose header after the first showing. If we do something like this: > > > >git rev-list --show-all --pretty --boundary c93150cfb0^- > > > > you'll

[PATCH v2 3/3] config: change default of `pager.config` to "on"

2018-02-21 Thread Martin Ågren
This is similar to ff1e72483 (tag: change default of `pager.tag` to "on", 2017-08-02) and is safe now that we do not consider `pager.config` at all when we are not listing or getting configuration. This change will help with listing large configurations, but will not hurt users of `git config --edi

Re: [PATCH] t/known-leaky: add list of known-leaky test scripts

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 08:53:16AM -0800, Junio C Hamano wrote: > Even though keeping track of list of known-leaky tests may not be so > interesting, we can still salvage useful pieces from the discussion > and make them available to developers, e.g. something like > > prove --dry --state=fa

Re: Git should preserve modification times at least on request

2018-02-21 Thread Derek Fawcus
On Mon, Feb 19, 2018 at 10:22:36PM +0100, Peter Backes wrote: > > It is pretty annoying that git cannot, even if I know what I am doing, > and explicitly want it to, preserve the modification time. The use case I've come across where it would be of value is for code archeology, either importing

Re: Git should preserve modification times at least on request

2018-02-21 Thread Phillip Wood
On 20/02/18 22:48, Peter Backes wrote: On Tue, Feb 20, 2018 at 11:32:23PM +0100, Johannes Schindelin wrote: Hi Peter, On Tue, 20 Feb 2018, Peter Backes wrote: On Tue, Feb 20, 2018 at 11:46:38AM +0100, Johannes Schindelin wrote: I would probably invent a file format (``) I'm stuck there b

Re: Git should preserve modification times at least on request

2018-02-21 Thread Ævar Arnfjörð Bjarmason
On Wed, Feb 21 2018, Derek Fawcus jotted: > On Mon, Feb 19, 2018 at 10:22:36PM +0100, Peter Backes wrote: >> >> It is pretty annoying that git cannot, even if I know what I am doing, >> and explicitly want it to, preserve the modification time. > > The use case I've come across where it would be

Re: [PATCH v4 08/13] commit-graph: implement --delete-expired

2018-02-21 Thread Stefan Beller
On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: > graph_name = write_commit_graph(opts.obj_dir); > > if (graph_name) { > if (opts.set_latest) > set_latest_file(opts.obj_dir, graph_name); > > + if (opts.delete_expired) >

Congratulations i willed to you

2018-02-21 Thread Micheal P Anderson
My Dear friend, I am Mr. Micheal Pascal Anderson I got your contact on my personal search of the person.. I willed the only funds left in my account to you. If you want to know why I have willed the only funds left in my account to you please contact the bank manager whose name and address

Re: [PATCH v3 04/35] upload-pack: convert to a builtin

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:12:41 -0800 Brandon Williams wrote: > In order to allow for code sharing with the server-side of fetch in > protocol-v2 convert upload-pack to be a builtin. > > Signed-off-by: Brandon Williams As Stefan mentioned in [1], also mention in the commit message that this means

Re: [PATCH 04/26] upload-pack: convert to a builtin

2018-02-21 Thread Jonathan Nieder
Brandon Williams wrote: > On 01/03, Stefan Beller wrote: > > On Tue, Jan 2, 2018 at 4:18 PM, Brandon Williams wrote: >>> In order to allow for code sharing with the server-side of fetch in >>> protocol-v2 convert upload-pack to be a builtin. >> >> What is the security aspect of this patch? >> >>

Re: [PATCH 05/27] object-store: move packed_git and packed_git_mru to object store

2018-02-21 Thread Junio C Hamano
Stefan Beller writes: > + > +/* > + * The mru list_head is supposed to be initialized using > + * the LIST_HEAD macro, assigning prev/next to itself. > + * However this doesn't work in this case as some compilers dislike > + * that macro on member variables. Use NULL instead as that is defined >

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

2018-02-21 Thread Derrick Stolee
On 2/21/2018 2:17 PM, Derrick Stolee wrote: The get_cached_commit_buffer() method provides access to the buffer loaded for a struct commit, if it was ever loadead and was not freed. Two places use this to inform how to output information about commits. log-tree.c uses this method to short-circu

Re: [PATCH v3 08/35] connect: discover protocol version outside of get_remote_heads

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:12:45 -0800 Brandon Williams wrote: > - get_remote_heads(fd[0], NULL, 0, &ref, 0, NULL, &shallow); > + > + packet_reader_init(&reader, fd[0], NULL, 0, > +PACKET_READ_CHOMP_NEWLINE | > +PACKET_READ_GENTLE_ON_EOF); > + >

Re: Git should preserve modification times at least on request

2018-02-21 Thread Peter Backes
On Wed, Feb 21, 2018 at 10:33:05PM +0100, Ævar Arnfjörð Bjarmason wrote: > This sounds like a sensible job for a git import tool, i.e. import a > target directory into git, and instead of 'git add'-ing the whole thing > it would look at the mtimes, sort files by mtime, then add them in order > and

Re: bug in HTTP protocol spec

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 10:29:35AM -0800, Dorian Taylor wrote: > I didn’t get an insight until I ran with GIT_TRACE_PACKET=true on a > known-good remote (i.e. GitHub), that the null packet-line `` has to > follow the service line. This is not reflected in the example here: > > https://githu

Re: Question about get_cached_commit_buffer()

2018-02-21 Thread Junio C Hamano
Jeff King writes: > I think that repeating the oid is intentional; the point is to dump how > the traversal code is hitting the endpoints, even if we do so multiple > times. > > The --oneline behavior just looks like a bug. I think --format is broken > with --show-all, too (it does not show anyth

Re: [PATCH v4 12/13] commit-graph: read only from specific pack-indexes

2018-02-21 Thread Stefan Beller
On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: > > Teach git-commit-graph to inspect the objects only in a certain list > of pack-indexes within the given pack directory. This allows updating > the commit graph iteratively, since we add all commits stored in a > previous commit graph. > >

Proposal

2018-02-21 Thread melisa mehmet
Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Proposal

2018-02-21 Thread melisa mehmet
Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: [PATCH v2 0/3] Re: t7006: add tests for how git config paginates

2018-02-21 Thread Junio C Hamano
Thanks. The entire thing looked reasonable. Will replace.

Proposal

2018-02-21 Thread melisa mehmet
Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: Git should preserve modification times at least on request

2018-02-21 Thread Ævar Arnfjörð Bjarmason
On Wed, Feb 21 2018, Peter Backes jotted: > On Wed, Feb 21, 2018 at 10:33:05PM +0100, Ævar Arnfjörð Bjarmason wrote: >> This sounds like a sensible job for a git import tool, i.e. import a >> target directory into git, and instead of 'git add'-ing the whole thing >> it would look at the mtimes, s

Re: [PATCH v3 12/35] serve: introduce git-serve

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:12:49 -0800 Brandon Williams wrote: > .gitignore | 1 + > Documentation/technical/protocol-v2.txt | 114 +++ > Makefile| 2 + > builtin.h | 1 + > builtin/serve.c

Re: Question about get_cached_commit_buffer()

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 02:22:05PM -0800, Junio C Hamano wrote: > > I think that repeating the oid is intentional; the point is to dump how > > the traversal code is hitting the endpoints, even if we do so multiple > > times. > > > > The --oneline behavior just looks like a bug. I think --format i

Re: test bare repository for unit tests

2018-02-21 Thread Ævar Arnfjörð Bjarmason
On Wed, Feb 21 2018, Basin Ilya jotted: > Hi. > I want to the test-repo-git under > https://github.com/apache/maven-wagon/tree/master/wagon-providers/wagon-scm/src/test/resources/ > just like test-repo-cvs and test-repo-svn > > Which configuation options would suit that? > I think core.compressi

Re: [PATCH v3 14/35] connect: request remote refs using v2

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:12:51 -0800 Brandon Williams wrote: > +extern struct ref **get_remote_refs(int fd_out, struct packet_reader *reader, > + struct ref **list, int for_push, > + const struct argv_array *ref_patterns); I haven't l

Proposal

2018-02-21 Thread melisa mehmet
Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Proposal

2018-02-21 Thread melisa mehmet
Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: [PATCH v3 15/35] transport: convert get_refs_list to take a list of ref patterns

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:12:52 -0800 Brandon Williams wrote: > @@ -21,7 +22,8 @@ struct transport_vtable { >* the ref without a huge amount of effort, it should store it >* in the ref's old_sha1 field; otherwise it should be all 0. >**/ > - struct ref *(*get_refs_list)(s

Re: [PATCH v3 16/35] transport: convert transport_get_remote_refs to take a list of ref patterns

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:12:53 -0800 Brandon Williams wrote: > -const struct ref *transport_get_remote_refs(struct transport *transport) > +const struct ref *transport_get_remote_refs(struct transport *transport, > + const struct argv_array > *ref_patterns)

Re: Question about get_cached_commit_buffer()

2018-02-21 Thread Junio C Hamano
Jeff King writes: > Out of curiosity, do you actually use --show-all for anything? Absolutely not. I'd actually love it if I could say "not anymore" instead, but I haven't had an opportunity to debug the revision traversal code for quite some time so I do not even remember when was the last tim

Investment Project

2018-02-21 Thread Ms Melisa Mehmet
Hello, I have a business proposal i would like to discuss with you, reply if you are interested for more info. Thank You. Ms. Melisa Mehmet My Skype ID: ms.melisameh...@hotmail.com WhatsApp": +90 534 716 2603

Re: Git should preserve modification times at least on request

2018-02-21 Thread Peter Backes
On Wed, Feb 21, 2018 at 11:44:13PM +0100, Ævar Arnfjörð Bjarmason wrote: > If it were added as a first-level feature to git it would present a lot > of UX confusion. E.g. you run "git add" and it'll be showing the mtime > somehow, or you get a formatted patch over E-Mail and it doesn't only > inclu

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 02:17:11PM -0500, Derrick Stolee wrote: > The get_cached_commit_buffer() method provides access to the buffer > loaded for a struct commit, if it was ever loadead and was not freed. > > Two places use this to inform how to output information about commits. > > log-tree.c

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

2018-02-21 Thread Stefan Beller
> Subject: [PATCH] commit: drop uses of get_cached_commit_buffer() > --- > builtin/rev-list.c | 2 +- > log-tree.c | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) Now if we'd get around to rewrite pretty.c as well, we could make it static, giving a stronger reason of not using

[PATCH] revision: drop --show-all option

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 03:03:18PM -0800, Junio C Hamano wrote: > > So what I'm wondering is whether we should consider just ripping it out > > (but I'm OK with keeping it, as once the commit-buffer stuff is fixed, > > it's probably not hurting anybody). > > I see no problem in removing it. With

Bug: git log: boundary commits do not respect order (e.g. date-order, topo-order)

2018-02-21 Thread Josh Tepper
When using git log, boundary commits (ie, those commits added by specifying --boundary) do not respect the order (e.g., --date-order, --topo-order). Consider the following commit history, where number indicates the order of the commit timestamps: 0125 <--A \ \

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 03:22:02PM -0800, Stefan Beller wrote: > > Subject: [PATCH] commit: drop uses of get_cached_commit_buffer() > > --- > > builtin/rev-list.c | 2 +- > > log-tree.c | 3 --- > > 2 files changed, 1 insertion(+), 4 deletions(-) > > Now if we'd get around to rewrite pre

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

2018-02-21 Thread Jeff King
On Wed, Feb 21, 2018 at 02:19:17PM -0500, Derrick Stolee wrote: > > These behaviors are undocumented, untested, and unlikely to be > > expected by users or other software attempting to parse this output. > > > > Helped-by: Jeff King > > Signed-off-by: Derrick Stolee > > This would be a good ti

Re: [PATCH 04/26] upload-pack: convert to a builtin

2018-02-21 Thread Junio C Hamano
Jonathan Nieder writes: > For defense in depth, it would be comforting if the git wrapper had > some understanding of "don't support --help in handle_builtin when > invoked as a dashed command". That is, I don't expect that anyone has > been relying on > > git-add --help > > acting like >

Re: [PATCH] revision: drop --show-all option

2018-02-21 Thread Linus Torvalds
On Wed, Feb 21, 2018 at 3:27 PM, Jeff King wrote: > > We'll skip the usual deprecation period because this was > explicitly a debugging aid that was never documented. Ack. I don't think I've used it since, and probably nobody else ever used it. Linus

Re: [PATCH v3 20/35] upload-pack: introduce fetch server command

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:12:57 -0800 Brandon Williams wrote: > +want > + Indicates to the server an object which the client wants to > + retrieve. Mention that the client can "want" anything even if not advertised by the server (like uploadpack.allowanysha1inwant). > +output = *s

Re: bug in HTTP protocol spec

2018-02-21 Thread Dorian Taylor
> On Feb 21, 2018, at 2:15 PM, Jeff King wrote: > > Thanks, I agree the document is buggy. Do you want to submit a patch? Will this do? Note I am not sure what the story is behind that `version 1` element, whether it's supposed to go before or after the null packet or if there should be anot

Re: [PATCH v3 24/35] connect: refactor git_connect to only get the protocol version once

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:13:01 -0800 Brandon Williams wrote: > Instead of having each builtin transport asking for which protocol > version the user has configured in 'protocol.version' by calling > `get_protocol_version_config()` multiple times, factor this logic out > so there is just a single ca

Re: Bug: git log: boundary commits do not respect order (e.g. date-order, topo-order)

2018-02-21 Thread Josh Tepper
TYPO IN EXPECTED OUTPUT. To avoid inevitable confusion, creating new thread "Bug: git log: boundary commits do not respect order (e.g. date-order, topo-order) 2". DON'T REPLY TO THIS MESSAGE. Instead reply to the new message On Wed, Feb 21, 2018 at 6:28 PM, Josh Tepper wrote: > When using git

Bug: git log: boundary commits do not respect order (e.g. date-order, topo-order) 2

2018-02-21 Thread Josh Tepper
When using git log, boundary commits (ie, those commits added by specifying --boundary) do not respect the order (e.g., --date-order, --topo-order). Consider the following commit history, where number indicates the order of the commit timestamps: 0125 <--A \ \

RE: Git should preserve modification times at least on request

2018-02-21 Thread Randall S. Becker
On February 21, 2018 6:13 PM, Peter Backes wrote: > On Wed, Feb 21, 2018 at 11:44:13PM +0100, Ævar Arnfjörð Bjarmason wrote: > > If it were added as a first-level feature to git it would present a > > lot of UX confusion. E.g. you run "git add" and it'll be showing the > > mtime somehow, or you get

Re: [PATCH v3 28/35] transport-helper: introduce stateless-connect

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:13:05 -0800 Brandon Williams wrote: > Introduce the transport-helper capability 'stateless-connect'. This > capability indicates that the transport-helper can be requested to run > the 'stateless-connect' command which should attempt to make a > stateless connection with a

Re: [PATCH v3 30/35] remote-curl: create copy of the service name

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:13:07 -0800 Brandon Williams wrote: > Make a copy of the service name being requested instead of relying on > the buffer pointed to by the passed in 'const char *' to remain > unchanged. > > Signed-off-by: Brandon Williams Probably worth mentioning in the commit message:

Re: [PATCH v3 32/35] http: allow providing extra headers for http requests

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:13:09 -0800 Brandon Williams wrote: > @@ -172,6 +172,8 @@ struct http_get_options { >* for details. >*/ > struct strbuf *base_url; > + > + struct string_list *extra_headers; Document this? For example: If not NULL, additional HTTP headers to be

Re: [PATCH v3 35/35] remote-curl: don't request v2 when pushing

2018-02-21 Thread Jonathan Tan
On Tue, 6 Feb 2018 17:13:12 -0800 Brandon Williams wrote: > +test_expect_success 'push with http:// and a config of v2 does not request > v2' ' > + # Till v2 for push is designed, make sure that if a client has > + # protocol.version configured to use v2, that the client instead falls >

Re: [PATCH 07/27] pack: move prepare_packed_git_run_once to object store

2018-02-21 Thread Jonathan Tan
On Tue, 20 Feb 2018 17:54:10 -0800 Stefan Beller wrote: > Each repository's object store can be initialized independently, so > they must not share a run_once variable. > > Signed-off-by: Stefan Beller > Signed-off-by: Jonathan Nieder Reviewed-by: Jonathan Tan > -#define RAW_OBJECT_STORE_IN

Re: [PATCH v3 0/3] Add "git rebase --show-current-patch"

2018-02-21 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Compared to v2: > > - the potential loss of errno before it's printed out in builtin/am.c > is fixed. > - keep update_ref() in sequencer.c non-fatal like this rest > - rename ORIG_COMMIT to REBASE_HEAD > > Interdiff: This round hasn't seen any comments. Is ever

Re: [PATCH v5 00/17] document & test fetch pruning & add fetch.pruneTags

2018-02-21 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Here's a v5 (correct subject line this time!). Many thanks to Eric for > a thorough review. We haven't seen any comments on this round. Is everybody happy? I do not have a strong opinion on the new feature, either for or against. I didn't find anything major

Re: [PATCH 00/36] object_id part 12

2018-02-21 Thread brian m. carlson
On Wed, Feb 21, 2018 at 10:47:19AM -0800, Junio C Hamano wrote: > "brian m. carlson" writes: > > > This is the twelfth in a series of patches to convert from unsigned char > > [20] to struct object_id. This series is based on next. > > > > Included in this series are conversions for find_unique_

Re: [PATCHv3 00/27] Moving global state into the repository object (part 1)

2018-02-21 Thread Stefan Beller
On Tue, Feb 20, 2018 at 5:54 PM, Stefan Beller wrote: > v3: > * reverted back to use the repository for most of the functions > (including unduplicating 'ignore_env') > * rebased on master again (I lost that state when doing v2, as > I did both rebase as well as conversion to object store in o

Re: [PATCH 09/27] sha1_file: add raw_object_store argument to alt_odb_usable

2018-02-21 Thread Jonathan Tan
On Tue, 20 Feb 2018 17:54:12 -0800 Stefan Beller wrote: > Add a raw_object_store to alt_odb_usable to be more specific about which > repository to act on. The choice of the repository is delegated to its > only caller link_alt_odb_entry. > > Signed-off-by: Stefan Beller I checked that alt_odb_

What's cooking in git.git (Feb 2018, #03; Wed, 21)

2018-02-21 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. You can find the changes described

Re: [PATCH 15/27] sha1_file: allow prepare_alt_odb to handle arbitrary repositories

2018-02-21 Thread Jonathan Tan
On Tue, 20 Feb 2018 17:54:18 -0800 Stefan Beller wrote: > -void prepare_alt_odb_the_repository(void) > +void prepare_alt_odb(struct repository *r) > { > - const char *alt; > - > - if (the_repository->objects.alt_odb_tail) > + if (r->objects.alt_odb_tail) > return; > >

Re: [PATCH 19/27] sha1_file: add repository argument to map_sha1_file_1

2018-02-21 Thread Jonathan Tan
On Tue, 20 Feb 2018 17:54:22 -0800 Stefan Beller wrote: > Add a repository argument to allow the map_sha1_file_1 caller to be > more specific about which repository to act on. This is a small > mechanical change; it doesn't change the implementation to handle > repositories other than the_reposit

Re: [PATCH 02/27] object-store: migrate alternates struct and functions from cache.h

2018-02-21 Thread Brandon Williams
On 02/20, Stefan Beller wrote: > Migrate the struct alternate_object_database and all its related > functions to the object store as these functions are easier found in > that header. The migration is just a verbatim copy, no need to > include the object store header at any C file, because cache.h

Re: [PATCH 03/27] object-store: move alt_odb_list and alt_odb_tail to object store

2018-02-21 Thread Brandon Williams
On 02/20, Stefan Beller wrote: > In a process with multiple repositories open, alternates should be > associated to a single repository and not shared globally. Move > alt_odb_list and alt_odb_tail into the_repository and adjust callers > to reflect this. > > Now that the alternative object data b

Re: [PATCH 04/27] object-store: free alt_odb_list

2018-02-21 Thread Brandon Williams
On 02/20, Stefan Beller wrote: > Free the memory and reset alt_odb_{list, tail} to NULL. Good to see memory leaks being avoided (well they will be on other repository objects) > > Signed-off-by: Stefan Beller > --- > object.c | 17 + > 1 file changed, 17 insertions(+) > > diff

Re: [PATCH 06/27] object-store: close all packs upon clearing the object store

2018-02-21 Thread Brandon Williams
On 02/20, Stefan Beller wrote: > Signed-off-by: Stefan Beller Straight forward change, looks good. > --- > builtin/am.c | 2 +- > builtin/clone.c| 2 +- > builtin/fetch.c| 2 +- > builtin/merge.c| 2 +- > builtin/receive-pack.c | 2 +- > object.c

Re: [PATCH 22/27] sha1_file: allow sha1_file_name to handle arbitrary repositories

2018-02-21 Thread Jonathan Tan
On Tue, 20 Feb 2018 17:54:25 -0800 Stefan Beller wrote: > Signed-off-by: Stefan Beller > Signed-off-by: Jonathan Nieder Reviewed-by: Jonathan Tan > -void sha1_file_name_the_repository(struct strbuf *buf, const unsigned char > *sha1) > +void sha1_file_name(struct repository *r, struct strbuf

Re: [PATCH 24/27] sha1_file: allow open_sha1_file to handle arbitrary repositories

2018-02-21 Thread Jonathan Tan
On Tue, 20 Feb 2018 17:54:27 -0800 Stefan Beller wrote: > Signed-off-by: Stefan Beller > Signed-off-by: Jonathan Nieder Reviewed-by: Jonathan Tan

Re: [PATCH 08/27] pack: move approximate object count to object store

2018-02-21 Thread Brandon Williams
On 02/20, Stefan Beller wrote: > The approximate_object_count() function maintains a rough count of > objects in a repository to estimate how long object name abbreviates > should be. Object names are scoped to a repository and the > appropriate length may differ by repository, so the object count

  1   2   >