Re: [Gluster-devel] regarding message for '-1' on gerrit

2014-07-06 Thread Pranith Kumar Karampuri
On 07/06/2014 11:05 PM, Vijay Bellur wrote: On 07/06/2014 07:47 PM, Pranith Kumar Karampuri wrote: hi Justin/Vijay, I always felt '-1' saying 'I prefer you didn't submit this' is a bit harsh. Most of the times all it means is 'Need some more changes' Do you think we can change this messag

Re: [Gluster-devel] 3.6 Feature Freeze - move to mid next week?

2014-07-06 Thread Vijay Bellur
On 07/05/2014 01:54 AM, Justin Clift wrote: On 04/07/2014, at 12:30 PM, Vijay Bellur wrote: Hi All, Given the holiday weekend in US, I feel that it would be appropriate to move the 3.6 feature freeze date to mid next week so that we can have more reviews done & address review comments too. We

Re: [Gluster-devel] regarding message for '-1' on gerrit

2014-07-06 Thread Vijay Bellur
On 07/06/2014 07:47 PM, Pranith Kumar Karampuri wrote: hi Justin/Vijay, I always felt '-1' saying 'I prefer you didn't submit this' is a bit harsh. Most of the times all it means is 'Need some more changes' Do you think we can change this message? The message can be changed. What would e

Re: [Gluster-devel] FS Sanity daily results.

2014-07-06 Thread Pranith Kumar Karampuri
On 07/06/2014 02:53 AM, Benjamin Turner wrote: Hi all. I have been running FS sanity on daily builds(glusterfs mounts only at this point) for a few days for a few days and I have been hitting a couple of problems: final pass/fail report = Test Date: Sat J

[Gluster-devel] regarding message for '-1' on gerrit

2014-07-06 Thread Pranith Kumar Karampuri
hi Justin/Vijay, I always felt '-1' saying 'I prefer you didn't submit this' is a bit harsh. Most of the times all it means is 'Need some more changes' Do you think we can change this message? Pranith ___ Gluster-devel mailing list Gluster-devel

Re: [Gluster-devel] Problem with smoke, regression ordering

2014-07-06 Thread Justin Clift
On 06/07/2014, at 8:24 AM, Pranith Kumar Karampuri wrote: > On 07/06/2014 12:36 PM, Justin Clift wrote: >> * We could also disable the old "regression" job, so it >> doesn't run on build.gluster.org. > This only reduces the race window. Doesn't fix the problem ;-). But I see > your point. It is

Re: [Gluster-devel] Problem with smoke, regression ordering

2014-07-06 Thread Pranith Kumar Karampuri
On 07/06/2014 12:36 PM, Justin Clift wrote: On 06/07/2014, at 8:03 AM, Justin Clift wrote: There are a few ways we could address this: * Adjust the smoke test job so it runs on the Rackspace slaves Hopefully not hard. But not sure. We can try it out. * Change the triggered regressio

Re: [Gluster-devel] Problem with smoke, regression ordering

2014-07-06 Thread Pranith Kumar Karampuri
On 07/06/2014 12:33 PM, Justin Clift wrote: On 05/07/2014, at 5:23 PM, Pranith Kumar Karampuri wrote: hi Justin, If the regression results complete before the smoke test then 'green-tick-mark' is over-written and people don't realize that the regression succeeded by a simple glance at th

Re: [Gluster-devel] Problem with smoke, regression ordering

2014-07-06 Thread Justin Clift
On 06/07/2014, at 8:03 AM, Justin Clift wrote: > There are a few ways we could address this: > > * Adjust the smoke test job so it runs on the Rackspace > slaves > > Hopefully not hard. But not sure. We can try it out. > > * Change the triggered regression test, so it doesn't > start au

Re: [Gluster-devel] Problem with smoke, regression ordering

2014-07-06 Thread Justin Clift
On 05/07/2014, at 5:23 PM, Pranith Kumar Karampuri wrote: > hi Justin, > If the regression results complete before the smoke test then > 'green-tick-mark' is over-written and people don't realize that the > regression succeeded by a simple glance at the list of patches. Can we do > anything