Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-11 Thread 'Dmitry Vyukov' via golang-nuts
On Fri, 11 Feb 2022 at 09:54, wrote: > > If the updated "go/benign-race link" is a canonical url, could you > please share the prefix as well? > ( I tried http://go.dev/go/benign-race and some other variations, but > these don't work. Archive.org link is working. ) Oh, sorry didn't realize this i

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-11 Thread fgergo
If the updated "go/benign-race link" is a canonical url, could you please share the prefix as well? ( I tried http://go.dev/go/benign-race and some other variations, but these don't work. Archive.org link is working. ) On 2/10/22, 'Dmitry Vyukov' via golang-nuts wrote: > I've recovered it and upd

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-10 Thread 'Dan Kortschak' via golang-nuts
On Thu, 2022-02-10 at 09:15 -0800, jake...@gmail.com wrote: > > On Wednesday, February 9, 2022 at 9:14:52 AM UTC-5 peterGo wrote: > > Pelen Li, > > > > Always fix your data races. You should consider the results of data > > races as undefined. > > > > Dmitry Vyukov, who implemented the Go race dete

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-10 Thread 'Dmitry Vyukov' via golang-nuts
I've recovered it and updated the go/benign-race link. On Thu, 10 Feb 2022 at 18:35, Ian Lance Taylor wrote: > > [ + dvyukov ] > > On Thu, Feb 10, 2022 at 9:16 AM jake...@gmail.com wrote: > > > > > > On Wednesday, February 9, 2022 at 9:14:52 AM UTC-5 peterGo wrote: > >> > >> Pelen Li, > >> > >>

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-10 Thread Ian Lance Taylor
[ + dvyukov ] On Thu, Feb 10, 2022 at 9:16 AM jake...@gmail.com wrote: > > > On Wednesday, February 9, 2022 at 9:14:52 AM UTC-5 peterGo wrote: >> >> Pelen Li, >> >> Always fix your data races. You should consider the results of data races as >> undefined. >> >> Dmitry Vyukov, who implemented the

[go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-10 Thread jake...@gmail.com
On Wednesday, February 9, 2022 at 9:14:52 AM UTC-5 peterGo wrote: > Pelen Li, > > Always fix your data races. You should consider the results of data races > as undefined. > > Dmitry Vyukov, who implemented the Go race detector, once wrote an > interesting article with the title: "Benign data r

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-09 Thread 'Axel Wagner' via golang-nuts
While I do agree that the race should be fixed (as I mentioned), I would like to point out that with https://github.com/golang/go/issues/50859 the program posted by OP would have a well-defined, correct outcome. Specifically, the intent of that proposal is: Reads and writes of values larger than a

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-09 Thread Daniel Fava
Since we are on the topic, may be interesting to someone: https://dfava.github.io/papers/fava2020finding.pdf https://dfava.github.io/thesis/dfava_thesis.pdf I’m not so sure I agree with you saying “ whatever the current implementation behavior is” Daniel > On Feb 9, 2022, at 3:45 PM, Robert E

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-09 Thread Robert Engels
See issue 5045 > On Feb 9, 2022, at 8:42 AM, Robert Engels wrote: > >  > The problem with this reasoning is that Go still does not have an explicit > memory model with respect to happens before relationships - falling back on > “whatever the current implementation behavior is”. This makes it

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-09 Thread Robert Engels
The problem with this reasoning is that Go still does not have an explicit memory model with respect to happens before relationships - falling back on “whatever the current implementation behavior is”. This makes it more likely that any change in the compiler will need to continue to support the

Re: [go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-09 Thread peterGo
Pelen Li, Boehm covers your specific case: "there is no reason to believe that a currently working program with “benign races” will continue to work when it is recompiled. Perhaps most surprisingly, this includes even the case of potentially concurrent writes of the same value by different threads

[go-nuts] Re: DataRace with slice, should i fix it or ignore it?

2022-02-09 Thread peterGo
Pelen Li, Always fix your data races. You should consider the results of data races as undefined. Dmitry Vyukov, who implemented the Go race detector, once wrote an interesting article with the title: "Benign data races: what could possibly go wrong?" https://twitter.com/dvyukov/status/28885