[HarfBuzz] build failure in hb-ot-shape-complex-arabic.cc

2010-11-02 Thread Jonathan Kew
Hi Behdad, Please remove the trailing comma from the joining-types enumeration in hb-ot-shape-complex-arabic.cc, as trailing commas in enums can cause a compile error if gcc is feeling strict about things. Thanks, JK

Re: [HarfBuzz] build failure in hb-ot-shape-complex-arabic.cc

2010-11-02 Thread Behdad Esfahbod
Thanks Jonathan. Not intended. I try to avoid that but gcc doesn't have a switch to warn when I miss :(. Will push with my next batch. b On 11/02/10 18:19, Jonathan Kew wrote: > Hi Behdad, > > Please remove the trailing comma from the joining-types enumeration in > hb-ot-shape-complex-arabic

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-11-02 Thread Behdad Esfahbod
src/hb-ot-shape-complex-arabic.cc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f22802431a983bd4bc60a7653b1103973c3475cb Author: Behdad Esfahbod Date: Tue Nov 2 19:12:37 2010 -0400 Remove trailing comma diff --git a/src/hb-ot-shape-complex-arabic.cc b/src/

Re: [HarfBuzz] build failure in hb-ot-shape-complex-arabic.cc

2010-11-02 Thread Behdad Esfahbod
Pushed this one out. By the way, you can push to the main repo now. behdad On 11/02/10 18:58, Behdad Esfahbod wrote: > Thanks Jonathan. Not intended. I try to avoid that but gcc doesn't have a > switch to warn when I miss :(. Will push with my next batch. > > b > > On 11/02/10 18:19, Jonath