[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051050#comment-13051050 ] Hudson commented on HDFS-2003: -- Integrated in Hadoop-Hdfs-trunk #699 (See [https://builds.apa

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050134#comment-13050134 ] Hudson commented on HDFS-2003: -- Integrated in Hadoop-Hdfs-trunk-Commit #746 (See [https://bui

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-09 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046727#comment-13046727 ] Todd Lipcon commented on HDFS-2003: --- +1, good stuff! I'll commit momentarily > Separate

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046429#comment-13046429 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-08 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046191#comment-13046191 ] Todd Lipcon commented on HDFS-2003: --- Looks pretty good. Small nits: - please use curly br

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-08 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046187#comment-13046187 ] Todd Lipcon commented on HDFS-2003: --- bq. @Todd could you give this a quick test with your

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046085#comment-13046085 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046014#comment-13046014 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-08 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045954#comment-13045954 ] Ivan Kelly commented on HDFS-2003: -- Fixed the reading of blocks so that replication is adj

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045754#comment-13045754 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-07 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045721#comment-13045721 ] Todd Lipcon commented on HDFS-2003: --- Did a self-review by going through the diff with the

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-07 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045714#comment-13045714 ] Todd Lipcon commented on HDFS-2003: --- For reviewers, please review http://issues.apache.o

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045470#comment-13045470 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-07 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045438#comment-13045438 ] Ivan Kelly commented on HDFS-2003: -- Ah, hadn't noticed you'd made a bit of code change in

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045232#comment-13045232 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-06 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045171#comment-13045171 ] Ivan Kelly commented on HDFS-2003: -- Im +1 on all these changes. One small question though.

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045173#comment-13045173 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045076#comment-13045076 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-06 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045061#comment-13045061 ] Todd Lipcon commented on HDFS-2003: --- - Looks like a missing import in FSEditLogLoader of

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-06 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044873#comment-13044873 ] Ivan Kelly commented on HDFS-2003: -- I've uploaded a new patch which reduces the number of

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044871#comment-13044871 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-03 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044133#comment-13044133 ] Todd Lipcon commented on HDFS-2003: --- BTW, I thought of another reason why EOFException sh

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-03 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044129#comment-13044129 ] Todd Lipcon commented on HDFS-2003: --- h3. Test stup I ran performance tests with an fsimag

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-03 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043928#comment-13043928 ] Todd Lipcon commented on HDFS-2003: --- bq. This is intentional. We read from the journal wh

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043453#comment-13043453 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-03 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043420#comment-13043420 ] Ivan Kelly commented on HDFS-2003: -- {quote} >From the perspective of FSEditLogLoader, an E

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-03 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043383#comment-13043383 ] Ivan Kelly commented on HDFS-2003: -- I'm still waiting to get access to some big logs. If y

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-02 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043162#comment-13043162 ] Todd Lipcon commented on HDFS-2003: --- A few comments on the patch itself: - FSEditLogLoade

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-06-02 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043134#comment-13043134 ] Todd Lipcon commented on HDFS-2003: --- any luck? I have some big logs around here if you wa

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-05-31 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041807#comment-13041807 ] Ivan Kelly commented on HDFS-2003: -- I was actually discussing the performance implications

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-05-31 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041732#comment-13041732 ] Todd Lipcon commented on HDFS-2003: --- Hey Ivan. Any chance you've been able to do a perfor

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-05-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041526#comment-13041526 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic

2011-05-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039778#comment-13039778 ] Hadoop QA commented on HDFS-2003: - -1 overall. Here are the results of testing the latest