Re: [Intel-gfx] [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks

2018-10-23 Thread Ville Syrjälä
On Mon, Oct 22, 2018 at 03:22:27PM -0700, Paulo Zanoni wrote: > Em Qui, 2018-10-18 às 16:55 +0300, Ville Syrjälä escreveu: > > On Tue, Oct 16, 2018 at 03:01:30PM -0700, Paulo Zanoni wrote: > > > Print a more generic "failed to compute watermark levels" whenever > > > any > > > of

Re: [Intel-gfx] [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks

2018-10-22 Thread Paulo Zanoni
Em Qui, 2018-10-18 às 16:55 +0300, Ville Syrjälä escreveu: > On Tue, Oct 16, 2018 at 03:01:30PM -0700, Paulo Zanoni wrote: > > Print a more generic "failed to compute watermark levels" whenever > > any > > of skl_compute_wm_levels() fail, and print only the specific error > > message for the

Re: [Intel-gfx] [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 04:55:52PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 03:01:30PM -0700, Paulo Zanoni wrote: > > Print a more generic "failed to compute watermark levels" whenever any > > of skl_compute_wm_levels() fail, and print only the specific error > > message for the

Re: [Intel-gfx] [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks

2018-10-18 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 03:01:30PM -0700, Paulo Zanoni wrote: > Print a more generic "failed to compute watermark levels" whenever any > of skl_compute_wm_levels() fail, and print only the specific error > message for the specific cases. This allows us to stop passing pstate > everywhere, making