[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2021-04-25 Thread GitBox
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-826331433 @aalexandrov Thanks for looking into this issue, here's 2 tickets that are related https://issues.apache.org/jira/browse/SPARK-1199 https://issues.apache.org/jira/browse/SPA

[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2021-04-25 Thread GitBox
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-826331433 @aalexandrov Thanks for looking into this issue, here's 2 tickets that are related https://issues.apache.org/jira/browse/SPARK-1199 https://issues.apache.org/jira/browse/SPA

[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2020-05-10 Thread GitBox
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-626482480 @aljoscha I found that the case class issue is caused by `FLINK-10493` which introduce `ScalaCaseClassSerializer`. In our internal flink branch which is based on 1.5 that has no

[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2020-04-27 Thread GitBox
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-620390185 @aljoscha I found the reason why I ran it successfully last time. I only run `mvn test`, but should run `mvn verify`, otherwise the tests under scala folder is not executed.

[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2020-04-27 Thread GitBox
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619966748 It is weird, I remember I ran test successfully before, let me try it again. BTW, do you mean all the tests of scala 2.12 is not enabled in CI ? I thought only tests for flink

[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2020-04-27 Thread GitBox
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619875502 @aljoscha What kind of error do you see ? This is an automated message from the Apache Git Service. To respond t

[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2020-04-25 Thread GitBox
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619481445 @tillrohrmann @aljoscha @zentol Could you help review this PR ? Thanks This is an automated message from the Apac