[GitHub] twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible

2018-11-14 Thread GitBox
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible URL: https://github.com/apache/flink/pull/7087#discussion_r233353227 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/

[GitHub] twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible

2018-11-14 Thread GitBox
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible URL: https://github.com/apache/flink/pull/7087#discussion_r233351993 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/

[GitHub] twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible

2018-11-14 Thread GitBox
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible URL: https://github.com/apache/flink/pull/7087#discussion_r233351993 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/

[GitHub] twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible

2018-11-14 Thread GitBox
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible URL: https://github.com/apache/flink/pull/7087#discussion_r233351993 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/

[GitHub] twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible

2018-11-14 Thread GitBox
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible URL: https://github.com/apache/flink/pull/7087#discussion_r233350930 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/

[GitHub] twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible

2018-11-14 Thread GitBox
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible URL: https://github.com/apache/flink/pull/7087#discussion_r233347043 ## File path: docs/dev/table/connect.md ## @@ -524,7 +525,8 @@ The Kafka c

[GitHub] twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible

2018-11-13 Thread GitBox
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible URL: https://github.com/apache/flink/pull/7087#discussion_r233129481 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/