Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148211942
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -878,113 +880,70 @@ private void scheduleEager
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148434074
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -878,113 +880,70 @@ private void scheduleEager
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148437379
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
---
@@ -476,14 +482,13 @@ else if (numSources
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/4949
[FLINK-7866] [runtime] Weigh list of preferred locations for scheduling
## What is the purpose of the change
This PR fixs
[FLINK-7866](https://issues.apache.org/jira/browse/FLINK-7866
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/4949
Hi, @tillrohrmann Could you please have a rough look at this ? I'm not sure
this is you wanted.
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/4979
RMQSource support disabling queue declaration
## What is the purpose of the change
This PR fixs
[FLINK-8018](https://issues.apache.org/jira/browse/FLINK-8018), RabbitMQ
connector should
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5074
[FLINK-7873] [runtime] Introduce local recovery
## What is the purpose of the change
This PR fixes
[FLINK-7873](https://issues.apache.org/jira/browse/FLINK-7873). Current recover
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5074
@StefanRRichter Could you please have a look at this?
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5074#discussion_r153492082
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java
---
@@ -510,6 +512,13 @@ private static
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5074#discussion_r153492995
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java
---
@@ -510,6 +512,13 @@ private static
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5074#discussion_r153493396
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -190,6 +199,11 @@ public static
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5074#discussion_r153493925
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/CachedCheckpointStreamFactory.java
---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5074#discussion_r153495140
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/CachedCheckpointStreamFactory.java
---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6301#discussion_r201676322
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -111,110 +134,117 @@ public void
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6306
[FLINK-9804][state] KeyedStateBackend.getKeys() does not work on RocksDB
MapState
## What is the purpose of the change
*This PR fixes the bug that the KeyedStateBackend.getKeys() does
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6306
CC @aljoscha
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6301
Hi @jrthe42, In general the checkpoint include two part of works.
- part1: take a snapshot of the state.
- part2: transfer the snapshot to the checkpoint destination(e.g. DFS
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6308#discussion_r201778299
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedBackendSerializationProxy.java
---
@@ -98,8 +103,7 @@ public int getVersion
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6306
@aljoscha Thanks for your quick review, will address your comments while
merging.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5982
@StephanEwen Thanks! Looking forward~
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519294
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityComparable.java
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202516863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java
---
@@ -264,6 +265,42 @@ public void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519024
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueSnapshotRestoreWrapper.java
---
@@ -0,0 +1,102
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202518473
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java
---
@@ -63,54 +72,46 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202517181
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java
---
@@ -85,10 +85,10 @@ public int compare(T o1
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519256
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -446,8 +485,10 @@ public String toString
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202517247
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java
---
@@ -305,6 +351,6 @@ private void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192026051
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeySerializationUtils.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192065096
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeySerializationUtils.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192075543
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192075519
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192075842
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192076835
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192078816
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192078846
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtilsTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192078870
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192080706
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192081137
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192081415
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192082241
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
@StefanRRichter Thanks for your nice review, addressed your comments, could
you please have a look again?
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192331980
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192332556
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192335797
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192335886
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192336298
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192341305
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192342710
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192344507
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192348975
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192350746
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5582#discussion_r192352087
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
@StefanRRichter Thanks for your nice review and preventing this PR to fall
into a sick way, I will change the code according to your comments and ping you
again when I finish this.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5982#discussion_r192374992
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/ClosingAtomicCreatingFSDataOutputStream.java
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4949#discussion_r192384844
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotProfile.java
---
@@ -203,68 +206,104 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4949#discussion_r192402396
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotProfile.java
---
@@ -203,68 +206,104 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4949#discussion_r192406775
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotProfile.java
---
@@ -203,68 +206,104 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4949#discussion_r192407287
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotProfile.java
---
@@ -203,68 +206,104 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6087#discussion_r192723013
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -356,7 +363,8 @@ public void onContainersAllocated(List
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6087#discussion_r192733087
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -406,6 +407,43 @@ public void onError(Throwable error
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6087#discussion_r192732891
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -406,6 +407,43 @@ public void onError(Throwable error
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6087#discussion_r192733056
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -406,6 +407,43 @@ public void onError(Throwable error
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6117
cc @zentol
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6117
[hotfix][checkstyle] fix checkstyle of CEPOperatorTest
## What is the purpose of the change
*fixes checkstyle error introduced by the previous PR.*
## Brief change log
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
Hi @StefanRRichter I updated the PR according to the previous discussions,
could you please have a look when you have time? The travis failed is
unrelated, it's a checkstyle error introduc
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6132
[FLINK-9456][Distributed Coordination]Let ResourceManager notify JobManager
about failed/killed TaskManagers.
## What is the purpose of the change
*Often, the ResourceManager learns
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6133
[FLINK-9351][Distributed Coordination] RM stop assigning slot to Job
because the TM killed before connecting to JM successfully
## What is the purpose of the change
*This PR bases on
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6132
cc @tillrohrmann
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6133
cc @tillrohrmann
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6130#discussion_r193637243
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -970,6 +991,37 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6130#discussion_r193637758
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1093,6 +1178,59 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6130#discussion_r193637932
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1161,7 +1301,53 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6130#discussion_r193638176
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1161,7 +1301,53 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6130#discussion_r193638907
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1355,26 +1541,39
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6132
the failure on travis is unrelated.
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6135
[FLINK-9546][core] Fix the checking of heartbeatTimeoutIntervalMs in
HeartbeatMonitor.
## What is the purpose of the change
The heartbeatTimeoutIntervalMs of HeartbeatMonitor should be
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6135
cc @tillrohrmann
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6144
[hotfix][javadoc]Fix the incorrect java doc for OptionsFactory.
## What is the purpose of the change
*This PR simply fixes the incorrect java doc of `OptionsFactory`.*
## Brief
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194790994
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java
---
@@ -87,40
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194795632
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
---
@@ -237,4
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194796355
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
---
@@ -94,6
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194946663
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBAggregatingState.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194947600
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBAppendingState.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194951373
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBAppendingState.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194951510
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapAppendingState.java
---
@@ -0,0 +1,48 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194951490
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBAppendingState.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194951927
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBAggregatingState.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r194952224
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBAggregatingState.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6156#discussion_r195019971
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
---
@@ -237,4
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6159#discussion_r195168815
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -224,6 +227,15 @@ void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6159#discussion_r195156251
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyGroupPartitioner.java
---
@@ -0,0 +1,227 @@
+/*
+ * Licensed to
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6159#discussion_r195299958
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyGroupPartitioner.java
---
@@ -0,0 +1,227 @@
+/*
+ * Licensed to
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6164
[FLINK-9584][connector] Properly close the output stream in BucketingSink &
RollingSink.
## What is the purpose of the change
This PR fixes the unclosed streams in Bucketing-/Rolling
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6159
@StefanRRichter Sorry that I didn't take a look again yesterday, I was a
bit too busy at that time. I had a look at the fix for the
`CopyOnWriteStateTable`, I afraid it's still a part
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6174
[FLINNK-9601][state]Try to reuse the snapshotData array as the partitioned
destination onâ¦
## What is the purpose of the change
In `CopyOnWriteStateTableSnapshot`, we only reuse the
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6174
CC @StefanRRichter
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903979
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateBinder.java ---
@@ -23,7 +23,10 @@
/**
* The {@code StateBinder} is
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903433
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -203,91 +216,16 @@ private boolean
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903383
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -110,7 +123,7 @@
/**
* Map
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903191
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
1 - 100 of 536 matches
Mail list logo
