Apache9 merged PR #5816:
URL: https://github.com/apache/hbase/pull/5816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2141031153
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2141001057
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2140996098
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2140771619
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Umeshkumar9414 commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2140726106
> The change overall looks good, I wonder if we should add WARN/ERROR log
while setting ForeignExceptionMessage at some places though
On worker side, at RS do have logs for
virajjasani commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2140702502
@Umeshkumar9414 could you pull from latest master one more time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2140503643
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2140489649
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2140486586
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2139755425
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1620761057
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,17 +82,25 @@ public abstract class
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1619031611
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,17 +82,25 @@ public abstract class ServerRemoteProcedure
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2137524077
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2137434305
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2137364177
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2136970940
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1618473493
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,17 +82,25 @@ public abstract class
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1618451655
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,17 +82,25 @@ public abstract class
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1618451655
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,17 +82,25 @@ public abstract class
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1615374507
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,17 +82,25 @@ public abstract class ServerRemoteProcedure
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2132403785
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2132403685
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2132400228
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 23s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2132300676
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 33s |
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1609630113
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,17 +82,25 @@ public abstract class ServerRemoteProcedure
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2119169036
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2119166514
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 59s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2119156778
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 29s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2119107459
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 34s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117794144
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117774150
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117773011
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117204449
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
Umeshkumar9414 commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117121965
I tried to write UT for this by submitting 2 SplitWALProcedure, one before
master failover and one after failover. But Till the time another procedure
completes on RegionServer stub
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2090334812
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 27s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2090324948
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 35s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2090248908
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 56s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2089840560
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 53s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2087729812
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2087725557
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2087690526
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2086882878
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Umeshkumar9414 commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2084727309
The reason for the last build failure is `on project hbase-server: There was
a timeout in the fork -> [Help 1]`.
--
This is an automated message from the Apache Git Service.
To
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2083848185
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2083842999
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2083840692
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2083502346
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1583578291
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1581817417
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1580528932
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2075944485
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2075941381
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2075908528
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
apurtell commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1578559171
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2075582880
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 19s |
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1576598653
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1575047329
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1575047329
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574183543
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574170676
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574170676
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574142648
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574142648
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1573285964
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r156192
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2050759162
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2050749066
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2050737037
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2050503644
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561567738
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,6 +81,8 @@ public abstract class
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561516811
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,6 +81,8 @@ public abstract class
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561516811
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,6 +81,8 @@ public abstract class
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561513882
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561491798
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2046499502
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2046489855
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2046478948
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1558779533
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2046231195
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Umeshkumar9414 opened a new pull request, #5816:
URL: https://github.com/apache/hbase/pull/5816
ServerRemoteProcedure does not have its own serializing implementation, so
had to make changes in all the sub-procedures.
--
This is an automated message from the Apache Git Service.
To
81 matches
Mail list logo